drm/amd/display: reset dcn31 SMU mailbox on failures
Subsystems (3)
PATCH 1/1 drm/amd/display: reset dcn31 SMU mailbox on failures
Otherwise future commands may fail as well leading to downstream problems that look like they stemmed from a timeout the first time but really didn't.
Signed-off-by Mario Limonciello <[email protected]>
--- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_smu.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_smu.c +6 -0
@@ -119,6 +119,12 @@ int dcn31_smu_send_msg_with_param( result =dcn31_smu_wait_for_response (clk_mgr,10 ,200000 ); +if (result == VBIOSSMC_Result_Failed) { +ASSERT (0 ); +REG_WRITE (MP1_SMN_C2PMSG_91 , VBIOSSMC_Result_OK); +return -1 ; + } +if (IS_SMU_TIMEOUT (result)) {ASSERT (0 );dm_helpers_smu_timeout (CTX , msg_id, param,10 *200000 );
Signature · 1 line
2.25.1
Quoted 5 lines · Mario Limonciello
Otherwise future commands may fail as well leading to downstream problems that look like they stemmed from a timeout the first time but really didn't.
Signed-off-by Mario Limonciello <[email protected]>
I guess we used to do this but after we started adding the wait_for_response prior to sending the command this was ignored.
Should be fine.
Reviewed-by Nicholas Kazlauskas <[email protected]>
Regards,
Nicholas Kazlauskas
Quoted 21 lines
--- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_smu.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_smu.c +6
-0@@ -119,6 +119,12 @@ int dcn31_smu_send_msg_with_param( result =dcn31_smu_wait_for_response (clk_mgr,10 ,200000 ); +if (result == VBIOSSMC_Result_Failed) { +ASSERT (0 ); +REG_WRITE (MP1_SMN_C2PMSG_91 , VBIOSSMC_Result_OK); +return -1 ; + } +if (IS_SMU_TIMEOUT (result)) {ASSERT (0 );dm_helpers_smu_timeout (CTX , msg_id, param,10 *200000 );