nvmet: remove nvmet_req_cns_error_complete
Subsystems (2)
Christoph Hellwig
maintainerPATCH 1/1 nvmet: remove nvmet_req_cns_error_complete
Just fold it into the only caller.
Signed-off-by Christoph Hellwig <[email protected]>
--- drivers/nvme/target/admin-cmd.c | 5 ++++- drivers/nvme/target/nvmet.h | 8 -------- 2 files changed, 4 insertions(+), 9 deletions(-)
drivers/nvme/target/admin-cmd.c +4 -1
@@ -721,7 +721,10 @@ static void nvmet_execute_identify(struct nvmet_req *req)break ; } -nvmet_req_cns_error_complete (req); +pr_debug ("unhandled identify cns %d on qid %d\n" , + req->cmd->identify.cns, req->sq->qid); + req->error_loc = offsetof(struct nvme_identify , cns); +nvmet_req_complete (req,NVME_SC_INVALID_FIELD |NVME_SC_DNR ); }/*
drivers/nvme/target/nvmet.h +0 -8
@@ -687,14 +687,6 @@ static inline bool nvmet_use_inline_bvec(struct nvmet_req *req) req->sg_cnt <=NVMET_MAX_INLINE_BIOVEC ; } -static inline void nvmet_req_cns_error_complete (struct nvmet_req *req) -{ -pr_debug ("unhandled identify cns %d on qid %d\n" , - req->cmd->identify.cns, req->sq->qid); - req->error_loc = offsetof(struct nvme_identify , cns); -nvmet_req_complete (req,NVME_SC_INVALID_FIELD |NVME_SC_DNR ); -} -static inline void nvmet_req_bio_put (struct nvmet_req *req,struct bio *bio) {if (bio != &req->b.inline_bio)
Signature · 1 line
2.39.2
Reviewed-by Sagi Grimberg <[email protected]>
Quoted 5 lines · Christoph Hellwig
Just fold it into the only caller.
Signed-off-by Christoph Hellwig <[email protected]>---
I have a same patch which I created when I reviewed your fixes too lazy to send on the top of Damien's, Looks good.
Reviewed-by Chaitanya Kulkarni <[email protected]>
-ck