scsi: ibmvfc: Fix spelling mistake "Deleteing" -> "Deleting"
Subsystems (4)
PATCH 1/1 scsi: ibmvfc: Fix spelling mistake "Deleteing" -> "Deleting"
There is a spelling mistake in a tgt_dbg message. Fix it.
--- drivers/scsi/ibmvscsi/ibmvfc-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/ibmvscsi/ibmvfc-core.c +1 -1
@@ -6141,7 +6141,7 @@ static void ibmvfc_do_work(struct ibmvfc_host *vhost)list_for_each_entry (tgt, &vhost->nvme_scrqs.targets, queue) {if (tgt->action ==IBMVFC_TGT_ACTION_DEL_RPORT ) { -tgt_dbg (tgt,"Deleteing NVMe rport\n" ); +tgt_dbg (tgt,"Deleting NVMe rport\n" ); nvme_rport = tgt->nvme_remote_port;list_del (&tgt->queue);ibmvfc_set_tgt_action (tgt,IBMVFC_TGT_ACTION_DELETED_RPORT );
Signature · 1 line
2.53.0
[email protected]
AI reviewThank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] Uninitialized stack variable rport is evaluated in the NVMe target deletion loop, leading to indeterminate execution behavior and skipped target logout/deletion. --
--- Patch [1]: [PATCH][next] scsi: ibmvfc: Fix spelling mistake "Deleteing" -> "Deleting" --- commit 815533f3bf155a641d39add28605656b69fb9ce0
Author: Colin Ian King <[email protected]>
scsi: ibmvfc: Fix spelling mistake "Deleteing" -> "Deleting"
This commit fixes a spelling mistake in a tgt_dbg message during NVMe rport deletion.
Quoted 3 lines
drivers/scsi/ibmvscsi/ibmvfc-core.c +0
-0
[ ... ]
Quoted 9 lines
drivers/scsi/ibmvscsi/ibmvfc-core.c +1
-1@@ -6141,7 +6141,7 @@ static void ibmvfc_do_work(struct ibmvfc_host *vhost)list_for_each_entry (tgt, &vhost->nvme_scrqs.targets, queue) {if (tgt->action ==IBMVFC_TGT_ACTION_DEL_RPORT ) { -tgt_dbg (tgt,"Deleteing NVMe rport\n" ); +tgt_dbg (tgt,"Deleting NVMe rport\n" ); nvme_rport = tgt->nvme_remote_port;list_del (&tgt->queue);ibmvfc_set_tgt_action (tgt,IBMVFC_TGT_ACTION_DELETED_RPORT );
drivers/scsi/ibmvscsi/ibmvfc-core.c
Quoted 7 lines
drivers/scsi/ibmvscsi/ibmvfc-core.c +0
-0spin_unlock_irqrestore (vhost->host->host_lock, flags);if (nvme_rport)ibmvfc_nvme_unregister_remoteport (tgt);timer_delete_sync (&tgt->timer);kref_put (&tgt->kref, ibmvfc_release_tgt);return ; }else if (rport && tgt->action ==IBMVFC_TGT_ACTION_DEL_AND_LOGOUT_RPORT ) {
[Severity: High]
This isn't a bug introduced by this patch, but is it possible that rport is uninitialized when evaluated here?
Looking at ibmvfc_do_work(), rport is declared as a stack variable:
static void ibmvfc_do_work(struct ibmvfc_host *vhost)
{
...
struct fc_rport *rport;
...If no SCSI targets match the deletion criteria in the earlier loop during IBMVFC_HOST_ACTION_TGT_DEL, rport appears to remain completely uninitialized.
When the code later reaches the NVMe loop shown above and encounters a target with IBMVFC_TGT_ACTION_DEL_AND_LOGOUT_RPORT, it evaluates rport in the condition.
Could this uninitialized memory evaluation cause the target deletion to be silently skipped if it evaluates to 0, leaving the NVMe target in the IBMVFC_TGT_ACTION_DEL_AND_LOGOUT_RPORT state forever?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Tyrel Datwyler
maintainerQuoted 1 line · Colin Ian King
There is a spelling mistake in a
tgt_dbgmessage. Fix it.
I'm going to have to resubmit the series that introduced this that is currently in staging. I'll fix it up on the resubmit.
-Tyrel
Quoted 19 lines
Signed-off-by Colin Ian King <[email protected]>--- drivers/scsi/ibmvscsi/ibmvfc-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/scsi/ibmvscsi/ibmvfc-core.c +1
-1@@ -6141,7 +6141,7 @@ static void ibmvfc_do_work(struct ibmvfc_host *vhost)list_for_each_entry (tgt, &vhost->nvme_scrqs.targets, queue) {if (tgt->action ==IBMVFC_TGT_ACTION_DEL_RPORT ) { -tgt_dbg (tgt,"Deleteing NVMe rport\n" ); +tgt_dbg (tgt,"Deleting NVMe rport\n" ); nvme_rport = tgt->nvme_remote_port;list_del (&tgt->queue);ibmvfc_set_tgt_action (tgt,IBMVFC_TGT_ACTION_DELETED_RPORT );
Martin K. Petersen
AppliedColin,
Quoted 1 line
There is a spelling mistake in a
tgt_dbgmessage. Fix it.
Applied to 7.3/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen