ionic: remove WARN_ON to prevent panic_on_warn
Subsystems (3)
PATCH v2 1/1 ionic: remove WARN_ON to prevent panic_on_warn
From: Nitya Sunkad <[email protected]>
Remove unnecessary early code development check and the WARN_ON that it uses. The irq alloc and free paths have long been cleaned up and this check shouldn't have stuck around so long.
---
v2:
- Remove unnecessary n_qcq->flags & IONIC_QCQ_F_INTR check from early development
drivers/net/ethernet/pensando/ionic/ionic_lif.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/net/ethernet/pensando/ionic/ionic_lif.c +0 -5
@@ -475,11 +475,6 @@ static void ionic_qcqs_free(struct ionic_lif *lif)static void ionic_link_qcq_interrupts (struct ionic_qcq *src_qcq,struct ionic_qcq *n_qcq) { -if (WARN_ON (n_qcq->flags &IONIC_QCQ_F_INTR )) { -ionic_intr_free (n_qcq->cq.lif->ionic, n_qcq->intr.index); - n_qcq->flags &= ~IONIC_QCQ_F_INTR ; - } - n_qcq->intr.vector = src_qcq->intr.vector; n_qcq->intr.index = src_qcq->intr.index; n_qcq->napi_qcq = src_qcq->napi_qcq;
Signature · 1 line
2.17.1
Quoted 6 lines · Shannon Nelson
From: Nitya Sunkad <[email protected]>
Remove unnecessary early code development check and the
WARN_ONthat it uses. The irq alloc and free paths have long been cleaned up and this check shouldn't have stuck around so long.
Quoted 8 lines
Fixes 77ceb68e29cc ("ionic: Add notifyq support")Signed-off-by Nitya Sunkad <[email protected]>Signed-off-by Shannon Nelson <[email protected]>---
v2:
- Remove unnecessaryn_qcq->flags&IONIC_QCQ_F_INTRcheck from early development
Quoted 19 lines
drivers/net/ethernet/pensando/ionic/ionic_lif.c | 5 ----- 1 file changed, 5 deletions(-)drivers/net/ethernet/pensando/ionic/ionic_lif.c +0
-5@@ -475,11 +475,6 @@ static void ionic_qcqs_free(struct ionic_lif *lif)static void ionic_link_qcq_interrupts (struct ionic_qcq *src_qcq,struct ionic_qcq *n_qcq) { -if (WARN_ON (n_qcq->flags &IONIC_QCQ_F_INTR )) { -ionic_intr_free (n_qcq->cq.lif->ionic, n_qcq->intr.index); - n_qcq->flags &= ~IONIC_QCQ_F_INTR ; - } - n_qcq->intr.vector = src_qcq->intr.vector; n_qcq->intr.index = src_qcq->intr.index; n_qcq->napi_qcq = src_qcq->napi_qcq;
This patch was applied to netdev/net.git (main) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:
Quoted 11 lines · On Thu, 6 Jul 2023 11:20:06 -0700 you wrote:
From: Nitya Sunkad <[email protected]>
Remove unnecessary early code development check and the
WARN_ONthat it uses. The irq alloc and free paths have long been cleaned up and this check shouldn't have stuck around so long.Fixes 77ceb68e29cc ("ionic: Add notifyq support")Signed-off-by Nitya Sunkad <[email protected]>Signed-off-by Shannon Nelson <[email protected]>[...]
Here is the summary with links:
- [v2,net] ionic: remove WARN_ON to prevent panic_on_warn
https://git.kernel.org/netdev/net/c/abfb2a58a537
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html