Skip to contentSkip to conversation

mm/slab: remove outdated comment in create_kmalloc_caches()

PATCH Applied Sang-Heon Jeon 3 participants 3 messages Nov 12

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mm/slab: remove outdated comment in create_kmalloc_caches()

Since commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h") removed SLAB, no kmalloc cache is created before create_kmalloc_caches().

So remove the outdated and redundant comment.

---
Changes from v1 [1]
- Remove the whole useless comment

[1] https://lore.kernel.org/all/[email protected]/

---
 mm/slab_common.c | 5 -----
 1 file changed, 5 deletions(-)
mm/slab_common.c +0 -5
index 01c64ef661e7..10603b9cbb53 100644
@@ -1028,11 +1028,6 @@ new_kmalloc_cache(int idx, enum kmalloc_cache_type type)
 		kmalloc_caches[type][idx] = kmalloc_caches[type][aligned_idx];
 }
 
-/*
- * Create the kmalloc array. Some of the regular kmalloc arrays
- * may already have been created because they were needed to
- * enable allocations for slab creation.
- */
 void __init create_kmalloc_caches(void)
 {
 	int i;

base-commit: ce6518e61e3b4bf4f97f7ac6204049b9eba7eb75

Signature · 1 line
2.53.0
maintainer Reviewed-by on v2 1/1
#1 lore raw
Quoted 6 lines · Sang-Heon Jeon

Since commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h") removed SLAB, no kmalloc cache is created before create_kmalloc_caches().

So remove the outdated and redundant comment.

Quoted 28 lines

---
Changes from v1 [1]
- Remove the whole useless comment

[1] https://lore.kernel.org/all/[email protected]/

---
 mm/slab_common.c | 5 -----
 1 file changed, 5 deletions(-)
mm/slab_common.c +0 -5
index 01c64ef661e7..10603b9cbb53 100644
@@ -1028,11 +1028,6 @@ new_kmalloc_cache(int idx, enum kmalloc_cache_type type)
 		kmalloc_caches[type][idx] = kmalloc_caches[type][aligned_idx];
 }
 
-/*
- * Create the kmalloc array. Some of the regular kmalloc arrays
- * may already have been created because they were needed to
- * enable allocations for slab creation.
- */
 void __init create_kmalloc_caches(void)
 {
 	int i;

base-commit: ce6518e61e3b4bf4f97f7ac6204049b9eba7eb75

maintainer Applied
#2 lore raw
In reply to Sang-Heon Jeon
Quoted 4 lines · Sang-Heon Jeon

Since commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h") removed SLAB, no kmalloc cache is created before create_kmalloc_caches().

So remove the outdated and redundant comment.

Applied to mm/slab.git slab/for-next, thanks!

[1/1] mm/slab: remove outdated comment in create_kmalloc_caches()

      commit: a7cdd0af963a420fc0e6f20b7c8bc8d4784098db
Signature · 2 lines
Cheers,
Harry / Hyeonggon