Fix secondary process issue
v6 cover Fix secondary process issue
This patch removes rte_intr_callback_register from secondary process branch.
--V5->V6:
- Fix secondary process issue
V4->V5:
- Fix code style check issue
- Fix l2_len calculate errs for TSO
- Replace mbuf alloc function with initialized
V3->v4:
- Fix receive performance code review comments
- Fix 32-bit build errs for mbox logs
- Modify skb description as mbuf
V2->v3:
- Split hinic.ini and hinic.rst to related feature patches
- Add min_mtu & max_mtu initialization for hinic_dev_infos_get
- Fix fdir config patch with net/hinic/base
- Split link patch into link and fw version getting 2 patches
- Update pmd doc files to new next version
- Add comments for cover letter patch
- Add rxq & txq info getting interfaces
- Fix load intrinsics for receiving packets
v1->v2:
- Fix RSS bugs for vxlan packets inner type
- Add comments for new added func interface
- Fix code review comments from patch v1
- Fix code style problems
- Remove ceq interfaces and definitions that not used
- Fix aeq init bugs, firstly alloc aeq resource, then set aeq ctrl len
- Fix bar map bugs for VF Page size larger than PF
- Modify link state set, add enable or disable fiber in tx direction
- Fix mbox and mgmt channel sync lock mechanism to reduce CPU usage
- Fix FDIR bugs for VRRP packets
- Fit ABI changes from dpdk lib
v1:
- Support SR-IOV function
- Support FLOW API for packet filter
- Support allmulticast mode
- Support MTU set
- Support unicast and multicast MAC set
- Support setting link down and up
- Support get firmware version
- Support inner L3 checksum offload
- Support LRO offload
- Add hinic PMD doc files
Xiaoyun wang (1):
net/hinic: fix secondary process issue
drivers/net/hinic/hinic_pmd_ethdev.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
Signature · 1 line
1.8.3.1
PATCH v6 1/1 net/hinic: fix secondary process issue
The secondary process does not need to register interrupt handle, remove rte_intr_callback_register from secondary process branch.
--- drivers/net/hinic/hinic_pmd_ethdev.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
drivers/net/hinic/hinic_pmd_ethdev.c +3 -7
@@ -2964,14 +2964,10 @@ static int hinic_func_init(struct rte_eth_dev *eth_dev)/* EAL is SECONDARY and eth_dev is already created */ if (rte_eal_process_type () !=RTE_PROC_PRIMARY ) { - rc =rte_intr_callback_register (&pci_dev->intr_handle, - hinic_dev_interrupt_handler, - (void *)eth_dev); -if (rc) -PMD_DRV_LOG (ERR ,"Initialize %s failed in secondary process" , - eth_dev->data->name); +PMD_DRV_LOG (INFO ,"Initialize %s in secondary process" , + eth_dev->data->name); -return rc; +return 0 ; } nic_dev =HINIC_ETH_DEV_TO_PRIVATE_NIC_DEV (eth_dev);
Signature · 1 line
1.8.3.1
Re: [dpdk-dev] [PATCH v6 1/1] net/hinic: fix secondary process issue
Quoted 4 lines · Xiaoyun wang
The secondary process does not need to register interrupt handle, remove
rte_intr_callback_registerfrom secondary process branch.Fixes 06b6a81bbabf ("net/hinic: document missing features")
I can see above patch documents the "Multiprocess aware" feature, but not sure if this patch is a fix for that commit.
Is there any commit that introduces/cause the defect in the code?
Quoted 28 lines
Signed-off-by Xiaoyun wang <[email protected]>--- drivers/net/hinic/hinic_pmd_ethdev.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)drivers/net/hinic/hinic_pmd_ethdev.c +3
-7@@ -2964,14 +2964,10 @@ static int hinic_func_init(struct rte_eth_dev *eth_dev)/* EAL is SECONDARY and eth_dev is already created */ if (rte_eal_process_type () !=RTE_PROC_PRIMARY ) { - rc =rte_intr_callback_register (&pci_dev->intr_handle, - hinic_dev_interrupt_handler, - (void *)eth_dev); -if (rc) -PMD_DRV_LOG (ERR ,"Initialize %s failed in secondary process" , - eth_dev->data->name); +PMD_DRV_LOG (INFO ,"Initialize %s in secondary process" , + eth_dev->data->name); -return rc; +return 0 ; } nic_dev =HINIC_ETH_DEV_TO_PRIVATE_NIC_DEV (eth_dev);
Ferruh Yigit
AppliedRe: [dpdk-dev] [PATCH v6 1/1] net/hinic: fix secondary process issue
Quoted 9 lines · Ferruh Yigit
Quoted 4 lines · Xiaoyun wang
The secondary process does not need to register interrupt handle, remove
rte_intr_callback_registerfrom secondary process branch.Fixes 06b6a81bbabf ("net/hinic: document missing features")I can see above patch documents the "Multiprocess aware" feature, but not sure if this patch is a fix for that commit.
Is there any commit that introduces/cause the defect in the code?
Using following fixes line, to be able to proceed with patch for rc3:
Applied to dpdk-next-net/master, thanks.