Change in openvpn[master]: crypto_backend: Remove md_full
A message that is not in the archive (sent off-list or not yet received): gerrit.1775344373000.Ie2285f5bf52f5c669fb01f9ae36d6aa1674f0929@...2715...
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1612?usp=email
to review the following change.
Change subject: crypto_backend: Remove md_full
......................................................................
crypto_backend: Remove md_full
There was only one user for mbedtls < 4.0,
so remove all the unused implementations.
Identified by cppcheck.
---
M src/openvpn/crypto_backend.h
M src/openvpn/crypto_mbedtls.c
M src/openvpn/crypto_mbedtls_legacy.c
M src/openvpn/crypto_mbedtls_legacy.h
M src/openvpn/crypto_openssl.c
M src/openvpn/ssl_mbedtls.c
6 files changed, 5 insertions(+), 54 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/12/1612/1
src/openvpn/crypto_backend.h +0 -12
@@ -549,18 +549,6 @@* */ -/** -* Calculates the message digest for the given buffer. -* -* @param mdname message digest name -* @param src Buffer to digest. May not be NULL. -* @param src_len The length of the incoming buffer. -* @param dst Buffer to write the message digest to. May not be NULL. -* -* @return true on success, false on failure -*/ -bool md_full (const char *mdname,const uint8_t *src,size_t src_len,uint8_t *dst); -/* * Allocate a new message digest context *
src/openvpn/crypto_mbedtls.c +0 -22
@@ -696,28 +696,6 @@return ctx; } -bool -md_full (const char *mdname,const uint8_t *src,size_t src_len,uint8_t *dst) -{ -const md_info_t *md =md_get (mdname); -if (md ==NULL ) - { -return false; - } - -/* We depend on the caller to ensure that dst has enough room for the hash, -* so we just tell PSA that it can hold the appropriate amount of bytes. */ -size_t dst_size =PSA_HASH_LENGTH (md->psa_alg); -size_t hash_length =0 ; - -psa_status_t status =psa_hash_compute (md->psa_alg, src, src_len, dst, dst_size, &hash_length); -if (status !=PSA_SUCCESS || hash_length != dst_size) - { -return false; - } -return true; -} -void md_ctx_free (md_ctx_t *ctx) {
src/openvpn/crypto_mbedtls_legacy.c +1 -8
@@ -769,7 +769,7 @@*/ -static const mbedtls_md_info_t * +const mbedtls_md_info_t *md_get (const char *digest) {const mbedtls_md_info_t *md =NULL ;
@@ -825,13 +825,6 @@* */ -bool -md_full (const char *mdname,const uint8_t *src,size_t src_len,uint8_t *dst) -{ -const mbedtls_md_info_t *kt =md_get (mdname); -return 0 ==mbedtls_md (kt, src, src_len, dst); -} -mbedtls_md_context_t *md_ctx_new (void ) {
src/openvpn/crypto_mbedtls_legacy.h +2 -0
@@ -137,4 +137,6 @@*/ #define mbed_ok (errval) mbed_log_func_line_lite(D_CRYPT_ERRORS, errval, __func__, __LINE__) +const mbedtls_md_info_t *md_get (const char *digest); +#endif /* CRYPTO_MBEDTLS_H_ */
src/openvpn/crypto_openssl.c +0 -11
@@ -1107,17 +1107,6 @@* */ -bool -md_full (const char *mdname,const uint8_t *src,size_t src_len,uint8_t *dst) -{ -unsigned int in_md_len =0 ; -evp_md_type *kt =md_get (mdname); - -int ret =EVP_Digest (src, src_len, dst, &in_md_len, kt,NULL ); -EVP_MD_free (kt); -return ret ==1 ; -} -EVP_MD_CTX *md_ctx_new (void ) {
src/openvpn/ssl_mbedtls.c +2 -1
@@ -1029,8 +1029,9 @@if (NULL != ctx->crt_chain) {mbedtls_x509_crt *cert = ctx->crt_chain; +const mbedtls_md_info_t *kt =md_get ("SHA256" ); -if (!md_full ("SHA256" , cert->tbs.p, cert->tbs.len, sha256_hash)) +if (0 !=mbedtls_md (kt, cert->tbs.p, cert->tbs.len, sha256_hash)) {msg (M_WARN ,"WARNING: failed to personalise random" ); }
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1612?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie2285f5bf52f5c669fb01f9ae36d6aa1674f0929
Gerrit-Change-Number: 1612
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1612?usp=email )
Change subject: crypto_backend: Remove md_full
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1612?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie2285f5bf52f5c669fb01f9ae36d6aa1674f0929
Gerrit-Change-Number: 1612
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Sun, 05 Apr 2026 10:30:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
PATCH 1/1 crypto_backend: Remove md_full
In reply to a message not in the archiveFrom: Frank Lichtenheld <[email protected]...>
There was only one user for mbedtls < 4.0,
so remove all the unused implementations.
Identified by cppcheck.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1612
---
This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1612
This mail reflects revision 1 of this Change.
Acked-by according to Gerrit (reflected above):
Gert Doering <[email protected]...>
src/openvpn/crypto_backend.h +0 -12
@@ -549,18 +549,6 @@* */ -/** -* Calculates the message digest for the given buffer. -* -* @param mdname message digest name -* @param src Buffer to digest. May not be NULL. -* @param src_len The length of the incoming buffer. -* @param dst Buffer to write the message digest to. May not be NULL. -* -* @return true on success, false on failure -*/ -bool md_full (const char *mdname,const uint8_t *src,size_t src_len,uint8_t *dst); -/* * Allocate a new message digest context *
src/openvpn/crypto_mbedtls.c +0 -22
@@ -696,28 +696,6 @@return ctx; } -bool -md_full (const char *mdname,const uint8_t *src,size_t src_len,uint8_t *dst) -{ -const md_info_t *md =md_get (mdname); -if (md ==NULL ) - { -return false; - } - -/* We depend on the caller to ensure that dst has enough room for the hash, -* so we just tell PSA that it can hold the appropriate amount of bytes. */ -size_t dst_size =PSA_HASH_LENGTH (md->psa_alg); -size_t hash_length =0 ; - -psa_status_t status =psa_hash_compute (md->psa_alg, src, src_len, dst, dst_size, &hash_length); -if (status !=PSA_SUCCESS || hash_length != dst_size) - { -return false; - } -return true; -} -void md_ctx_free (md_ctx_t *ctx) {
src/openvpn/crypto_mbedtls_legacy.c +1 -8
@@ -769,7 +769,7 @@*/ -static const mbedtls_md_info_t * +const mbedtls_md_info_t *md_get (const char *digest) {const mbedtls_md_info_t *md =NULL ;
@@ -825,13 +825,6 @@* */ -bool -md_full (const char *mdname,const uint8_t *src,size_t src_len,uint8_t *dst) -{ -const mbedtls_md_info_t *kt =md_get (mdname); -return 0 ==mbedtls_md (kt, src, src_len, dst); -} -mbedtls_md_context_t *md_ctx_new (void ) {
src/openvpn/crypto_mbedtls_legacy.h +2 -0
@@ -137,4 +137,6 @@*/ #define mbed_ok (errval) mbed_log_func_line_lite(D_CRYPT_ERRORS, errval, __func__, __LINE__) +const mbedtls_md_info_t *md_get (const char *digest); +#endif /* CRYPTO_MBEDTLS_H_ */
src/openvpn/crypto_openssl.c +0 -11
@@ -1107,17 +1107,6 @@* */ -bool -md_full (const char *mdname,const uint8_t *src,size_t src_len,uint8_t *dst) -{ -unsigned int in_md_len =0 ; -evp_md_type *kt =md_get (mdname); - -int ret =EVP_Digest (src, src_len, dst, &in_md_len, kt,NULL ); -EVP_MD_free (kt); -return ret ==1 ; -} -EVP_MD_CTX *md_ctx_new (void ) {
src/openvpn/ssl_mbedtls.c +2 -1
@@ -1029,8 +1029,9 @@if (NULL != ctx->crt_chain) {mbedtls_x509_crt *cert = ctx->crt_chain; +const mbedtls_md_info_t *kt =md_get ("SHA256" ); -if (!md_full ("SHA256" , cert->tbs.p, cert->tbs.len, sha256_hash)) +if (0 !=mbedtls_md (kt, cert->tbs.p, cert->tbs.len, sha256_hash)) {msg (M_WARN ,"WARNING: failed to personalise random" ); }
[Openvpn-devel] [PATCH applied] Re: crypto_backend: Remove md_full
Change looks reasonable, BB is happy with it. Not 2.7 material.
Your patch has been applied to the master branch.
commit 7b44e01b96f6e9fb33af009f359b8dd33c4ae382
Author: Frank Lichtenheld Date: Sun Apr 5 12:31:04 2026 +0200
crypto_backend: Remove md_full
Signed-off-by: Frank Lichtenheld <[email protected]...>
Acked-by: Gert Doering <[email protected]...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1612
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36495.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1612?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: crypto_backend: Remove md_full
......................................................................
crypto_backend: Remove md_full
There was only one user for mbedtls < 4.0,
so remove all the unused implementations.
Identified by cppcheck.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1612
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36495.html
---
M src/openvpn/crypto_backend.h
M src/openvpn/crypto_mbedtls.c
M src/openvpn/crypto_mbedtls_legacy.c
M src/openvpn/crypto_mbedtls_legacy.h
M src/openvpn/crypto_openssl.c
M src/openvpn/ssl_mbedtls.c
6 files changed, 5 insertions(+), 54 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/12/1612/2
src/openvpn/crypto_backend.h +0 -12
@@ -549,18 +549,6 @@* */ -/** -* Calculates the message digest for the given buffer. -* -* @param mdname message digest name -* @param src Buffer to digest. May not be NULL. -* @param src_len The length of the incoming buffer. -* @param dst Buffer to write the message digest to. May not be NULL. -* -* @return true on success, false on failure -*/ -bool md_full (const char *mdname,const uint8_t *src,size_t src_len,uint8_t *dst); -/* * Allocate a new message digest context *
src/openvpn/crypto_mbedtls.c +0 -22
@@ -696,28 +696,6 @@return ctx; } -bool -md_full (const char *mdname,const uint8_t *src,size_t src_len,uint8_t *dst) -{ -const md_info_t *md =md_get (mdname); -if (md ==NULL ) - { -return false; - } - -/* We depend on the caller to ensure that dst has enough room for the hash, -* so we just tell PSA that it can hold the appropriate amount of bytes. */ -size_t dst_size =PSA_HASH_LENGTH (md->psa_alg); -size_t hash_length =0 ; - -psa_status_t status =psa_hash_compute (md->psa_alg, src, src_len, dst, dst_size, &hash_length); -if (status !=PSA_SUCCESS || hash_length != dst_size) - { -return false; - } -return true; -} -void md_ctx_free (md_ctx_t *ctx) {
src/openvpn/crypto_mbedtls_legacy.c +1 -8
@@ -769,7 +769,7 @@*/ -static const mbedtls_md_info_t * +const mbedtls_md_info_t *md_get (const char *digest) {const mbedtls_md_info_t *md =NULL ;
@@ -825,13 +825,6 @@* */ -bool -md_full (const char *mdname,const uint8_t *src,size_t src_len,uint8_t *dst) -{ -const mbedtls_md_info_t *kt =md_get (mdname); -return 0 ==mbedtls_md (kt, src, src_len, dst); -} -mbedtls_md_context_t *md_ctx_new (void ) {
src/openvpn/crypto_mbedtls_legacy.h +2 -0
@@ -137,4 +137,6 @@*/ #define mbed_ok (errval) mbed_log_func_line_lite(D_CRYPT_ERRORS, errval, __func__, __LINE__) +const mbedtls_md_info_t *md_get (const char *digest); +#endif /* CRYPTO_MBEDTLS_H_ */
src/openvpn/crypto_openssl.c +0 -11
@@ -1107,17 +1107,6 @@* */ -bool -md_full (const char *mdname,const uint8_t *src,size_t src_len,uint8_t *dst) -{ -unsigned int in_md_len =0 ; -evp_md_type *kt =md_get (mdname); - -int ret =EVP_Digest (src, src_len, dst, &in_md_len, kt,NULL ); -EVP_MD_free (kt); -return ret ==1 ; -} -EVP_MD_CTX *md_ctx_new (void ) {
src/openvpn/ssl_mbedtls.c +2 -1
@@ -1029,8 +1029,9 @@if (NULL != ctx->crt_chain) {mbedtls_x509_crt *cert = ctx->crt_chain; +const mbedtls_md_info_t *kt =md_get ("SHA256" ); -if (!md_full ("SHA256" , cert->tbs.p, cert->tbs.len, sha256_hash)) +if (0 !=mbedtls_md (kt, cert->tbs.p, cert->tbs.len, sha256_hash)) {msg (M_WARN ,"WARNING: failed to personalise random" ); }
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1612?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie2285f5bf52f5c669fb01f9ae36d6aa1674f0929
Gerrit-Change-Number: 1612
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1612?usp=email )
Change subject: crypto_backend: Remove md_full
......................................................................
crypto_backend: Remove md_full
There was only one user for mbedtls < 4.0,
so remove all the unused implementations.
Identified by cppcheck.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1612
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36495.html
---
M src/openvpn/crypto_backend.h
M src/openvpn/crypto_mbedtls.c
M src/openvpn/crypto_mbedtls_legacy.c
M src/openvpn/crypto_mbedtls_legacy.h
M src/openvpn/crypto_openssl.c
M src/openvpn/ssl_mbedtls.c
6 files changed, 5 insertions(+), 54 deletions(-)
src/openvpn/crypto_backend.h +0 -12
@@ -549,18 +549,6 @@* */ -/** -* Calculates the message digest for the given buffer. -* -* @param mdname message digest name -* @param src Buffer to digest. May not be NULL. -* @param src_len The length of the incoming buffer. -* @param dst Buffer to write the message digest to. May not be NULL. -* -* @return true on success, false on failure -*/ -bool md_full (const char *mdname,const uint8_t *src,size_t src_len,uint8_t *dst); -/* * Allocate a new message digest context *
src/openvpn/crypto_mbedtls.c +0 -22
@@ -696,28 +696,6 @@return ctx; } -bool -md_full (const char *mdname,const uint8_t *src,size_t src_len,uint8_t *dst) -{ -const md_info_t *md =md_get (mdname); -if (md ==NULL ) - { -return false; - } - -/* We depend on the caller to ensure that dst has enough room for the hash, -* so we just tell PSA that it can hold the appropriate amount of bytes. */ -size_t dst_size =PSA_HASH_LENGTH (md->psa_alg); -size_t hash_length =0 ; - -psa_status_t status =psa_hash_compute (md->psa_alg, src, src_len, dst, dst_size, &hash_length); -if (status !=PSA_SUCCESS || hash_length != dst_size) - { -return false; - } -return true; -} -void md_ctx_free (md_ctx_t *ctx) {
src/openvpn/crypto_mbedtls_legacy.c +1 -8
@@ -769,7 +769,7 @@*/ -static const mbedtls_md_info_t * +const mbedtls_md_info_t *md_get (const char *digest) {const mbedtls_md_info_t *md =NULL ;
@@ -825,13 +825,6 @@* */ -bool -md_full (const char *mdname,const uint8_t *src,size_t src_len,uint8_t *dst) -{ -const mbedtls_md_info_t *kt =md_get (mdname); -return 0 ==mbedtls_md (kt, src, src_len, dst); -} -mbedtls_md_context_t *md_ctx_new (void ) {
src/openvpn/crypto_mbedtls_legacy.h +2 -0
@@ -137,4 +137,6 @@*/ #define mbed_ok (errval) mbed_log_func_line_lite(D_CRYPT_ERRORS, errval, __func__, __LINE__) +const mbedtls_md_info_t *md_get (const char *digest); +#endif /* CRYPTO_MBEDTLS_H_ */
src/openvpn/crypto_openssl.c +0 -11
@@ -1107,17 +1107,6 @@* */ -bool -md_full (const char *mdname,const uint8_t *src,size_t src_len,uint8_t *dst) -{ -unsigned int in_md_len =0 ; -evp_md_type *kt =md_get (mdname); - -int ret =EVP_Digest (src, src_len, dst, &in_md_len, kt,NULL ); -EVP_MD_free (kt); -return ret ==1 ; -} -EVP_MD_CTX *md_ctx_new (void ) {
src/openvpn/ssl_mbedtls.c +2 -1
@@ -1029,8 +1029,9 @@if (NULL != ctx->crt_chain) {mbedtls_x509_crt *cert = ctx->crt_chain; +const mbedtls_md_info_t *kt =md_get ("SHA256" ); -if (!md_full ("SHA256" , cert->tbs.p, cert->tbs.len, sha256_hash)) +if (0 !=mbedtls_md (kt, cert->tbs.p, cert->tbs.len, sha256_hash)) {msg (M_WARN ,"WARNING: failed to personalise random" ); }
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1612?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie2285f5bf52f5c669fb01f9ae36d6aa1674f0929
Gerrit-Change-Number: 1612
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>