Skip to contentSkip to conversation

devlink: remove trigger command from devlink-region.rst

PATCH Applied Jacob Keller 3 participants 4 messages Mar 2, 2020 – Mar 4, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 devlink: remove trigger command from devlink-region.rst

The devlink trigger command does not exist. While rewriting the documentation for devlink into the reStructuredText format, documentation for the trigger command was accidentally merged in. This occurred because the author was also working on a potential extension to devlink regions which included this trigger command, and accidentally squashed the documentation incorrectly.

Further review eventually settled on using the previously unused "new" command instead of creating a new trigger command.

Fix this by removing mention of the trigger command from the documentation.

Fixes 0b0f945f5458 ("devlink: add a file documenting devlink regions", 2020-01-10)
---
 Documentation/networking/devlink/devlink-region.rst | 3 ---
 1 file changed, 3 deletions(-)
Documentation/networking/devlink/devlink-region.rst +0 -3
index 1a7683e7acb2..8b46e8591fe0 100644
@@ -40,9 +40,6 @@ example usage
     # Delete a snapshot using:
     $ devlink region del pci/0000:00:05.0/cr-space snapshot 1
 
-    # Trigger (request) a snapshot be taken:
-    $ devlink region trigger pci/0000:00:05.0/cr-space
-
     # Dump a snapshot:
     $ devlink region dump pci/0000:00:05.0/fw-health snapshot 1
     0000000000000000 0014 95dc 0014 9514 0035 1670 0034 db30
Signature · 1 line
2.24.1
#1 lore raw

Heh, forgot to set subject properly, it should be [net].

Thanks,
Jake

Quoted 35 lines · Jacob Keller

The devlink trigger command does not exist. While rewriting the documentation for devlink into the reStructuredText format, documentation for the trigger command was accidentally merged in. This occurred because the author was also working on a potential extension to devlink regions which included this trigger command, and accidentally squashed the documentation incorrectly.

Further review eventually settled on using the previously unused "new" command instead of creating a new trigger command.

Fix this by removing mention of the trigger command from the documentation.

Fixes 0b0f945f5458 ("devlink: add a file documenting devlink regions", 2020-01-10)
---
 Documentation/networking/devlink/devlink-region.rst | 3 ---
 1 file changed, 3 deletions(-)
Documentation/networking/devlink/devlink-region.rst +0 -3
index 1a7683e7acb2..8b46e8591fe0 100644
@@ -40,9 +40,6 @@ example usage
     # Delete a snapshot using:
     $ devlink region del pci/0000:00:05.0/cr-space snapshot 1
 
-    # Trigger (request) a snapshot be taken:
-    $ devlink region trigger pci/0000:00:05.0/cr-space
-
     # Dump a snapshot:
     $ devlink region dump pci/0000:00:05.0/fw-health snapshot 1
     0000000000000000 0014 95dc 0014 9514 0035 1670 0034 db30
maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Jacob Keller
Quoted 10 lines · Mon, Mar 02, 2020 at 11:21:19PM CET, [email protected] wrote:

The devlink trigger command does not exist. While rewriting the documentation for devlink into the reStructuredText format, documentation for the trigger command was accidentally merged in. This occurred because the author was also working on a potential extension to devlink regions which included this trigger command, and accidentally squashed the documentation incorrectly.

Further review eventually settled on using the previously unused "new" command instead of creating a new trigger command.

Quoted 6 lines

Fix this by removing mention of the trigger command from the documentation.

Fixes 0b0f945f5458 ("devlink: add a file documenting devlink regions", 2020-01-10)
maintainer Applied
#3 lore raw
In reply to Jacob Keller

From: Jacob Keller <[email protected]>
Date: Mon, 2 Mar 2020 14:21:19 -0800

Quoted 10 lines

The devlink trigger command does not exist. While rewriting the documentation for devlink into the reStructuredText format, documentation for the trigger command was accidentally merged in. This occurred because the author was also working on a potential extension to devlink regions which included this trigger command, and accidentally squashed the documentation incorrectly.

Further review eventually settled on using the previously unused "new" command instead of creating a new trigger command.

Quoted 6 lines

Fix this by removing mention of the trigger command from the documentation.

Fixes 0b0f945f5458 ("devlink: add a file documenting devlink regions", 2020-01-10)

Applied, thanks.