Skip to contentSkip to conversation

arm: vexpress: don't reset flags in board_init to avoid losing previous ones

PATCH New Arnaud Aujon Chevallier 3 participants 3 messages Nov 15, 2020 – Nov 20, 2020 Arm/versatile express platform

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 arm: vexpress: don't reset flags in board_init to avoid losing previous ones

Re-submitted because of missing description and signed-off.

flags reset in board_init caused bugs when executing command like editenv because the reallocated flag was lost.

---
 board/armltd/vexpress/vexpress_common.c | 1 -
 1 file changed, 1 deletion(-)
board/armltd/vexpress/vexpress_common.c +0 -1
index 70f6cd80d5..8fea8ff352 100644
@@ -55,7 +55,6 @@ int board_init(void)
 {
 	gd->bd->bi_boot_params = LINUX_BOOT_PARAM_ADDR;
 	gd->bd->bi_arch_number = MACH_TYPE_VEXPRESS;
-	gd->flags = 0;
 
 	icache_enable();
 	flash__init();
Signature · 1 line
2.26.2
#2 lore raw

PATCH v3 1/1 arm: vexpress: don't reset flags in board_init to avoid losing previous ones

In reply to Arnaud Aujon Chevallier
Quoted 7 lines · Arnaud Aujon Chevallier

Re-submitted because of missing description and signed-off.

flags reset in board_init caused bugs when executing command like editenv because the reallocated flag was lost.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201119/a3edd751/attachment.sig>