arm64: dts: qcom: sc7180: Drop the unused non-MSA SID
Subsystems (5)
PATCH 1/1 arm64: dts: qcom: sc7180: Drop the unused non-MSA SID
Having a non-MSA (Modem Self-Authentication) SID bypassed breaks modem sandboxing i.e if a transaction were to originate from it, the hardware memory protections units (XPUs) would fail to flag them (any transaction originating from modem are historically termed as an MSA transaction). Drop the unused non-MSA modem SID on SC7180 SoCs and cheza so that SMMU continues to block them.
--- arch/arm64/boot/dts/qcom/sc7180-idp.dts | 2 +- arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/qcom/sc7180-idp.dts +1 -1
@@ -312,7 +312,7 @@ &qupv3_id_1 { &remoteproc_mpss { status = "okay"; compatible = "qcom,sc7180-mss-pil"; - iommus = <&apps_smmu 0x460 0x1>, <&apps_smmu 0x444 0x3>; + iommus = <&apps_smmu 0x461 0x0>, <&apps_smmu 0x444 0x3>; memory-region = <&mba_mem &mpss_mem>; };
arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi +1 -1
@@ -634,7 +634,7 @@ &mdss_mdp { }; &mss_pil { - iommus = <&apps_smmu 0x780 0x1>, + iommus = <&apps_smmu 0x781 0x0>, <&apps_smmu 0x724 0x3>; };
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Quoted 37 lines · Sibi Sankar
Having a non-MSA (Modem Self-Authentication) SID bypassed breaks modem sandboxing i.e if a transaction were to originate from it, the hardware memory protections units (XPUs) would fail to flag them (any transaction originating from modem are historically termed as an MSA transaction). Drop the unused non-MSA modem SID on SC7180 SoCs and cheza so that SMMU continues to block them.
Fixes bec71ba243e95 ("arm64: dts: qcom: sc7180: Update Q6V5 MSS node")Fixes 68aee4af5f620 ("arm64: dts: qcom: sdm845-cheza: Add iommus property")Reported-by Sai Prakash Ranjan <[email protected]>Signed-off-by Sibi Sankar <[email protected]>--- arch/arm64/boot/dts/qcom/sc7180-idp.dts | 2 +- arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)arch/arm64/boot/dts/qcom/sc7180-idp.dts +1
-1@@ -312,7 +312,7 @@ &qupv3_id_1 { &remoteproc_mpss { status = "okay"; compatible = "qcom,sc7180-mss-pil"; - iommus = <&apps_smmu 0x460 0x1>, <&apps_smmu 0x444 0x3>; + iommus = <&apps_smmu 0x461 0x0>, <&apps_smmu 0x444 0x3>; memory-region = <&mba_mem &mpss_mem>; };arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi +0
-0
arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi &mdss_mdp { · line 639
Quoted 7 lines
arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi +1
-1@@ -634,7 +634,7 @@ &mdss_mdp { }; &mss_pil { - iommus = <&apps_smmu 0x780 0x1>, + iommus = <&apps_smmu 0x781 0x0>, <&apps_smmu 0x724 0x3>; };
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Hi,
Quoted 13 lines · Sibi Sankar
Having a non-MSA (Modem Self-Authentication) SID bypassed breaks modem sandboxing i.e if a transaction were to originate from it, the hardware memory protections units (XPUs) would fail to flag them (any transaction originating from modem are historically termed as an MSA transaction). Drop the unused non-MSA modem SID on SC7180 SoCs and cheza so that SMMU continues to block them.
Fixes bec71ba243e95 ("arm64: dts: qcom: sc7180: Update Q6V5 MSS node")Fixes 68aee4af5f620 ("arm64: dts: qcom: sdm845-cheza: Add iommus property")Reported-by Sai Prakash Ranjan <[email protected]>Signed-off-by Sibi Sankar <[email protected]>
Quoted 4 lines
--- arch/arm64/boot/dts/qcom/sc7180-idp.dts | 2 +- arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
I'm not sure if my review is worth all that much since it's not my area of expertise, but as far as I can tell this is good / ready to go in. I've confirmed that a similar on my sc7180 board doesn't seem to break anything for me so restricting things like this seems sane.
-Doug