multipath-tools: fix default blacklist of s390 devices
Subsystems (2)
PATCH 1/1 multipath-tools: fix default blacklist of s390 devices
Each blacklist only their own devices.
---
DASD devices been blacklisted twice, since:
https://github.com/opensvc/multipath-tools/commit/a6ff4f957c78bd15c49278ad359671a705eaf4b5
In the current code:
https://github.com/opensvc/multipath-tools/blob/de16cf82c5263fc148118be56ebf44c8f0ee60b8/libmultipath/blacklist.c#L233
--- libmultipath/hwtable.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
libmultipath/hwtable.c +2 -2
@@ -677,7 +677,7 @@ static struct hwentry default_hw[] = {/* PAV DASD ECKD */ .vendor = "IBM", .product = "S/390 DASD ECKD", - .bl_product = "S/390", + .bl_product = "S/390 DASD ECKD", .uid_attribute = "ID_UID", .no_path_retry = NO_PATH_RETRY_QUEUE, .pgpolicy = MULTIBUS,
@@ -687,7 +687,7 @@ static struct hwentry default_hw[] = {/* PAV DASD FBA */ .vendor = "IBM", .product = "S/390 DASD FBA", - .bl_product = "S/390", + .bl_product = "S/390 DASD FBA", .uid_attribute = "ID_UID", .no_path_retry = NO_PATH_RETRY_QUEUE, .pgpolicy = MULTIBUS,
Signature · 1 line
2.50.1
Quoted 8 lines · Xose Vazquez Perez
libmultipath/hwtable.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)libmultipath/hwtable.c +0
-0
libmultipath/hwtable.c static struct hwentry default_hw[] = { · line 693
Quoted 8 lines
libmultipath/hwtable.c +1
-1@@ -687,7 +687,7 @@ static struct hwentry default_hw[] = {/* PAV DASD FBA */ .vendor = "IBM", .product = "S/390 DASD FBA", - .bl_product = "S/390", + .bl_product = "S/390 DASD FBA", .uid_attribute = "ID_UID", .no_path_retry = NO_PATH_RETRY_QUEUE, .pgpolicy = MULTIBUS,
Is PAV really supported on FBA devices ???
And other than 3390 and 3380(3390 model 2/3 in track-compatibility mode) ECKD types ?
Source, z/vm docs: https://www.vm.ibm.com/storman/pav/pav2.html#2001
Thanks.
Quoted 14 lines · Xose Vazquez Perez
Quoted 12 lines · Xose Vazquez Perez
libmultipath/hwtable.c| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)libmultipath/hwtable.c +0
-1@@ -687,7 +687,7 @@ static struct hwentry default_hw[] = { /* PAV DASD FBA */ .vendor = "IBM", .product = "S/390 DASD FBA", - .bl_product = "S/390",
Quoted 8 lines
libmultipath/hwtable.c static struct hwentry default_hw[] = { · line 693
Quoted 4 lines
libmultipath/hwtable.c +1
-0+ .bl_product = "S/390 DASD FBA", .uid_attribute = "ID_UID", .no_path_retry = NO_PATH_RETRY_QUEUE, .pgpolicy = MULTIBUS,Is PAV really supported on FBA devices ???
And other than 3390 and 3380(3390 model 2/3 in track-compatibility mode) ECKD types ?
I don't know, but either way I don't think blacklisting them would hurt.
Martin
Quoted 4 lines
Source, z/vm docs: https://www.vm.ibm.com/storman/pav/pav2.html#2001
Thanks.
Am 13.07.25 um 00:11 schrieb Xose Vazquez Perez:
Quoted 5 lines · Xose Vazquez Perez
Quoted 4 lines
libmultipath/hwtable.c| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 16 lines
libmultipath/hwtable.c static struct hwentry default_hw[] = { · line 693
Quoted 13 lines
libmultipath/hwtable.c +1
-1@@ -687,7 +687,7 @@ static struct hwentry default_hw[] = { /* PAV DASD FBA */ .vendor = "IBM", .product = "S/390 DASD FBA", - .bl_product = "S/390", + .bl_product = "S/390 DASD FBA", .uid_attribute = "ID_UID", .no_path_retry = NO_PATH_RETRY_QUEUE, .pgpolicy = MULTIBUS,Is PAV really supported on FBA devices ???
And other than 3390 and 3380(3390 model 2/3 in track-compatibility mode) ECKD types ?
Currently there is no support in the driver for PAV with FBA devices. But the devices itself are capable of PAV.
Quoted 5 lines · Stefan Haberland
Quoted 2 lines
Is PAV really supported on FBA devices ???
And other than 3390 and 3380(3390 model 2/3 in track-compatibility mode) ECKD types ?Currently there is no support in the driver for PAV with FBA devices. But the devices itself are capable of PAV.
If there is no PAV support for FBA devices on Linux, and it looks like it won't be implemented even in the distant future. The detection code, and the device, could be deleted from multipath-tools:
https://github.com/opensvc/multipath-tools/blob/de16cf82c5263fc148118be56ebf44c8f0ee60b8/libmultipath/hwtable.c#L688-L697
https://github.com/opensvc/multipath-tools/blob/de16cf82c5263fc148118be56ebf44c8f0ee60b8/libmultipath/discovery.c#L1674-L1685
Is PAV supported on 9343/9345 (cutype/devtype) ECKD devices?
Thanks.
Quoted 10 lines · Xose Vazquez Perez
Quoted 7 lines · Stefan Haberland
Quoted 3 lines
Is PAV really supported on FBA devices ??? And other than 3390 and 3380(3390 model 2/3 in track- compatibility mode) ECKD types ?
Currently there is no support in the driver for PAV with FBA devices.
But the devices itself are capable of PAV.
Quoted 5 lines
If there is no PAV support for FBA devices on Linux, and it looks like it won't be
implemented even in the distant future. The detection code, and the device, could
be deleted from multipath-tools:
I agree. @Stefan, it would be appreciated if you or someone from your group could send a patch.
Martin
Quoted 7 lines
https://github.com/opensvc/multipath-tools/blob/de16cf82c5263fc148118be56ebf44c8f0ee60b8/libmultipath/hwtable.c#L688-L697
https://github.com/opensvc/multipath-tools/blob/de16cf82c5263fc148118be56ebf44c8f0ee60b8/libmultipath/discovery.c#L1674-L1685Is PAV supported on 9343/9345 (cutype/devtype) ECKD devices?
Thanks.
Quoted 12 lines · Martin Wilck
Quoted 9 lines · Xose Vazquez Perez
Quoted 7 lines · Stefan Haberland
Quoted 3 lines
Is PAV really supported on FBA devices ??? And other than 3390 and 3380(3390 model 2/3 in track- compatibility mode) ECKD types ?
Currently there is no support in the driver for PAV with FBA devices.
But the devices itself are capable of PAV.
Quoted 8 lines
Quoted 5 lines
If there is no PAV support for FBA devices on Linux, and it looks like it won't be
implemented even in the distant future. The detection code, and the device, could
be deleted from multipath-tools:I agree. @Stefan, it would be appreciated if you or someone from your group could send a patch.
Something like (untested!):
libmultipath/discovery.c +3 -5
@@ -1677,11 +1677,9 @@ ccw_sysfs_pathinfo (struct path *pp, const struct vector_s *hwtable)if (sysfs_get_devtype (parent, attr_buff,FILE_NAME_SIZE ) <=0 )return PATHINFO_FAILED ; -if (!strncmp (attr_buff,"3370" ,4 )) { -sprintf (pp->product_id,"S/390 DASD FBA" ); - }else if (!strncmp (attr_buff,"9336" ,4 )) { -sprintf (pp->product_id,"S/390 DASD FBA" ); - }else { +// PAV is only supported on ECKD devices. +// Defined in drivers/s390/block/dasd_eckd.c +if (!strncmp (attr_buff,"3390" ,4 ) || !strncmp (attr_buff,"3380" ,4 )) {sprintf (pp->product_id,"S/390 DASD ECKD" ); }
libmultipath/hwtable.c +2 -11
@@ -674,7 +674,8 @@ static struct hwentry default_hw[] = { .no_path_retry = NO_PATH_RETRY_QUEUE, }, { -/* PAV DASD ECKD */ +// PAV DASD ECKD +// "ECKD devices" enumerated in: libmultipath/discovery.c .vendor = "IBM", .product = "S/390 DASD ECKD", .bl_product = "S/390 DASD ECKD",
@@ -683,16 +684,6 @@ static struct hwentry default_hw[] = { .pgpolicy = MULTIBUS, .checker_name = DIRECTIO, }, - { -/* PAV DASD FBA */ - .vendor = "IBM", - .product = "S/390 DASD FBA", - .bl_product = "S/390 DASD FBA", - .uid_attribute = "ID_UID", - .no_path_retry = NO_PATH_RETRY_QUEUE, - .pgpolicy = MULTIBUS, - .checker_name = DIRECTIO, - }, {/* Power RAID */ .vendor = "IBM",
Quoted 17 lines · Xose Vazquez Perez
Each blacklist only their own devices.
Cc Stefan Haberland <[email protected]>Cc Nigel Hislop <[email protected]>Cc Matthias Rudolph <[email protected]>Cc Heiko Carstens <[email protected]>Cc Vasily Gorbik <[email protected]>Cc Alexander Gordeev <[email protected]>Cc Christian Borntraeger <[email protected]>Cc Sven Schnelle <[email protected]>Cc Hannes Reinecke <[email protected]>Cc Martin Wilck <[email protected]>Cc Benjamin Marzinski <[email protected]>Cc Christophe Varoqui <[email protected]>Cc S390-ML <[email protected]>Cc DM-DEVEL-ML <[email protected]>Signed-off-by Xose Vazquez Perez <[email protected]>
Quoted 8 lines
---
DASD devices been blacklisted twice, since:
https://github.com/opensvc/multipath-tools/commit/a6ff4f957c78bd15c49278ad359671a705eaf4b5
In the current code:
https://github.com/opensvc/multipath-tools/blob/de16cf82c5263fc148118be56ebf44c8f0ee60b8/libmultipath/blacklist.c#L233
---
libmultipath/hwtable.c | 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)
Am 12.07.25 um 22:14 schrieb Xose Vazquez Perez:
Quoted 17 lines
Each blacklist only their own devices.
Cc Stefan Haberland <[email protected]>Cc Nigel Hislop <[email protected]>Cc Matthias Rudolph <[email protected]>Cc Heiko Carstens <[email protected]>Cc Vasily Gorbik <[email protected]>Cc Alexander Gordeev <[email protected]>Cc Christian Borntraeger <[email protected]>Cc Sven Schnelle <[email protected]>Cc Hannes Reinecke <[email protected]>Cc Martin Wilck <[email protected]>Cc Benjamin Marzinski <[email protected]>Cc Christophe Varoqui <[email protected]>Cc S390-ML <[email protected]>Cc DM-DEVEL-ML <[email protected]>Signed-off-by Xose Vazquez Perez <[email protected]>
Quoted 6 lines
---
DASD devices been blacklisted twice, since:
https://github.com/opensvc/multipath-tools/commit/a6ff4f957c78bd15c49278ad359671a705eaf4b5
In the current code:
https://github.com/opensvc/multipath-tools/blob/de16cf82c5263fc148118be56ebf44c8f0ee60b8/libmultipath/blacklist.c#L233
---