Skip to contentSkip to conversation

radio-settings: Add handling of dual mode technology preference

PATCH Denis Kenzior 1 participant 1 message Jun 1, 2021 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi Sean,

Quoted 11 lines · Sean Nyekjaer

Allow setting of "lte,gsm" mode,
for modems that doesn't support ANY mode.

---
  src/radio-settings.c | 6 ++++++
  1 file changed, 6 insertions(+)
src/radio-settings.c +0 -0
index 7283aa98..e2e5f33b 100644

src/radio-settings.c static const char *radio_access_mode_to_string(enum ofono_radio_access_mode m) · line 82

Quoted 4 lines
src/radio-settings.c +1 -0
@@ -79,6 +79,9 @@ static const char *radio_access_mode_to_string(enum ofono_radio_access_mode m)
  	if (m == (OFONO_RADIO_ACCESS_MODE_LTE|OFONO_RADIO_ACCESS_MODE_UMTS))
  		return "lte,umts";
 
+	if (m = (OFONO_RADIO_ACCESS_MODE_LTE|OFONO_RADIO_ACCESS_MODE_GSM))

I think you meant '==' here, so I fixed that.

Quoted 7 lines
src/radio-settings.c +2 -0
+		return "lte,gsm";
+
  	return NULL;
  }
 

src/radio-settings.c static gboolean radio_access_mode_from_string(const char *str, · line 115

Quoted 9 lines
src/radio-settings.c +3 -0
@@ -104,6 +107,9 @@ static gboolean radio_access_mode_from_string(const char *str,
  	} else if (g_str_equal(str, "lte,umts")) {
  		*mode = OFONO_RADIO_ACCESS_MODE_LTE|OFONO_RADIO_ACCESS_MODE_UMTS;
  		return TRUE;
+	} else if (g_str_equal(str, "lte,gsm")) {
+		*mode = OFONO_RADIO_ACCESS_MODE_LTE|OFONO_RADIO_ACCESS_MODE_GSM;
+		return TRUE;
  	}
 
  	return FALSE;

All three patches applied, thanks.

Regards,
-Denis