Skip to contentSkip to conversation

ASoC: split pxa ssp for reusing code

PATCH New Haojian Zhuang 2 participants 3 messages Mar 18, 2010 – Mar 19, 2010

lore
Share & tools
lore
#1 lore raw

PATCH 1/5 ASoC: split pxa ssp for reusing code

Quoted 8 lines · Haojian Zhuang

From ffd197865a1114b46cc7d6b0442e4c6ece962f8b Mon Sep 17 00:00:00 2001
From: Haojian Zhuang <[email protected]>
Date: Wed, 17 Mar 2010 10:45:30 -0400
Subject: [PATCH] ASoC: split pxa ssp for reusing code

Since basic SSP features are shared between PXA2xx and PXA168, the difference is focused on clock generating. Now split ssp code into two parts. One is for general ssp feature. The other is for pxa2xx parts.

Could you please provide a more detailed description of what the differences between the two SSP implementations. This description is rather vauge and doesn't appear to 100% tie in with the implemenation - for example, the hw_params() implementations for the two variants seem *very* close to each other.

It may be that some of this stuff can be handled by having a common hw_params() which can be called by device specific code that handles the differences. Given how fiddly the configuration of the framing is having two different implementations to keep in sync doesn't seem good.

#2 lore raw

PATCH 1/5 ASoC: split pxa ssp for reusing code

Quoted 16 lines · Mark Brown
Quoted 8 lines · Haojian Zhuang

From ffd197865a1114b46cc7d6b0442e4c6ece962f8b Mon Sep 17 00:00:00 2001
From: Haojian Zhuang <[email protected]>
Date: Wed, 17 Mar 2010 10:45:30 -0400
Subject: [PATCH] ASoC: split pxa ssp for reusing code

Since basic SSP features are shared between PXA2xx and PXA168, the difference is focused on clock generating. Now split ssp code into two parts. One is for general ssp feature. The other is for pxa2xx parts.

Could you please provide a more detailed description of what the differences between the two SSP implementations. ?This description is rather vauge and doesn't appear to 100% tie in with the implemenation - for example, the hw_params() implementations for the two variants seem *very* close to each other.

Quoted 5 lines

It may be that some of this stuff can be handled by having a common hw_params() which can be called by device specific code that handles the differences. ?Given how fiddly the configuration of the framing is having two different implementations to keep in sync doesn't seem good.

New comment is added in this patch. In this patch, I didn't touch any configuration in pxa2xx. I prefer to adjust it
after new ssp control of pxa910 & pxa688 implemented.

Thanks
Haojian