Skip to contentSkip to conversation

hid: replace snprintf in show functions with sysfs_emit

PATCH New [email protected] 1 participant 1 message Jul 13, 2023 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 hid: replace snprintf in show functions with sysfs_emit

Fix the coccicheck warning:
WARNING: use scnprintf or sprintf.

./drivers/hid/hid-lenovo.c:786:8-16: WARNING: use scnprintf or sprintf ./drivers/hid/hid-lenovo.c:540:8-16: WARNING: use scnprintf or sprintf ./drivers/hid/hid-lenovo.c:905:8-16: WARNING: use scnprintf or sprintf ./drivers/hid/hid-lenovo.c:756:8-16: WARNING: use scnprintf or sprintf ./drivers/hid/hid-lenovo.c:816:8-16: WARNING: use scnprintf or sprintf ./drivers/hid/hid-lenovo.c:846:8-16: WARNING: use scnprintf or sprintf ./drivers/hid/hid-lenovo.c:584:8-16: WARNING: use scnprintf or sprintf ./drivers/hid/hid-lenovo.c:876:8-16: WARNING: use scnprintf or sprintf

---
 drivers/hid/hid-lenovo.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/hid/hid-lenovo.c +8 -8
index 44763c0da444..147fcf69d235 100644
@@ -537,7 +537,7 @@ static ssize_t attr_fn_lock_show(struct device *dev,
     struct hid_device *hdev = to_hid_device(dev);
     struct lenovo_drvdata *data = hid_get_drvdata(hdev);
 
-    return snprintf(buf, PAGE_SIZE, "%u\n", data->fn_lock);
+    return scnprintf(buf, PAGE_SIZE, "%u\n", data->fn_lock);
 }
 
 static ssize_t attr_fn_lock_store(struct device *dev,
@@ -581,7 +581,7 @@ static ssize_t attr_sensitivity_show_cptkbd(struct device *dev,
     struct hid_device *hdev = to_hid_device(dev);
     struct lenovo_drvdata *cptkbd_data = hid_get_drvdata(hdev);
 
-    return snprintf(buf, PAGE_SIZE, "%u\n",
+    return scnprintf(buf, PAGE_SIZE, "%u\n",
         cptkbd_data->sensitivity);
 }
 
@@ -753,7 +753,7 @@ static ssize_t attr_press_to_select_show_tpkbd(struct device *dev,
     struct hid_device *hdev = to_hid_device(dev);
     struct lenovo_drvdata *data_pointer = hid_get_drvdata(hdev);
 
-    return snprintf(buf, PAGE_SIZE, "%u\n", data_pointer->press_to_select);
+    return scnprintf(buf, PAGE_SIZE, "%u\n", data_pointer->press_to_select);
 }
 
 static ssize_t attr_press_to_select_store_tpkbd(struct device *dev,
@@ -783,7 +783,7 @@ static ssize_t attr_dragging_show_tpkbd(struct device *dev,
     struct hid_device *hdev = to_hid_device(dev);
     struct lenovo_drvdata *data_pointer = hid_get_drvdata(hdev);
 
-    return snprintf(buf, PAGE_SIZE, "%u\n", data_pointer->dragging);
+    return scnprintf(buf, PAGE_SIZE, "%u\n", data_pointer->dragging);
 }
 
 static ssize_t attr_dragging_store_tpkbd(struct device *dev,
@@ -813,7 +813,7 @@ static ssize_t attr_release_to_select_show_tpkbd(struct device *dev,
     struct hid_device *hdev = to_hid_device(dev);
     struct lenovo_drvdata *data_pointer = hid_get_drvdata(hdev);
 
-    return snprintf(buf, PAGE_SIZE, "%u\n", data_pointer->release_to_select);
+    return scnprintf(buf, PAGE_SIZE, "%u\n", data_pointer->release_to_select);
 }
 
 static ssize_t attr_release_to_select_store_tpkbd(struct device *dev,
@@ -843,7 +843,7 @@ static ssize_t attr_select_right_show_tpkbd(struct device *dev,
     struct hid_device *hdev = to_hid_device(dev);
     struct lenovo_drvdata *data_pointer = hid_get_drvdata(hdev);
 
-    return snprintf(buf, PAGE_SIZE, "%u\n", data_pointer->select_right);
+    return scnprintf(buf, PAGE_SIZE, "%u\n", data_pointer->select_right);
 }
 
 static ssize_t attr_select_right_store_tpkbd(struct device *dev,
@@ -873,7 +873,7 @@ static ssize_t attr_sensitivity_show_tpkbd(struct device *dev,
     struct hid_device *hdev = to_hid_device(dev);
     struct lenovo_drvdata *data_pointer = hid_get_drvdata(hdev);
 
-    return snprintf(buf, PAGE_SIZE, "%u\n",
+    return scnprintf(buf, PAGE_SIZE, "%u\n",
         data_pointer->sensitivity);
 }
 
@@ -902,7 +902,7 @@ static ssize_t attr_press_speed_show_tpkbd(struct device *dev,
     struct hid_device *hdev = to_hid_device(dev);
     struct lenovo_drvdata *data_pointer = hid_get_drvdata(hdev);
 
-    return snprintf(buf, PAGE_SIZE, "%u\n",
+    return scnprintf(buf, PAGE_SIZE, "%u\n",
         data_pointer->press_speed);
 }