net: vmxnet3: remove unnecessary pci_set_drvdata()
Subsystems (3)
PATCH 1/1 net: vmxnet3: remove unnecessary pci_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by Jingoo Han <[email protected]>
--- drivers/net/vmxnet3/vmxnet3_drv.c | 1 - 1 file changed, 1 deletion(-)
drivers/net/vmxnet3/vmxnet3_drv.c +0 -1
@@ -3132,7 +3132,6 @@ err_alloc_queue_desc: err_alloc_shared:dma_unmap_single (&adapter->pdev->dev, adapter->adapter_pa,sizeof (struct vmxnet3_adapter ),PCI_DMA_TODEVICE ); -pci_set_drvdata (pdev,NULL );free_netdev (netdev);return err; }
Signature · 1 line
1.7.10.4
Quoted 5 lines · Jingoo Han
The driver core clears the driver data to NULL after
device_releaseor on probe failure. Thus, it is not needed to manually clear the device driver data to NULL.Signed-off-by Jingoo Han <[email protected]>
Acked-by Dmitry Torokhov <[email protected]>
Quoted 16 lines
--- drivers/net/vmxnet3/vmxnet3_drv.c | 1 - 1 file changed, 1 deletion(-)(quoted diff) +0
-0
b/drivers/net/vmxnet3/vmxnet3_drv.cindex 7e2788c..a300a18 100644drivers/net/vmxnet3/vmxnet3_drv.c +0
-1@@ -3132,7 +3132,6 @@ err_alloc_queue_desc: err_alloc_shared:dma_unmap_single (&adapter->pdev->dev, adapter->adapter_pa,sizeof (struct vmxnet3_adapter ),PCI_DMA_TODEVICE ); -pci_set_drvdata (pdev,NULL );free_netdev (netdev);return err; }