Skip to contentSkip to conversation

usb: dwc3: qcom: make dwc3_qcom_glue_ops static

PATCH In review Ben Dooks 2 participants 2 messages Jun 23

Subsystems (3)
lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/1 usb: dwc3: qcom: make dwc3_qcom_glue_ops static

The dwc3_qcom_glue_ops is not used outside of the file it is declared in , so make it static to avoid the following warning:

drivers/usb/dwc3/dwc3-qcom.c:605:22: warning: symbol 'dwc3_qcom_glue_ops' was not declared. Should it be static?

---
 drivers/usb/dwc3/dwc3-qcom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/dwc3/dwc3-qcom.c +1 -1
index f43f73ac36ff..ac68b4218b56 100644
@@ -602,7 +602,7 @@ static void dwc3_qcom_run_stop_notifier(struct dwc3 *dwc, bool is_on)
 	pm_runtime_mark_last_busy(qcom->dev);
 }
 
-struct dwc3_glue_ops dwc3_qcom_glue_ops = {
+static struct dwc3_glue_ops dwc3_qcom_glue_ops = {
 	.pre_set_role	= dwc3_qcom_set_role_notifier,
 	.pre_run_stop	= dwc3_qcom_run_stop_notifier,
 };
Signature · 1 line
2.37.2.352.g3c44437643
Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Ben Dooks

The dwc3_qcom_glue_ops is not used outside of the file it is declared in , so make it static to avoid the following warning:

Odd to begin a line with a comma>

Quoted 4 lines

drivers/usb/dwc3/dwc3-qcom.c:605:22: warning: symbol 'dwc3_qcom_glue_ops' was not declared. Should it be static?

---

for the change:

Konrad