Skip to contentSkip to conversation

mtd: spi-nor-ids: Add Winbond W25Q128JW ID

PATCH RESEND In review Marek Vasut 4 participants 6 messages Apr 24, 2022 – May 17, 2022 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 mtd: spi-nor-ids: Add Winbond W25Q128JW ID

Add ID for Winbond W25Q128JW device. This is a 128 Mbit QSPI NOR. Tested on W25Q128JWPIM part.

Cc Horatiu Vultur <[email protected]>
Cc Jagan Teki <[email protected]>
Cc Simon Goldschmidt <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Vignesh R <[email protected]>

---
NOTE: This has been incorrectly marked in PW as Changes Requested

---
 drivers/mtd/spi/spi-nor-ids.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/mtd/spi/spi-nor-ids.c +5 -0
index 763bab04c60..393a24b3162 100644
@@ -345,6 +345,11 @@ const struct flash_info spi_nor_ids[] = {
 			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
 			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
 	},
+	{
+		INFO("w25q128jw", 0xef8018, 0, 64 * 1024, 256,
+			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+	},
 	{
 		INFO("w25q256fw", 0xef6019, 0, 64 * 1024, 512,
 			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
Signature · 1 line
2.35.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Marek Vasut

Add ID for Winbond W25Q128JW device. This is a 128 Mbit QSPI NOR. Tested on W25Q128JWPIM part.

Cc Horatiu Vultur <[email protected]>
Cc Jagan Teki <[email protected]>
Cc Simon Goldschmidt <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Vignesh R <[email protected]>

Thanks,
Stefan

Quoted 12 lines

---
NOTE: This has been incorrectly marked in PW as Changes Requested

---
  drivers/mtd/spi/spi-nor-ids.c | 5 +++++
  1 file changed, 5 insertions(+)
drivers/mtd/spi/spi-nor-ids.c +0 -0
index 763bab04c60..393a24b3162 100644
@@ -345,6 +345,11 @@ const struct flash_info spi_nor_ids[] = {
  			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 355

Quoted 10 lines
drivers/mtd/spi/spi-nor-ids.c +5 -0
  			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
  	},
+	{
+		INFO("w25q128jw", 0xef8018, 0, 64 * 1024, 256,
+			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+	},
  	{
  		INFO("w25q256fw", 0xef6019, 0, 64 * 1024, 512,
  			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |

Viele Grüße,
Stefan Roese

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
#2 lore raw
Quoted 4 lines · Stefan Roese
Quoted 3 lines · Marek Vasut

Add ID for Winbond W25Q128JW device. This is a 128 Mbit QSPI NOR. Tested on W25Q128JWPIM part.

Quoted 8 lines
Quoted 6 lines
Cc Horatiu Vultur <[email protected]>
Cc Jagan Teki <[email protected]>
Cc Simon Goldschmidt <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Vignesh R <[email protected]>

Can this be applied soon ?

#3 lore raw
Quoted 12 lines · Marek Vasut
Quoted 11 lines · Stefan Roese
Quoted 9 lines · Marek Vasut

Add ID for Winbond W25Q128JW device. This is a 128 Mbit QSPI NOR. Tested on W25Q128JWPIM part.

Cc Horatiu Vultur <[email protected]>
Cc Jagan Teki <[email protected]>
Cc Simon Goldschmidt <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Vignesh R <[email protected]>
Quoted 3 lines
Quoted 1 line

Can this be applied soon ?

+CC Tom , can you pick this ?

#4 lore raw
In reply to Marek Vasut
Quoted 13 lines · Marek Vasut
Quoted 11 lines · Stefan Roese
Quoted 9 lines · Marek Vasut

Add ID for Winbond W25Q128JW device. This is a 128 Mbit QSPI NOR. Tested on W25Q128JWPIM part.

Cc Horatiu Vultur <[email protected]>
Cc Jagan Teki <[email protected]>
Cc Simon Goldschmidt <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Vignesh R <[email protected]>
Quoted 3 lines
Quoted 1 line

Can this be applied soon ?

This is already merged.

https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/

Reviewed-by on v1 1/1
#5 lore raw
In reply to Marek Vasut
Quoted 22 lines · Marek Vasut

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Add ID for Winbond W25Q128JW device. This is a 128 Mbit QSPI NOR. Tested on W25Q128JWPIM part.

Cc Horatiu Vultur <[email protected]>
Cc Jagan Teki <[email protected]>
Cc Simon Goldschmidt <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Vignesh R <[email protected]>

---
NOTE: This has been incorrectly marked in PW as Changes Requested

---
 drivers/mtd/spi/spi-nor-ids.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/mtd/spi/spi-nor-ids.c +0 -0
index 763bab04c60..393a24b3162 100644

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 349

Quoted 5 lines
drivers/mtd/spi/spi-nor-ids.c +2 -0
@@ -345,6 +345,11 @@ const struct flash_info spi_nor_ids[] = {
                        SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
                        SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
        },
+       {
+               INFO("w25q128jw", 0xef8018, 0, 64 * 1024, 256,

We can update the name later on if needed, so:

Quoted 9 lines
drivers/mtd/spi/spi-nor-ids.c +3 -1
+                       SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+                       SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+       },
        {
                INFO("w25q256fw", 0xef6019, 0, 64 * 1024, 512,
                        SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
--

2.35.1