igc: Remove unused phy_type enum
Subsystems (2)
PATCH v2 1/1 igc: Remove unused phy_type enum
Complete to commit 8e153faf5827 ("igc: Remove unused phy type") i225 parts have only one phy. There is no point to use phy_type enum. Clean up the code accordingly, and get rid of the unused enum lines.
Signed-off-by Sasha Neftin <[email protected]>
---
v2: ret_val isn't needed since it's always returning 0
drivers/net/ethernet/intel/igc/igc_base.c | 2 -- drivers/net/ethernet/intel/igc/igc_hw.h | 7 ------- drivers/net/ethernet/intel/igc/igc_phy.c | 12 +++--------- 3 files changed, 3 insertions(+), 18 deletions(-)
drivers/net/ethernet/intel/igc/igc_base.c +0 -2
@@ -182,8 +182,6 @@ static s32 igc_init_phy_params_base(struct igc_hw *hw)igc_check_for_copper_link (hw); - phy->type = igc_phy_i225; - out:return ret_val; }
drivers/net/ethernet/intel/igc/igc_hw.h +0 -7
@@ -53,11 +53,6 @@ enum igc_mac_type {igc_num_macs /* List is 1-based, so subtract 1 for true count. */ }; -enum igc_phy_type { - igc_phy_unknown =0 , - igc_phy_i225, -}; -enum igc_media_type { igc_media_type_unknown =0 , igc_media_type_copper =1 ,
@@ -138,8 +133,6 @@ struct igc_nvm_info {struct igc_phy_info {struct igc_phy_operations ops; -enum igc_phy_type type; -u32 addr;u32 id;u32 reset_delay_us;/* in usec */
drivers/net/ethernet/intel/igc/igc_phy.c +3 -9
@@ -148,17 +148,11 @@ void igc_power_down_phy_copper(struct igc_hw *hw)s32 igc_check_downshift (struct igc_hw *hw) {struct igc_phy_info *phy = &hw->phy; -s32 ret_val; -switch (phy->type) { -case igc_phy_i225: -default : -/* speed downshift not supported */ - phy->speed_downgraded = false; - ret_val =0 ; - } +/* speed downshift not supported */ + phy->speed_downgraded = false; -return ret_val; +return 0 ; }/**
Signature · 1 line
2.30.2
PATCH v2 1/1 igc: Remove unused phy_type enum
Quoted 11 lines · Sasha Neftin
Complete to commit
8e153faf5827("igc: Remove unused phy type") i225 parts have only one phy. There is no point to usephy_typeenum. Clean up the code accordingly, and get rid of the unused enum lines.Signed-off-by Sasha Neftin <[email protected]>---
v2:ret_valisn't needed since it's always returning 0drivers/net/ethernet/intel/igc/igc_base.c | 2 -- drivers/net/ethernet/intel/igc/igc_hw.h | 7 ------- drivers/net/ethernet/intel/igc/igc_phy.c | 12 +++--------- 3 files changed, 3 insertions(+), 18 deletions(-)
Tested-by Naama Meir <[email protected]>