overlayfs does not pin underlying layers
Hi,
I noticed that you can still unmount the lower/upper/work layers, even if they're currently part of an active overlay mount. This is the case even when files in the overlay mount are currently open. After unmounting, the usual effects of a lazy umount can be observed, like still active loop devices.
Is this intentional? From a quick look, for open files this might be a side effect of using open_with_fake_path, but just getting a reference to the paths in ovl_mount_dir and preventing unmounting for the duration of the overlay mount would cover that as well AFAICT.
Thanks,
Fabian
---< demo script >---
#!/bin/bash
set -euxo pipefail
tmpdir=$(mktemp -d)
trap "rm -rf $tmpdir" EXIT
mkdir ${tmpdir}/{lower,upper,work,mount}
# Create ext4 fs, mount as lower
dd if=/dev/zero of=${tmpdir}/fs.img bs=1M count=10 mkfs.ext4 -q ${tmpdir}/fs.img
mount ${tmpdir}/fs.img ${tmpdir}/lower
# Create a file
echo "This is in lower" > ${tmpdir}/lower/lowerfile
# Mount overlayfs
mount -t overlay overlay ${tmpdir}/mount -o lowerdir=${tmpdir}/lower,workdir=${tmpdir}/work,upperdir=${tmpdir}/upper
# Open the file and print its contentghzogo8ugz312 iutv123u1 exec 3<${tmpdir}/mount/lowerfile
cat <&3
# Umount the lower fs
umount ${tmpdir}/lower && echo "Lower successfully unmounted"
# Show that the overlay mount is still there
mountpoint -q ${tmpdir}/lower || echo "Lower is not mounted anymore" mountpoint -q ${tmpdir}/mount && echo "Overlay still mounted" cat ${tmpdir}/mount/lowerfile
# Clean up
exec 3<&-
umount ${tmpdir}/mount
Quoted 9 lines · Fabian Vogt
Hi,
I noticed that you can still unmount the lower/upper/work layers, even if they're currently part of an active overlay mount. This is the case even when files in the overlay mount are currently open. After unmounting, the usual effects of a lazy umount can be observed, like still active loop devices.
Is this intentional?
It's a known feature. Not sure how much thought was given to this, but nobody took notice up till now.
Do you have a good reason for wanting the underlying mounts pinned, or you are just surprised by this behavior? In the latter case we can just add a paragraph to the documentation and be done with it.
Thanks,
Miklos
Hi,
Am Dienstag, 3. Dezember 2019, 15:19:28 CET schrieb Miklos Szeredi:
Quoted 9 lines · Fabian Vogt
Quoted 8 lines
Hi,
I noticed that you can still unmount the lower/upper/work layers, even if they're currently part of an active overlay mount. This is the case even when files in the overlay mount are currently open. After unmounting, the usual effects of a lazy umount can be observed, like still active loop devices.
Quoted 8 lines
Quoted 1 line
Is this intentional?
It's a known feature. Not sure how much thought was given to this, but nobody took notice up till now.
Do you have a good reason for wanting the underlying mounts pinned, or you are just surprised by this behavior? In the latter case we can just add a paragraph to the documentation and be done with it.
Both. It's obviously very inconsistent that it's possible to unmount something which you still have unrestricted access to.
The specific issue we're facing here is system shutdown - if there's an active overlayfs mount, it's not guaranteed that the unmounts happen in the right order. Currently we work around that by adding the systemd specific "x-systemd.requires-mounts-for=foo-lower.mount" option in /etc/fstab. If for some reason the order is wrong, this behaviour of overlayfs might lead to the system shutting down without the actual unmount happening properly, as it's equivalent to "umount -l" on lower/upper FSs.
I'm not sure whether there's a scenario in which this could even lead to data loss if something relies on umount succeeding to mean that the attached device is unused.
Cheers,
Fabian
Quoted 2 lines
Thanks,
Miklos
Quoted 22 lines · Fabian Vogt
Hi,
Am Dienstag, 3. Dezember 2019, 15:19:28 CET schrieb Miklos Szeredi:
Quoted 9 lines · Fabian Vogt
Quoted 8 lines
Hi,
I noticed that you can still unmount the lower/upper/work layers, even if they're currently part of an active overlay mount. This is the case even when files in the overlay mount are currently open. After unmounting, the usual effects of a lazy umount can be observed, like still active loop devices.
Quoted 8 lines
Quoted 1 line
Is this intentional?
It's a known feature. Not sure how much thought was given to this, but nobody took notice up till now.
Do you have a good reason for wanting the underlying mounts pinned, or you are just surprised by this behavior? In the latter case we can just add a paragraph to the documentation and be done with it.
Quoted 6 lines
Both. It's obviously very inconsistent that it's possible to unmount something which you still have unrestricted access to.
The specific issue we're facing here is system shutdown - if there's an active overlayfs mount, it's not guaranteed that the unmounts happen in the right order.
What do you mean by "right" order? Please explain the problem. If overlay does not prevent mount of lower/upper then you can unmount lower/upper/overlay in any order as long as you unmount all of them. But you can also walk all mounts from /proc/mounts in reserve order. It should do the right thing w.r.t dependencies.
Quoted 5 lines
Currently we work around that by adding the systemd specific "x-systemd.requires-mounts-for=foo-lower.mount" option in
/etc/fstab. If for some reason the order is wrong, this behaviour of overlayfs might lead to the system shutting down without the actual unmount happening properly, as it's equivalent to "umount -l" on lower/upper FSs.
I don't know what the systemd shutdown procedure is.
Is it trying to unmount all the blockdev filesystems before shutdown? Is that the problem?
Quoted 4 lines
I'm not sure whether there's a scenario in which this could even lead to data loss if something relies on umount succeeding to mean that the attached device is unused.
Basically, you cannot know that there is no other mount of that specific blockdev,
maybe in another mount namespace, when you unmount a specific mount point. In any case, with modern journalled blockdev filesystem, shutdown without clean unmount should not result in data loss (of fsynced data).
Thanks,
Amir.
Quoted 25 lines · Fabian Vogt
Hi,
Am Dienstag, 3. Dezember 2019, 15:19:28 CET schrieb Miklos Szeredi:
Quoted 9 lines · Fabian Vogt
Quoted 8 lines
Hi,
I noticed that you can still unmount the lower/upper/work layers, even if they're currently part of an active overlay mount. This is the case even when files in the overlay mount are currently open. After unmounting, the usual effects of a lazy umount can be observed, like still active loop devices.
Quoted 8 lines
Quoted 1 line
Is this intentional?
It's a known feature. Not sure how much thought was given to this, but nobody took notice up till now.
Do you have a good reason for wanting the underlying mounts pinned, or you are just surprised by this behavior? In the latter case we can just add a paragraph to the documentation and be done with it.
Both. It's obviously very inconsistent that it's possible to unmount something which you still have unrestricted access to.
Quoted 10 lines
The specific issue we're facing here is system shutdown - if there's an active overlayfs mount, it's not guaranteed that the unmounts happen in the right order. Currently we work around that by adding the systemd specific "x-systemd.requires-mounts-for=foo-lower.mount" option in
/etc/fstab. If for some reason the order is wrong, this behaviour of overlayfs might lead to the system shutting down without the actual unmount happening properly, as it's equivalent to "umount -l" on lower/upper FSs.
I'm not sure whether there's a scenario in which this could even lead to data loss if something relies on umount succeeding to mean that the attached device is unused.
IDGI: what is the right order? Why would it lead to corruption if the shutdown of the underlying fs is delayed until the shutdown of overlayfs?
Thanks,
Miklos