Skip to contentSkip to conversation

support/testing: update to the new text representation of capabilities

PATCH New Romain Naour 2 participants 3 messages Nov 10, 2020 – Nov 11, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 support/testing: update to the new text representation of capabilities

Since libcap 2.41, the text representation of capabilities now use the '=' instead of '+' [1].

This break our capabilities tests since we still use the old representation.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/morgan/libcap.git/commit/?id=177cd418031b1acfcf73fe3b1af9f3279828681c

---
 support/testing/tests/core/test_file_capabilities.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
support/testing/tests/core/test_file_capabilities.py +1 -1
index 945b48a4c3..b9ece18d7b 100644
@@ -44,4 +44,4 @@ class TestFileCapabilities(infra.basetest.BRTest):
         self.assertIn("cap_kill", output[0])
         self.assertIn("cap_sys_nice", output[0])
         self.assertIn("cap_sys_time", output[0])
-        self.assertIn("+eip", output[0])
+        self.assertIn("=eip", output[0])
Signature · 1 line
2.25.4
#1 lore raw

PATCH 1/1 support/testing: update to the new text representation of capabilities

Le 10/11/2020 ? 23:29, Romain Naour a ?crit?:

Quoted 7 lines

Since libcap 2.41, the text representation of capabilities now use the '=' instead of '+' [1].

This break our capabilities tests since we still use the old representation.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/morgan/libcap.git/commit/?id=177cd418031b1acfcf73fe3b1af9f3279828681c

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/830981737

Quoted 17 lines
---
 support/testing/tests/core/test_file_capabilities.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
support/testing/tests/core/test_file_capabilities.py +1 -1
index 945b48a4c3..b9ece18d7b 100644
@@ -44,4 +44,4 @@ class TestFileCapabilities(infra.basetest.BRTest):
         self.assertIn("cap_kill", output[0])
         self.assertIn("cap_sys_nice", output[0])
         self.assertIn("cap_sys_time", output[0])
-        self.assertIn("+eip", output[0])
+        self.assertIn("=eip", output[0])
#2 lore raw

PATCH 1/1 support/testing: update to the new text representation of capabilities

In reply to Romain Naour
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Romain" == Romain Naour <[email protected]> writes:

Since libcap 2.41, the text representation of capabilities now use the '=' instead of '+' [1].

This break our capabilities tests since we still use the old representation.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/morgan/libcap.git/commit/?id=177cd418031b1acfcf73fe3b1af9f3279828681c

Committed after adding the fixes line, thanks.

Signature · 1 line
Bye, Peter Korsgaard