arch/sh: Drop CONFIG_FIRMWARE_EDID from defconfig files
PATCH 1/1 arch/sh: Drop CONFIG_FIRMWARE_EDID from defconfig files
CONFIG_FIRMWARE_EDID=y depends on X86 or EFI_GENERIC_STUB. Neither is true here, so drop the lines from the defconfig files.
--- arch/sh/configs/dreamcast_defconfig | 1 - arch/sh/configs/hp6xx_defconfig | 1 - arch/sh/configs/se7343_defconfig | 1 - arch/sh/configs/se7780_defconfig | 1 - 4 files changed, 4 deletions(-)
arch/sh/configs/dreamcast_defconfig +0 -1
@@ -50,7 +50,6 @@ CONFIG_HW_RANDOM=y CONFIG_WATCHDOG=y CONFIG_SH_WDT=y CONFIG_FB=y -CONFIG_FIRMWARE_EDID=y CONFIG_FB_PVR2=y CONFIG_FRAMEBUFFER_CONSOLE=y CONFIG_FONTS=y
arch/sh/configs/hp6xx_defconfig +0 -1
@@ -35,7 +35,6 @@ CONFIG_SERIAL_SH_SCI_CONSOLE=y CONFIG_LEGACY_PTY_COUNT=64 # CONFIG_HWMON is not set CONFIG_FB=y -CONFIG_FIRMWARE_EDID=y CONFIG_FB_HIT=y CONFIG_FB_SH_MOBILE_LCDC=y CONFIG_FRAMEBUFFER_CONSOLE=y
arch/sh/configs/se7343_defconfig +0 -1
@@ -57,7 +57,6 @@ CONFIG_I2C=y CONFIG_I2C_SH_MOBILE=y # CONFIG_HWMON is not set CONFIG_FB=y -CONFIG_FIRMWARE_EDID=y CONFIG_FB_SH_MOBILE_LCDC=m CONFIG_SOUND=y CONFIG_SND=y
arch/sh/configs/se7780_defconfig +0 -1
@@ -60,7 +60,6 @@ CONFIG_SERIAL_SH_SCI_CONSOLE=y # CONFIG_HW_RANDOM is not set CONFIG_THERMAL=y CONFIG_FB=y -CONFIG_FIRMWARE_EDID=y CONFIG_FB_SH_MOBILE_LCDC=m CONFIG_FRAMEBUFFER_CONSOLE=y CONFIG_LOGO=y
Signature · 1 line
2.53.0
John Paul Adrian Glaubitz
maintainerHi Thomas,
Quoted 52 lines · Thomas Zimmermann
CONFIG_FIRMWARE_EDID=ydepends on X86 orEFI_GENERIC_STUB. Neither is true here, so drop the lines from the defconfig files.Signed-off-by Thomas Zimmermann <[email protected]>--- arch/sh/configs/dreamcast_defconfig | 1 - arch/sh/configs/hp6xx_defconfig | 1 - arch/sh/configs/se7343_defconfig | 1 - arch/sh/configs/se7780_defconfig | 1 - 4 files changed, 4 deletions(-)arch/sh/configs/dreamcast_defconfig +0
-1@@ -50,7 +50,6 @@ CONFIG_HW_RANDOM=y CONFIG_WATCHDOG=y CONFIG_SH_WDT=y CONFIG_FB=y -CONFIG_FIRMWARE_EDID=y CONFIG_FB_PVR2=y CONFIG_FRAMEBUFFER_CONSOLE=y CONFIG_FONTS=yarch/sh/configs/hp6xx_defconfig +0
-1@@ -35,7 +35,6 @@ CONFIG_SERIAL_SH_SCI_CONSOLE=y CONFIG_LEGACY_PTY_COUNT=64 # CONFIG_HWMON is not set CONFIG_FB=y -CONFIG_FIRMWARE_EDID=y CONFIG_FB_HIT=y CONFIG_FB_SH_MOBILE_LCDC=y CONFIG_FRAMEBUFFER_CONSOLE=yarch/sh/configs/se7343_defconfig +0
-1@@ -57,7 +57,6 @@ CONFIG_I2C=y CONFIG_I2C_SH_MOBILE=y # CONFIG_HWMON is not set CONFIG_FB=y -CONFIG_FIRMWARE_EDID=y CONFIG_FB_SH_MOBILE_LCDC=m CONFIG_SOUND=y CONFIG_SND=yarch/sh/configs/se7780_defconfig +0
-0
arch/sh/configs/se7780_defconfig CONFIG_SERIAL_SH_SCI_CONSOLE=y · line 65
Quoted 7 lines
arch/sh/configs/se7780_defconfig +0
-1@@ -60,7 +60,6 @@ CONFIG_SERIAL_SH_SCI_CONSOLE=y # CONFIG_HW_RANDOM is not set CONFIG_THERMAL=y CONFIG_FB=y -CONFIG_FIRMWARE_EDID=y CONFIG_FB_SH_MOBILE_LCDC=m CONFIG_FRAMEBUFFER_CONSOLE=y CONFIG_LOGO=y
Thanks for catching this! I wonder where this configuration entry comes from though.
My SH7785LCR board does have a DVI output as well as a Silicon Motion SM-501 video chip though, so I think it should be able to perform EDID in general. Or is the protocol actually tied to the x86 architecture? What about monitors on a PowerPC workstation, for example? Does EDID not work there at all?
Thanks,
Adrian
Signature · 4 lines
.''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Hi
Am 01.04.26 um 10:46 schrieb John Paul Adrian Glaubitz:
Quoted 64 lines
Hi Thomas,
Quoted 52 lines · Thomas Zimmermann
CONFIG_FIRMWARE_EDID=ydepends on X86 orEFI_GENERIC_STUB. Neither is true here, so drop the lines from the defconfig files.Signed-off-by Thomas Zimmermann <[email protected]>--- arch/sh/configs/dreamcast_defconfig | 1 - arch/sh/configs/hp6xx_defconfig | 1 - arch/sh/configs/se7343_defconfig | 1 - arch/sh/configs/se7780_defconfig | 1 - 4 files changed, 4 deletions(-)arch/sh/configs/dreamcast_defconfig +0
-1@@ -50,7 +50,6 @@ CONFIG_HW_RANDOM=y CONFIG_WATCHDOG=y CONFIG_SH_WDT=y CONFIG_FB=y -CONFIG_FIRMWARE_EDID=y CONFIG_FB_PVR2=y CONFIG_FRAMEBUFFER_CONSOLE=y CONFIG_FONTS=yarch/sh/configs/hp6xx_defconfig +0
-1@@ -35,7 +35,6 @@ CONFIG_SERIAL_SH_SCI_CONSOLE=y CONFIG_LEGACY_PTY_COUNT=64 # CONFIG_HWMON is not set CONFIG_FB=y -CONFIG_FIRMWARE_EDID=y CONFIG_FB_HIT=y CONFIG_FB_SH_MOBILE_LCDC=y CONFIG_FRAMEBUFFER_CONSOLE=yarch/sh/configs/se7343_defconfig +0
-1@@ -57,7 +57,6 @@ CONFIG_I2C=y CONFIG_I2C_SH_MOBILE=y # CONFIG_HWMON is not set CONFIG_FB=y -CONFIG_FIRMWARE_EDID=y CONFIG_FB_SH_MOBILE_LCDC=m CONFIG_SOUND=y CONFIG_SND=yarch/sh/configs/se7780_defconfig +0
-0arch/sh/configs/se7780_defconfig CONFIG_SERIAL_SH_SCI_CONSOLE=y · line 65
Quoted 7 lines
arch/sh/configs/se7780_defconfig +0
-1@@ -60,7 +60,6 @@ CONFIG_SERIAL_SH_SCI_CONSOLE=y # CONFIG_HW_RANDOM is not set CONFIG_THERMAL=y CONFIG_FB=y -CONFIG_FIRMWARE_EDID=y CONFIG_FB_SH_MOBILE_LCDC=m CONFIG_FRAMEBUFFER_CONSOLE=y CONFIG_LOGO=yThanks for catching this! I wonder where this configuration entry comes from though.
Quoted 4 lines
My SH7785LCR board does have a DVI output as well as a Silicon Motion SM-501 video chip though, so I think it should be able to perform EDID in general. Or is the protocol actually tied to the x86 architecture? What about monitors on a PowerPC workstation, for example? Does EDID not work there at all?
Yes, your system can fetch the EDID via the Linux driver. But FIRMWARE_EDID is a special feature where the EDID gets delivered by the boot loader. This has always only been possible on x86 or with EFI.
Best regards
Thomas
Quoted 4 lines
Thanks,
Adrian
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
Quoted 9 lines · Thomas Zimmermann
Am 01.04.26 um 10:46 schrieb John Paul Adrian Glaubitz:
Quoted 4 lines
My SH7785LCR board does have a DVI output as well as a Silicon Motion SM-501 video chip though, so I think it should be able to perform EDID in general. Or is the protocol actually tied to the x86 architecture? What about monitors on a PowerPC workstation, for example? Does EDID not work there at all?
Yes, your system can fetch the EDID via the Linux driver. But
FIRMWARE_EDIDis a special feature where the EDID gets delivered by the boot loader. This has always only been possible on x86 or with EFI.
And then there's the completely separate CONFIG_DRM_LOAD_EDID_FIRMWARE config to allow loading the EDID through the kernel firmware loader. Not confusing or misleading at all. ;D
BR,
Jani.
Signature · 1 line
Jani Nikula, Intel
John Paul Adrian Glaubitz
maintainerHi Thomas,
Quoted 67 lines · Thomas Zimmermann
Hi
Am 01.04.26 um 10:46 schrieb John Paul Adrian Glaubitz:
Quoted 64 lines
Hi Thomas,
Quoted 52 lines · Thomas Zimmermann
CONFIG_FIRMWARE_EDID=ydepends on X86 orEFI_GENERIC_STUB. Neither is true here, so drop the lines from the defconfig files.Signed-off-by Thomas Zimmermann <[email protected]>--- arch/sh/configs/dreamcast_defconfig | 1 - arch/sh/configs/hp6xx_defconfig | 1 - arch/sh/configs/se7343_defconfig | 1 - arch/sh/configs/se7780_defconfig | 1 - 4 files changed, 4 deletions(-)arch/sh/configs/dreamcast_defconfig +0
-1@@ -50,7 +50,6 @@ CONFIG_HW_RANDOM=y CONFIG_WATCHDOG=y CONFIG_SH_WDT=y CONFIG_FB=y -CONFIG_FIRMWARE_EDID=y CONFIG_FB_PVR2=y CONFIG_FRAMEBUFFER_CONSOLE=y CONFIG_FONTS=yarch/sh/configs/hp6xx_defconfig +0
-1@@ -35,7 +35,6 @@ CONFIG_SERIAL_SH_SCI_CONSOLE=y CONFIG_LEGACY_PTY_COUNT=64 # CONFIG_HWMON is not set CONFIG_FB=y -CONFIG_FIRMWARE_EDID=y CONFIG_FB_HIT=y CONFIG_FB_SH_MOBILE_LCDC=y CONFIG_FRAMEBUFFER_CONSOLE=yarch/sh/configs/se7343_defconfig +0
-1@@ -57,7 +57,6 @@ CONFIG_I2C=y CONFIG_I2C_SH_MOBILE=y # CONFIG_HWMON is not set CONFIG_FB=y -CONFIG_FIRMWARE_EDID=y CONFIG_FB_SH_MOBILE_LCDC=m CONFIG_SOUND=y CONFIG_SND=yarch/sh/configs/se7780_defconfig +0
-0arch/sh/configs/se7780_defconfig CONFIG_SERIAL_SH_SCI_CONSOLE=y · line 65
Quoted 7 lines
arch/sh/configs/se7780_defconfig +0
-1@@ -60,7 +60,6 @@ CONFIG_SERIAL_SH_SCI_CONSOLE=y # CONFIG_HW_RANDOM is not set CONFIG_THERMAL=y CONFIG_FB=y -CONFIG_FIRMWARE_EDID=y CONFIG_FB_SH_MOBILE_LCDC=m CONFIG_FRAMEBUFFER_CONSOLE=y CONFIG_LOGO=yThanks for catching this! I wonder where this configuration entry comes from though.
Quoted 8 lines
Quoted 4 lines
My SH7785LCR board does have a DVI output as well as a Silicon Motion SM-501 video chip though, so I think it should be able to perform EDID in general. Or is the protocol actually tied to the x86 architecture? What about monitors on a PowerPC workstation, for example? Does EDID not work there at all?
Yes, your system can fetch the EDID via the Linux driver. But
FIRMWARE_EDIDis a special feature where the EDID gets delivered by the boot loader. This has always only been possible on x86 or with EFI.
Ah, thanks. I wasn't aware of that feature. Let me add my RB then.
I'll try to merge some patches this week.
Adrian
Signature · 4 lines
.''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Hi Thomas,
CC arm/mips/ppc, as you sent similar patches for these arches.
Quoted 4 lines · Thomas Zimmermann
CONFIG_FIRMWARE_EDID=ydepends on X86 orEFI_GENERIC_STUB. Neither is true here, so drop the lines from the defconfig files.Signed-off-by Thomas Zimmermann <[email protected]>
Thanks for your patch!
Upon first look, your changes match the (current) dependencies of FIRMWARE_EDID. The dependency on X86 was added in commit 7e35fc7ab433683f ("video: Make CONFIG_FIRMWARE_EDID generally available") in v6.17-rc1.
However, CONFIG_FIRMWARE_EDID also protects fb_firmware_edid(), which seems to extract the EDID from the PCI ROM, and is thus not x86-specific? That function is only ever called by three fbdev drivers (i810, nv, savagefb), though.
I assume none of these work on SuperH, so
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert
Am 01.04.26 um 10:55 schrieb Geert Uytterhoeven:
Quoted 9 lines
Hi Thomas,
CC arm/mips/ppc, as you sent similar patches for these arches.
Quoted 4 lines · Thomas Zimmermann
CONFIG_FIRMWARE_EDID=ydepends on X86 orEFI_GENERIC_STUB. Neither is true here, so drop the lines from the defconfig files.Signed-off-by Thomas Zimmermann <[email protected]>
Quoted 8 lines
Thanks for your patch!
Upon first look, your changes match the (current) dependencies of
FIRMWARE_EDID. The dependency on X86 was added in commit7e35fc7ab433683f("video: MakeCONFIG_FIRMWARE_EDIDgenerally available") in v6.17-rc1.
However,CONFIG_FIRMWARE_EDIDalso protectsfb_firmware_edid(), which seems to extract the EDID from the PCI ROM, and is thus not
The PCI code in the function tests whether the BIOS ROM has been shadowed into system memory. That's a common way of testing if the PCI device is the primary graphics card. The provided EDID is only for the primary device.
The test shouldn't actually be there any more. We now have video_is_primary_device() for this.
Quoted 2 lines
x86-specific? That function is only ever called by three fbdev drivers (i810, nv, savagefb), though.
I know. But IDK why it hasn't been more prominently featured in fbdev. Nowadays, we use the firmware EDID with DRM's generic drivers on any hardware.
Quoted 3 lines
I assume none of these work on SuperH, so
Reviewed-by Geert Uytterhoeven <[email protected]>
Thanks
Best regards
Thomas
Quoted 5 lines
Gr{oetje,eeting}s,
Geert
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
Quoted 52 lines · Thomas Zimmermann
CONFIG_FIRMWARE_EDID=ydepends on X86 orEFI_GENERIC_STUB. Neither is true here, so drop the lines from the defconfig files.Signed-off-by Thomas Zimmermann <[email protected]>--- arch/sh/configs/dreamcast_defconfig | 1 - arch/sh/configs/hp6xx_defconfig | 1 - arch/sh/configs/se7343_defconfig | 1 - arch/sh/configs/se7780_defconfig | 1 - 4 files changed, 4 deletions(-)arch/sh/configs/dreamcast_defconfig +0
-1@@ -50,7 +50,6 @@ CONFIG_HW_RANDOM=y CONFIG_WATCHDOG=y CONFIG_SH_WDT=y CONFIG_FB=y -CONFIG_FIRMWARE_EDID=y CONFIG_FB_PVR2=y CONFIG_FRAMEBUFFER_CONSOLE=y CONFIG_FONTS=yarch/sh/configs/hp6xx_defconfig +0
-1@@ -35,7 +35,6 @@ CONFIG_SERIAL_SH_SCI_CONSOLE=y CONFIG_LEGACY_PTY_COUNT=64 # CONFIG_HWMON is not set CONFIG_FB=y -CONFIG_FIRMWARE_EDID=y CONFIG_FB_HIT=y CONFIG_FB_SH_MOBILE_LCDC=y CONFIG_FRAMEBUFFER_CONSOLE=yarch/sh/configs/se7343_defconfig +0
-1@@ -57,7 +57,6 @@ CONFIG_I2C=y CONFIG_I2C_SH_MOBILE=y # CONFIG_HWMON is not set CONFIG_FB=y -CONFIG_FIRMWARE_EDID=y CONFIG_FB_SH_MOBILE_LCDC=m CONFIG_SOUND=y CONFIG_SND=yarch/sh/configs/se7780_defconfig +0
-0
arch/sh/configs/se7780_defconfig CONFIG_SERIAL_SH_SCI_CONSOLE=y · line 65
Quoted 7 lines
arch/sh/configs/se7780_defconfig +0
-1@@ -60,7 +60,6 @@ CONFIG_SERIAL_SH_SCI_CONSOLE=y # CONFIG_HW_RANDOM is not set CONFIG_THERMAL=y CONFIG_FB=y -CONFIG_FIRMWARE_EDID=y CONFIG_FB_SH_MOBILE_LCDC=m CONFIG_FRAMEBUFFER_CONSOLE=y CONFIG_LOGO=y
Looks good to me.
Adrian
Signature · 4 lines
.''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913