Skip to contentSkip to conversation

: bitops not 64bit clean

ALSA - tools 0001343 [email protected] 1 participant 1 message Aug 16, 2005

lore
Share & tools
lore
#0 lore raw

A NOTE has been added to this issue.
======================================================================
<https://bugtrack.alsa-project.org/alsa-bug/view.php?id=1343>
======================================================================
Reported By: jdthood
Assigned To:
======================================================================

Project:                    ALSA - tools
Issue ID:                   1343
Category:                   ld10k1
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
======================================================================
Date Submitted:             08-16-2005 20:49 CEST
Last Modified:              08-16-2005 21:13 CEST

======================================================================
Summary: bitops not 64bit clean
Description:
Quoting Debian bug report #323331:

Package: ld10k1
Version: 1.0.9-1

On all 64bit systems (the easiest example is amd64) ld10k1 crashes on use by lo10k1, some debugging tracked down the problem fairly quickly.

The bitops functions (set_bit and associated) that ld10k1 use come from the linux kernel, and assume that longs are 32bit only, causing a buffer overflow of the bit buffer.

The attached patch fixes the bitops to be independent of the size of longs, and is confirmed to fix the bug on my box.

Zephaniah E. Hull.

diff -ur alsa-tools-1.0.9/ld10k1/src/bitops.h alsa-tools-1.0.9.mine/ld10k1/src/bitops.h
--- alsa-tools-1.0.9/ld10k1/src/bitops.h 2005-03-18 08:41:02.000000000
-0500
+++ alsa-tools-1.0.9.mine/ld10k1/src/bitops.h 2005-08-15
23:24:46.000000000 -0400
@@ -15,13 +15,17 @@
*
* C language equivalents written by Theodore Ts'o, 9/26/92 */
+/*
+ * Converted to be independent of the size of longs.
+ * Zephaniah E. Hull 2005-08-15.
+ */

__inline__ int set_bit(int nr, unsigned long * addr) {
int mask, retval;

- addr += nr >> 5;
- mask = 1 << (nr & 0x1f);
+ addr += nr >> (sizeof(long) + 1);
+ mask = 1 << (nr & (sizeof(long) * 8 - 1));
retval = (mask & *addr) != 0;
*addr |= mask;
return retval;
@@ -31,8 +35,8 @@
{
int mask, retval;

- addr += nr >> 5;
- mask = 1 << (nr & 0x1f);
+ addr += nr >> (sizeof(long) + 1);
+ mask = 1 << (nr & (sizeof(long) * 8 - 1));
retval = (mask & *addr) != 0;
*addr &= ~mask;
return retval;
@@ -42,8 +46,8 @@
{
int mask;

- addr += nr >> 5;
- mask = 1 << (nr & 0x1f);
+ addr += nr >> (sizeof(long) + 1);
+ mask = 1 << (nr & (sizeof(long) * 8 - 1));
return ((mask & *addr) != 0);
}

======================================================================

----------------------------------------------------------------------
rlrevell - 08-16-05 20:52
----------------------------------------------------------------------
Um, what are those being used for? I don't think the emu10k1 has any 64 bit registers so why on earth would you need to set a bit in a 64 bit variable? Are you sure they are not supposed to be u32?

----------------------------------------------------------------------
pzad - 08-16-05 21:13
----------------------------------------------------------------------
This is used to set used (valid) GPRs, TRAM, code maps in CODE_POKE ioctl.

Issue History
Date Modified Username Field Change
======================================================================

08-16-05 20:49 jdthood        New Issue                                    
08-16-05 20:52 rlrevell       Note Added: 0005832                          
08-16-05 21:13 pzad           Note Added: 0005833                          

======================================================================

-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf