Skip to contentSkip to conversation

cxl/region: Only warn about cpu_cache_invalidate_memregion() once

PATCH In review Davidlohr Bueso 4 participants 4 messages Dec 15, 2022 – Dec 16, 2022 CXL

lore
Share & tools
lore

Davidlohr Bueso

author maintainer
#0 lore raw

PATCH v2 1/1 cxl/region: Only warn about cpu_cache_invalidate_memregion() once

No need for more than once per region.

---
 drivers/cxl/core/region.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cxl/core/region.c +1 -1
index 02f28da519e3..c11a6ab5e48d 100644
@@ -1967,7 +1967,7 @@ static int cxl_region_invalidate_memregion(struct cxl_region *cxlr)
 
 	if (!cpu_cache_has_invalidate_memregion()) {
 		if (IS_ENABLED(CONFIG_CXL_REGION_INVALIDATION_TEST)) {
-			dev_warn(
+			dev_warn_once(
 				&cxlr->dev,
 				"Bypassing cpu_cache_invalidate_memregion() for testing!\n");
 			clear_bit(CXL_REGION_F_INCOHERENT, &cxlr->flags);
Signature · 1 line
2.38.1
maintainer Reviewed-by on v2 1/1
#1 lore raw
Quoted 3 lines · Davidlohr Bueso

No need for more than once per region.

Quoted 17 lines
---
  drivers/cxl/core/region.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cxl/core/region.c +1 -1
index 02f28da519e3..c11a6ab5e48d 100644
@@ -1967,7 +1967,7 @@ static int cxl_region_invalidate_memregion(struct cxl_region *cxlr)
 
  	if (!cpu_cache_has_invalidate_memregion()) {
  		if (IS_ENABLED(CONFIG_CXL_REGION_INVALIDATION_TEST)) {
-			dev_warn(
+			dev_warn_once(
  				&cxlr->dev,
  				"Bypassing cpu_cache_invalidate_memregion() for testing!\n");
  			clear_bit(CXL_REGION_F_INCOHERENT, &cxlr->flags);
Reviewed-by on v2 1/1
#2 lore raw
In reply to Davidlohr Bueso
Quoted 12 lines · On Thu, 15 Dec 2022 10:38:36 -0800 Davidlohr Bueso <[email protected]> wrote:

No need for more than once per region.

---
 drivers/cxl/core/region.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cxl/core/region.c +0 -0
index 02f28da519e3..c11a6ab5e48d 100644

drivers/cxl/core/region.c static int cxl_region_invalidate_memregion(struct cxl_region *cxlr) · line 1973

Quoted 8 lines
drivers/cxl/core/region.c +1 -1
@@ -1967,7 +1967,7 @@ static int cxl_region_invalidate_memregion(struct cxl_region *cxlr)
 
 	if (!cpu_cache_has_invalidate_memregion()) {
 		if (IS_ENABLED(CONFIG_CXL_REGION_INVALIDATION_TEST)) {
-			dev_warn(
+			dev_warn_once(
 				&cxlr->dev,
 				"Bypassing cpu_cache_invalidate_memregion() for testing!\n");
 			clear_bit(CXL_REGION_F_INCOHERENT, &cxlr->flags);

Seems sensible.