ata: ahci: Use correct DMI identifier for ASUSPRO-D840SA LPM quirk
Subsystems (2)
Niklas Cassel
maintainerPATCH v2 1/1 ata: ahci: Use correct DMI identifier for ASUSPRO-D840SA LPM quirk
ASUS store the board name in DMI_PRODUCT_NAME rather than DMI_PRODUCT_VERSION. (Apparently it is only Lenovo that stores the model-name in DMI_PRODUCT_VERSION.)
Use the correct DMI identifier, DMI_PRODUCT_NAME, to match the ASUSPRO-D840SA board, such that the quirk actually gets applied.
---
Changes since v1:
-Improved commit log
-Picked up tag from Hans
drivers/ata/ahci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/ahci.c +1 -1
@@ -1450,7 +1450,7 @@ static bool ahci_broken_lpm(struct pci_dev *pdev) { .matches = { DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), - DMI_MATCH(DMI_PRODUCT_VERSION, "ASUSPRO D840MB_M840SA"), + DMI_MATCH(DMI_PRODUCT_NAME, "ASUSPRO D840MB_M840SA"), }, /* 320 is broken, there is no known good version. */ },
Signature · 1 line
2.49.0
Quoted 7 lines · Niklas Cassel
ASUS store the board name in
DMI_PRODUCT_NAMErather thanDMI_PRODUCT_VERSION. (Apparently it is only Lenovo that stores the model-name inDMI_PRODUCT_VERSION.)Use the correct DMI identifier,
DMI_PRODUCT_NAME, to match the ASUSPRO-D840SA board, such that the quirk actually gets applied.
Quoted 6 lines
Reported-by Andy Yang <[email protected]>Fixes b5acc3628898 ("ata: ahci: Disallow LPM for ASUSPRO-D840SA motherboard")Reviewed-by Hans de Goede <[email protected]>Signed-off-by Niklas Cassel <[email protected]>
Signature · 2 lines
Damien Le Moal Western Digital Research
A message that is not in the archive (sent off-list or not yet received): CAGEiHrCWnC9BDi3DFDiAnoJxB_pFJpv-vcRU9jTmwb3Pxsg_Hw@mail.gmail.com
Niklas Cassel
maintainerQuoted 20 lines · Andy Yang
Quoted 5 lines · Damien Le Moal
Quoted 4 lines · Niklas Cassel
ASUS store the board name in
DMI_PRODUCT_NAMErather thanDMI_PRODUCT_VERSION. (Apparently it is only Lenovo that stores the model-name inDMI_PRODUCT_VERSION.)Quoted 7 lines
Quoted 7 lines
Use the correct DMI identifier,
DMI_PRODUCT_NAME, to match the ASUSPRO-D840SA board, such that the quirk actually gets applied.Reported-by Andy Yang <[email protected]>Fixes b5acc3628898 ("ata: ahci: Disallow LPM for ASUSPRO-D840SAmotherboard")
Quoted 6 lines
Quoted 2 lines
Reviewed-by Hans de Goede <[email protected]>Signed-off-by Niklas Cassel <[email protected]>Reviewed-by Damien Le Moal <[email protected]>
Quoted 6 lines
Quoted 4 lines
--
Damien Le Moal
Western Digital ResearchLGTM. This patch is tested work correctly.
Thank you, I will add your Tested-by tag.
Quoted 4 lines
Again, not sure if its model specific or motherboard specific, if its consider motherboard specific we should use (
DMI_BOARD_NAME, D840MB) instead to match the board.
I don't know if it is model specific or motherboard specific.
Considering how bad this bug is (causing artifacts on the iGPU), I guess we should hope that it is only the BIOS for your system, and not for all D840MB boards.
So personally, I would go with the narrowest possible match (which this patch currently does).
But, I would not be surprised if they actually managed to mess this up for all boards. But until someone else reports the same problem, I guess we should give them the benefit of the doubt.
Kind regards,
Niklas
Quoted 8 lines · Niklas Cassel
ASUS store the board name in
DMI_PRODUCT_NAMErather thanDMI_PRODUCT_VERSION. (Apparently it is only Lenovo that stores the model-name inDMI_PRODUCT_VERSION.)Use the correct DMI identifier,
DMI_PRODUCT_NAME, to match the ASUSPRO-D840SA board, such that the quirk actually gets applied.[...]
Applied to libata/linux.git (for-6.16-fixes), thanks!
[1/1] ata: ahci: Use correct DMI identifier for ASUSPRO-D840SA LPM quirk
https://git.kernel.org/libata/linux/c/3e0809b1
Kind regards,
Niklas
A message that is not in the archive (sent off-list or not yet received): CAGEiHrDtfwKGN+veFjgODf_0W4yJfDP0f6kqp-dF9xsypoH_0A@mail.gmail.com
Niklas Cassel
maintainerHello Andy,
Quoted 3 lines · Andy Yang
Thank you once again for your efforts on this patch. I also want to sincerely apologize for any inconvenience caused by the email reply incident.
Don't even think about it :)
We might have been able to avoid this extra fix,
but that's it. No biggie regardless.
Thank you for your help debugging this.
Kind regards,
Niklas