ata: pata_atiixp: make static read-only arrays const
Subsystems (2)
PATCH 1/1 ata: pata_atiixp: make static read-only arrays const
The static arrays pio_timings and mwdma_timings are read-only so it make sense to make them const.
Signed-off-by Colin Ian King <[email protected]>
--- drivers/ata/pata_atiixp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/ata/pata_atiixp.c +2 -2
@@ -102,7 +102,7 @@ static int atiixp_prereset(struct ata_link *link, unsigned long deadline)static void atiixp_set_pio_timing (struct ata_port *ap,struct ata_device *adev,int pio) { -static u8 pio_timings[5 ] = {0x5D ,0x47 ,0x34 ,0x22 ,0x20 }; +static const u8 pio_timings[5 ] = {0x5D ,0x47 ,0x34 ,0x22 ,0x20 };struct pci_dev *pdev =to_pci_dev (ap->host->dev);int dn =2 * ap->port_no + adev->devno;
@@ -149,7 +149,7 @@ static void atiixp_set_piomode(struct ata_port *ap, struct ata_device *adev)static void atiixp_set_dmamode (struct ata_port *ap,struct ata_device *adev) { -static u8 mwdma_timings[5 ] = {0x77 ,0x21 ,0x20 }; +static const u8 mwdma_timings[5 ] = {0x77 ,0x21 ,0x20 };struct pci_dev *pdev =to_pci_dev (ap->host->dev);int dma = adev->dma_mode;
Signature · 1 line
2.33.1
Quoted 4 lines · Colin Ian King
The static arrays
pio_timingsandmwdma_timingsare read-only so it make sense to make them const.Signed-off-by Colin Ian King <[email protected]>
Reviewed-by Sergey Shtylyov <[email protected]>
[...]
MBR, Sergey
Damien Le Moal
AppliedQuoted 4 lines · Colin Ian King
The static arrays
pio_timingsandmwdma_timingsare read-only so it make sense to make them const.Signed-off-by Colin Ian King <[email protected]>
Applied to for-5.18. Thanks !
Signature · 2 lines
Damien Le Moal Western Digital Research