Skip to contentSkip to conversation

f2fs: fix possible memory leak in f2fs_init_sysfs()

PATCH In review Yang Yingliang via Linux-f2fs-devel 3 participants 4 messages Oct 18, 2022 – Oct 28, 2022 F2FS file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 f2fs: fix possible memory leak in f2fs_init_sysfs()

Inject fault while probing module, kset_register() may fail, if it fails, but the refcount of kobject is not decreased to 0, the name allocated in kobject_set_name() is leaked. Fix this by calling kset_put(), so that name can be freed in callback function kobject_cleanup().

unreferenced object 0xffff888101b7cc80 (size 8):
comm "modprobe", pid 252, jiffies 4294691378 (age 31.760s) hex dump (first 8 bytes):

    66 32 66 73 00 88 ff ff                          f2fs....
  backtrace:
    [<000000001db5b408>] __kmalloc_node_track_caller+0x44/0x1b0
    [<000000002783a073>] kstrdup+0x3a/0x70
    [<00000000ead2b281>] kstrdup_const+0x63/0x80
    [<000000003e5cf8f7>] kvasprintf_const+0x149/0x180
    [<00000000c4d949ff>] kobject_set_name_vargs+0x56/0x150
    [<0000000044611660>] kobject_set_name+0xab/0xe0
Fixes bf9e697ecd42 ("f2fs: expose features to sysfs entry")
---
 fs/f2fs/sysfs.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
fs/f2fs/sysfs.c +3 -1
index df27afd71ef4..2ef7a48967be 100644
@@ -1250,8 +1250,10 @@ int __init f2fs_init_sysfs(void)
 	kobject_set_name(&f2fs_kset.kobj, "f2fs");
 	f2fs_kset.kobj.parent = fs_kobj;
 	ret = kset_register(&f2fs_kset);
-	if (ret)
+	if (ret) {
+		kset_put(&f2fs_kset);
 		return ret;
+	}
 
 	ret = kobject_init_and_add(&f2fs_feat, &f2fs_feat_ktype,
 				   NULL, "features");
Signature · 8 lines
2.25.1



_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 18 lines · Yang Yingliang

Inject fault while probing module, kset_register() may fail, if it fails, but the refcount of kobject is not decreased to 0, the name allocated in kobject_set_name() is leaked. Fix this by calling kset_put(), so that name can be freed in callback function kobject_cleanup().

unreferenced object 0xffff888101b7cc80 (size 8):

   comm "modprobe", pid 252, jiffies 4294691378 (age 31.760s)
   hex dump (first 8 bytes):
     66 32 66 73 00 88 ff ff                          f2fs....
   backtrace:
     [<000000001db5b408>] __kmalloc_node_track_caller+0x44/0x1b0
     [<000000002783a073>] kstrdup+0x3a/0x70
     [<00000000ead2b281>] kstrdup_const+0x63/0x80
     [<000000003e5cf8f7>] kvasprintf_const+0x149/0x180
     [<00000000c4d949ff>] kobject_set_name_vargs+0x56/0x150
     [<0000000044611660>] kobject_set_name+0xab/0xe0
Quoted 2 lines
Fixes bf9e697ecd42 ("f2fs: expose features to sysfs entry")

Thanks,

_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

maintainer
#2 lore raw

Jaegeuk,

There is a generic fix [1], let's drop this one...

https://lore.kernel.org/lkml/[email protected]/T/

Quoted 24 lines · Chao Yu
Quoted 18 lines · Yang Yingliang

Inject fault while probing module, kset_register() may fail, if it fails, but the refcount of kobject is not decreased to 0, the name allocated in kobject_set_name() is leaked. Fix this by calling kset_put(), so that name can be freed in callback function kobject_cleanup().

unreferenced object 0xffff888101b7cc80 (size 8):
   comm "modprobe", pid 252, jiffies 4294691378 (age 31.760s) hex dump (first 8 bytes):
     66 32 66 73 00 88 ff ff                          f2fs.... backtrace:

     [<000000001db5b408>] __kmalloc_node_track_caller+0x44/0x1b0
     [<000000002783a073>] kstrdup+0x3a/0x70
     [<00000000ead2b281>] kstrdup_const+0x63/0x80
     [<000000003e5cf8f7>] kvasprintf_const+0x149/0x180
     [<00000000c4d949ff>] kobject_set_name_vargs+0x56/0x150
     [<0000000044611660>] kobject_set_name+0xab/0xe0
Quoted 2 lines
Fixes bf9e697ecd42 ("f2fs: expose features to sysfs entry")
Quoted 7 lines

Thanks,

_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

maintainer
#3 lore raw
Quoted 3 lines · Chao Yu

Jaegeuk,

There is a generic fix [1], let's drop this one...

Ok, thanks.

Quoted 35 lines

https://lore.kernel.org/lkml/[email protected]/T/

Quoted 31 lines · Chao Yu
Quoted 18 lines · Yang Yingliang

Inject fault while probing module, kset_register() may fail, if it fails, but the refcount of kobject is not decreased to 0, the name allocated in kobject_set_name() is leaked. Fix this by calling kset_put(), so that name can be freed in callback function kobject_cleanup().

unreferenced object 0xffff888101b7cc80 (size 8):
   comm "modprobe", pid 252, jiffies 4294691378 (age 31.760s) hex dump (first 8 bytes):
     66 32 66 73 00 88 ff ff                          f2fs.... backtrace:

     [<000000001db5b408>] __kmalloc_node_track_caller+0x44/0x1b0
     [<000000002783a073>] kstrdup+0x3a/0x70
     [<00000000ead2b281>] kstrdup_const+0x63/0x80
     [<000000003e5cf8f7>] kvasprintf_const+0x149/0x180
     [<00000000c4d949ff>] kobject_set_name_vargs+0x56/0x150
     [<0000000044611660>] kobject_set_name+0xab/0xe0
Quoted 2 lines
Fixes bf9e697ecd42 ("f2fs: expose features to sysfs entry")

Thanks,

_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel