Skip to contentSkip to conversation

Minor issues with sdp-xml

PATCH In review Denis KENZIOR 4 participants 6 messages Feb 6, 2007 – Feb 14, 2007 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Minor issues with sdp-xml

Marcel,

This patch fixes up a couple of minor bugs I found.

-Denis

Index: sdp-xml.c
===================================================================
RCS file: /cvsroot/bluez/utils/common/sdp-xml.c,v
retrieving revision 1.7

sdp-xml.c +3 -3
diff -u -r1.7 sdp-xml.c
@@ -265,7 +265,7 @@
 		if (hex) {
 			appender(data, "encoding=\"hex\" ");
 			strBuf = (char *) malloc(sizeof(char)
-						 * (value->unitSize * 2 + 1));
+						 * ((value->unitSize-1) * 2 + 1));
 
 			/* Unit Size seems to include the size for dtd
 			   It is thus off by 1
@@ -276,7 +276,7 @@
 					"%02x",
 					(unsigned char) value->val.str[i]);
 
-			strBuf[value->unitSize * 2] = '\0';
+			strBuf[(value->unitSize-1) * 2] = '\0';
 		}
 		else {
 			int j;
@@ -603,7 +603,7 @@
 			buf[0] = data[i];
 			buf[1] = data[i + 1];
 
-			val.data[i] = strtoul(buf, 0, 16);
+			val.data[i >> 1] = strtoul(buf, 0, 16);
 		}
 
 		ret = sdp_data_alloc(dtd, &val);

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

#1 lore raw
Quoted 4 lines · Denis KENZIOR

Marcel,
=

This patch fixes up a couple of minor bugs I found.

Thanks. Parts of this were also reported today:
https://bugzilla.novell.com/show_bug.cgi?id=3D242030

Quoted 2 lines

Index: sdp-xml.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

sdp-xml.c line 608

Quoted 13 lines

RCS file: /cvsroot/bluez/utils/common/sdp-xml.c,v
retrieving revision 1.7
diff -u -r1.7 sdp-xml.c

sdp-xml.c +1 -1
@@ -603,7 +603,7 @@
 			buf[0] =3D data[i];
 			buf[1] =3D data[i + 1];
 =
 
-			val.data[i] =3D strtoul(buf, 0, 16);
+			val.data[i >> 1] =3D strtoul(buf, 0, 16);
 		}

This is the part that was reported as generating a compiler warning. -- =

Stefan Seyfried
QA / R&D Team Mobile Devices | "Any ideas, John?"
SUSE LINUX Products GmbH, N=FCrnberg | "Well, surrounding them's out." =

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easi= er.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid=3D263057&dat=3D1=
21642
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

maintainer
#2 lore raw
In reply to Denis KENZIOR

Hi Denis,

Quoted 1 line

This patch fixes up a couple of minor bugs I found.

the patch has been committed to the CVS. Thanks.

Regards

Marcel

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

#3 lore raw

[Bluez-devel] Linux Distribution for Bluez

Hi ,

I am a newbie to Bluetooth Development using Linux. Which Linux Distribution is the best to use to with the BlueZ Linux protocol stack,

thanks for your replies and suggestions,

regards,

Mark.

Marcel Holtmann <[email protected]> wrote: Hi Denis,

Quoted 1 line

This patch fixes up a couple of minor bugs I found.

the patch has been committed to the CVS. Thanks.

Regards

Marcel

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

---------------------------------
Never miss an email again!
Yahoo! Toolbar alerts you the instant new Mail arrives. Check it out.

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

maintainer
#4 lore raw

Re: [Bluez-devel] Linux Distribution for Bluez

Hi,

don't hi-jack threads with a different topic.

Quoted 3 lines

I am a newbie to Bluetooth Development using Linux. Which Linux Distribution is the best to use to with the BlueZ Linux protocol stack,

Actually all distros are usable. The question is which one is more up-to-date than others. All of them have at least bluez-utils-3.7 and I think there exists pending update to bluez-utils-3.9 for Fedora Core 6.

Regards

Marcel

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

#5 lore raw

Re: [Bluez-devel] Linux Distribution for Bluez

thank you Marcel for the reply. I apologise for hijacking of a thread with different topic.

regards,

mark.

Marcel Holtmann <[email protected]> wrote: Hi,

don't hi-jack threads with a different topic.

Quoted 3 lines

I am a newbie to Bluetooth Development using Linux. Which Linux Distribution is the best to use to with the BlueZ Linux protocol stack,

Actually all distros are usable. The question is which one is more up-to-date than others. All of them have at least bluez-utils-3.7 and I think there exists pending update to bluez-utils-3.9 for Fedora Core 6.

Regards

Marcel

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

---------------------------------
Now that's room service! Choose from over 150,000 hotels in 45,000 destinations on Yahoo! Travel to find your fit.

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel