mbuf: remove deprecated segment free functions
PATCH 1/1 mbuf: remove deprecated segment free functions
__rte_mbuf_raw_free and __rte_pktmbuf_prefree_seg have been deprecated for a long time now (early 17.05), are not part of the abi and are easily replaced with existing api.
--- lib/librte_mbuf/rte_mbuf.h | 16 ---------------- 1 file changed, 16 deletions(-)
lib/librte_mbuf/rte_mbuf.h +0 -16
@@ -1038,14 +1038,6 @@ rte_mbuf_raw_free(struct rte_mbuf *m)rte_mempool_put (m->pool, m); } -/* compat with older versions */ -__rte_deprecated -static inline void -__rte_mbuf_raw_free (struct rte_mbuf *m) -{ -rte_mbuf_raw_free (m); -} -/** * The packet mbuf constructor. *
@@ -1658,14 +1650,6 @@ rte_pktmbuf_prefree_seg(struct rte_mbuf *m)return NULL ; } -/* deprecated, replaced by rte_pktmbuf_prefree_seg() */ -__rte_deprecated -static inline struct rte_mbuf * -__rte_pktmbuf_prefree_seg (struct rte_mbuf *m) -{ -return rte_pktmbuf_prefree_seg (m); -} -/** * Free a segment of a packet mbuf into its original mempool. *
Signature · 1 line
2.17.1
Quoted 5 lines · David Marchand
__rte_mbuf_raw_freeand__rte_pktmbuf_prefree_seghave been deprecated for a long time now (early 17.05), are not part of the abi and are easily replaced with existing api.Signed-off-by David Marchand <[email protected]>
10/09/2018 10:06, Andrew Rybchenko:
Quoted 8 lines · David Marchand
Quoted 5 lines
__rte_mbuf_raw_freeand__rte_pktmbuf_prefree_seghave been deprecated for a long time now (early 17.05), are not part of the abi and are easily replaced with existing api.Signed-off-by David Marchand <[email protected]>Acked-by Andrew Rybchenko <[email protected]>
I think we need to bump the library version and update the API section in the release notes.
Hi Thomas,
Quoted 6 lines · Thomas Monjalon
10/09/2018 10:06, Andrew Rybchenko:
Quoted 5 lines · David Marchand
Quoted 4 lines
__rte_mbuf_raw_freeand__rte_pktmbuf_prefree_seghave been deprecated for a long time now (early 17.05), are not part of the abi and are easily replaced with existing api.
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by David Marchand <[email protected]>Acked-by Andrew Rybchenko <[email protected]>I think we need to bump the library version and update the API section in the release notes.
I don't think bumping the lib version is required here, the patch removes two functions that are static inline.
But updating the API section would be nice, yes.
Thanks,
Olivier
PATCH v2 1/1 mbuf: remove deprecated segment free functions
In reply to David Marchand__rte_mbuf_raw_free and __rte_pktmbuf_prefree_seg have been deprecated for a long time now (early 17.05), are not part of the abi and are easily replaced with existing api.
--- doc/guides/rel_notes/release_18_11.rst | 5 +++++ lib/librte_mbuf/rte_mbuf.h | 16 ---------------- 2 files changed, 5 insertions(+), 16 deletions(-)
doc/guides/rel_notes/release_18_11.rst +5 -0
@@ -68,6 +68,11 @@ API Changes Also, make sure to start the actual text at the margin. ========================================================= +* mbuf: The ``__rte_mbuf_raw_free()`` and ``__rte_pktmbuf_prefree_seg()`` + functions were deprecated since 17.05 and are removed: + + Those functions were kept for compatibility and are replaced by + ``rte_mbuf_raw_free()`` and ``rte_pktmbuf_prefree_seg()``. ABI Changes -----------
lib/librte_mbuf/rte_mbuf.h +0 -16
@@ -1038,14 +1038,6 @@ rte_mbuf_raw_free(struct rte_mbuf *m)rte_mempool_put (m->pool, m); } -/* compat with older versions */ -__rte_deprecated -static inline void -__rte_mbuf_raw_free (struct rte_mbuf *m) -{ -rte_mbuf_raw_free (m); -} -/** * The packet mbuf constructor. *
@@ -1658,14 +1650,6 @@ rte_pktmbuf_prefree_seg(struct rte_mbuf *m)return NULL ; } -/* deprecated, replaced by rte_pktmbuf_prefree_seg() */ -__rte_deprecated -static inline struct rte_mbuf * -__rte_pktmbuf_prefree_seg (struct rte_mbuf *m) -{ -return rte_pktmbuf_prefree_seg (m); -} -/** * Free a segment of a packet mbuf into its original mempool. *
Signature · 1 line
2.17.1
Thomas Monjalon
Applied17/09/2018 14:45, David Marchand:
Quoted 6 lines
__rte_mbuf_raw_freeand__rte_pktmbuf_prefree_seghave been deprecated for a long time now (early 17.05), are not part of the abi and are easily replaced with existing api.Signed-off-by David Marchand <[email protected]>Acked-by Andrew Rybchenko <[email protected]>
Applied, thanks