clk: ast2600: enable BCLK for PCI/PCIe bus always
PATCH 1/1 clk: ast2600: enable BCLK for PCI/PCIe bus always
BCLK for PCI/PCIe bus should be enabled always with having the CLK_IS_CRITICAL flag otherwise it will be disabled at kernel late initcall phase as an unused clock, and eventually it causes unexpected behavior on BMC features that are connected to the host through PCI/PCIe bus.
--- drivers/clk/clk-ast2600.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/clk-ast2600.c +1 -1
@@ -64,7 +64,7 @@ static const struct aspeed_gate_data aspeed_g6_gates[] = { [ASPEED_CLK_GATE_GCLK] = { 2, 7, "gclk-gate", NULL, 0 }, /* 2D engine */ /* vclk parent - dclk/d1clk/hclk/mclk */ [ASPEED_CLK_GATE_VCLK] = { 3, 6, "vclk-gate", NULL, 0 }, /* Video Capture */ - [ASPEED_CLK_GATE_BCLK] = { 4, 8, "bclk-gate", "bclk", 0 }, /* PCIe/PCI */ + [ASPEED_CLK_GATE_BCLK] = { 4, 8, "bclk-gate", "bclk", CLK_IS_CRITICAL }, /* PCIe/PCI */ /* From dpll */ [ASPEED_CLK_GATE_DCLK] = { 5, -1, "dclk-gate", NULL, CLK_IS_CRITICAL }, /* DAC */ [ASPEED_CLK_GATE_REF0CLK] = { 6, -1, "ref0clk-gate", "clkin", CLK_IS_CRITICAL },
Signature · 1 line
2.17.1
PATCH 1/1 clk: ast2600: enable BCLK for PCI/PCIe bus always
Quoted 6 lines · Jae Hyun Yoo
BCLK for PCI/PCIe bus should be enabled always with having the
CLK_IS_CRITICALflag otherwise it will be disabled at kernel late initcall phase as an unused clock, and eventually it causes unexpected behavior on BMC features that are connected to the host through PCI/PCIe bus.
This is true for systems that have PCIe connected. There are systems that do not, and in that case we don't want to have the clock enabled.
Are you doing this to support the case where the PCIe device not load a BMC driver? (eg for host VGA use). If not, then you can have the driver you're loading request the BCLK.
If this is for the host VGA device, then you will need to come up with a mechanism that makes the enabling of this clock depend on the device tree.
Cheers,
Joel
Quoted 22 lines
Signed-off-by Jae Hyun Yoo <[email protected]>--- drivers/clk/clk-ast2600.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/clk/clk-ast2600.c +1
-2@@ -64,7 +64,7 @@ static const struct aspeed_gate_data aspeed_g6_gates[] = { [ASPEED_CLK_GATE_GCLK] = { 2, 7, "gclk-gate", NULL, 0 }, /* 2D engine */ /* vclk parent - dclk/d1clk/hclk/mclk */ [ASPEED_CLK_GATE_VCLK] = { 3, 6, "vclk-gate", NULL, 0 }, /* Video Capture */ - [ASPEED_CLK_GATE_BCLK ] = {4 ,8 ,"bclk-gate" ,"bclk" ,0 },/* PCIe/PCI */ + [ASPEED_CLK_GATE_BCLK] = { 4, 8, "bclk-gate", "bclk", CLK_IS_CRITICAL }, /* PCIe/PCI */ /* From dpll */ [ASPEED_CLK_GATE_DCLK] = { 5, -1, "dclk-gate", NULL, CLK_IS_CRITICAL }, /* DAC */ [ASPEED_CLK_GATE_REF0CLK] = { 6, -1, "ref0clk-gate", "clkin", CLK_IS_CRITICAL }, --2.17.1
PATCH 1/1 clk: ast2600: enable BCLK for PCI/PCIe bus always
Hi Joel,
Quoted 11 lines · Joel Stanley
Quoted 6 lines · Jae Hyun Yoo
BCLK for PCI/PCIe bus should be enabled always with having the
CLK_IS_CRITICALflag otherwise it will be disabled at kernel late initcall phase as an unused clock, and eventually it causes unexpected behavior on BMC features that are connected to the host through PCI/PCIe bus.This is true for systems that have PCIe connected. There are systems that do not, and in that case we don't want to have the clock enabled.
Quoted 7 lines
Are you doing this to support the case where the PCIe device not load a BMC driver? (eg for host VGA use). If not, then you can have the driver you're loading request the BCLK.
If this is for the host VGA device, then you will need to come up with a mechanism that makes the enabling of this clock depend on the device tree.
Is there any way to enable clock by just adding a node in device tree? Do you want me to add a simple driver module for host VGA just for enabling BCLK?
Thanks,
Jae
Quoted 27 lines
Cheers,
Joel
Quoted 22 lines
Signed-off-by Jae Hyun Yoo <[email protected]>--- drivers/clk/clk-ast2600.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/clk/clk-ast2600.c +1
-2@@ -64,7 +64,7 @@ static const struct aspeed_gate_data aspeed_g6_gates[] = { [ASPEED_CLK_GATE_GCLK] = { 2, 7, "gclk-gate", NULL, 0 }, /* 2D engine */ /* vclk parent - dclk/d1clk/hclk/mclk */ [ASPEED_CLK_GATE_VCLK] = { 3, 6, "vclk-gate", NULL, 0 }, /* Video Capture */ - [ASPEED_CLK_GATE_BCLK ] = {4 ,8 ,"bclk-gate" ,"bclk" ,0 },/* PCIe/PCI */ + [ASPEED_CLK_GATE_BCLK] = { 4, 8, "bclk-gate", "bclk", CLK_IS_CRITICAL }, /* PCIe/PCI */ /* From dpll */ [ASPEED_CLK_GATE_DCLK] = { 5, -1, "dclk-gate", NULL, CLK_IS_CRITICAL }, /* DAC */ [ASPEED_CLK_GATE_REF0CLK] = { 6, -1, "ref0clk-gate", "clkin", CLK_IS_CRITICAL }, --2.17.1
PATCH 1/1 clk: ast2600: enable BCLK for PCI/PCIe bus always
Quoted 19 lines · Jae Hyun Yoo
Hi Joel,
Quoted 15 lines · Joel Stanley
Quoted 6 lines · Jae Hyun Yoo
BCLK for PCI/PCIe bus should be enabled always with having the
CLK_IS_CRITICALflag otherwise it will be disabled at kernel late initcall phase as an unused clock, and eventually it causes unexpected behavior on BMC features that are connected to the host through PCI/PCIe bus.This is true for systems that have PCIe connected. There are systems that do not, and in that case we don't want to have the clock enabled.
Are you doing this to support the case where the PCIe device not load a BMC driver? (eg for host VGA use). If not, then you can have the driver you're loading request the BCLK.
Quoted 7 lines
Quoted 3 lines
If this is for the host VGA device, then you will need to come up with a mechanism that makes the enabling of this clock depend on the device tree.
Is there any way to enable clock by just adding a node in device tree? Do you want me to add a simple driver module for host VGA just for enabling BCLK?
Okay, so this is for the case where we lack a BMC driver.
One option would be to do as you suggest, adding a simple driver that claims essential clocks.
Another could be to add some extra properties that clock driver parses and enables the clocks.
PATCH 1/1 clk: ast2600: enable BCLK for PCI/PCIe bus always
Quoted 28 lines · Joel Stanley
Quoted 19 lines · Jae Hyun Yoo
Hi Joel,
Quoted 15 lines · Joel Stanley
Quoted 6 lines · Jae Hyun Yoo
BCLK for PCI/PCIe bus should be enabled always with having the
CLK_IS_CRITICALflag otherwise it will be disabled at kernel late initcall phase as an unused clock, and eventually it causes unexpected behavior on BMC features that are connected to the host through PCI/PCIe bus.This is true for systems that have PCIe connected. There are systems that do not, and in that case we don't want to have the clock enabled.
Are you doing this to support the case where the PCIe device not load a BMC driver? (eg for host VGA use). If not, then you can have the driver you're loading request the BCLK.
Quoted 7 lines
Quoted 3 lines
If this is for the host VGA device, then you will need to come up with a mechanism that makes the enabling of this clock depend on the device tree.
Is there any way to enable clock by just adding a node in device tree? Do you want me to add a simple driver module for host VGA just for enabling BCLK?
Quoted 8 lines
Okay, so this is for the case where we lack a BMC driver.
One option would be to do as you suggest, adding a simple driver that claims essential clocks.
Another could be to add some extra properties that clock driver parses and enables the clocks.
Looks like it needs changes in clk-ast2600 module for checking of 'clock-critical' device tree property. Let me try to make it.
Thanks,
Jae