Skip to contentSkip to conversation

target/ppc: Add extra float instructions to POWER5P processors

PATCH Applied Cédric Le Goater 2 participants 4 messages Jan 10, 2022 – Jan 12, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 target/ppc: Add extra float instructions to POWER5P processors

ISA v2.03 introduced Floating Round to Integer instructions : frin, friz, frip, and frim. Add them to POWER5+.

The PPC_FLOAT_EXT flag also includes the fre (Floating Reciprocal Estimate) instruction which was introduced in ISA v2.0x. The architecture document says its optional and that might the reason why it has been kept under the PPC_FLOAT_EXT. This means 970 CPUs can not use it under QEMU.

---
 target/ppc/cpu_init.c | 1 +
 1 file changed, 1 insertion(+)
target/ppc/cpu_init.c +1 -0
index f15a52259c90..e30e86fe9d04 100644
@@ -6953,6 +6953,7 @@ POWERPC_FAMILY(POWER5P)(ObjectClass *oc, void *data)
                        PPC_FLOAT | PPC_FLOAT_FSEL | PPC_FLOAT_FRES |
                        PPC_FLOAT_FSQRT | PPC_FLOAT_FRSQRTE |
                        PPC_FLOAT_STFIWX |
+                       PPC_FLOAT_EXT |
                        PPC_CACHE | PPC_CACHE_ICBI | PPC_CACHE_DCBZ |
                        PPC_MEM_SYNC | PPC_MEM_EIEIO |
                        PPC_MEM_TLBIE | PPC_MEM_TLBSYNC |
Signature · 1 line
2.31.1
#1 lore raw
Quoted 6 lines · Cédric Le Goater

ISA v2.03 introduced Floating Round to Integer instructions : frin, friz, frip, and frim. Add them to POWER5+.

The PPC_FLOAT_EXT flag also includes the fre (Floating Reciprocal Estimate) instruction which was introduced in ISA v2.0x. The architecture document says its optional and that might the reason why

There's a grammar error in this sentence. I think it should be "might be the reason" or "might have been the reason", not sure which is more correct but "be" is missing here for sure. Another one: it should be "it's" instead of "its" in this context.

Regards,
BALATON Zoltan

Quoted 21 lines

it has been kept under the PPC_FLOAT_EXT. This means 970 CPUs can not use it under QEMU.

---
target/ppc/cpu_init.c | 1 +

1 file changed, 1 insertion(+)
target/ppc/cpu_init.c +1 -0
index f15a52259c90..e30e86fe9d04 100644
@@ -6953,6 +6953,7 @@ POWERPC_FAMILY(POWER5P)(ObjectClass *oc, void *data)
                       PPC_FLOAT | PPC_FLOAT_FSEL | PPC_FLOAT_FRES |
                       PPC_FLOAT_FSQRT | PPC_FLOAT_FRSQRTE |
                       PPC_FLOAT_STFIWX |
+                       PPC_FLOAT_EXT |
                       PPC_CACHE | PPC_CACHE_ICBI | PPC_CACHE_DCBZ |
                       PPC_MEM_SYNC | PPC_MEM_EIEIO |
                       PPC_MEM_TLBIE | PPC_MEM_TLBSYNC |
#2 lore raw
Quoted 9 lines · BALATON Zoltan
Quoted 6 lines · Cédric Le Goater

ISA v2.03 introduced Floating Round to Integer instructions : frin, friz, frip, and frim. Add them to POWER5+.

The PPC_FLOAT_EXT flag also includes the fre (Floating Reciprocal Estimate) instruction which was introduced in ISA v2.0x. The architecture document says its optional and that might the reason why

There's a grammar error in this sentence. I think it should be "might be the reason" or "might have been the reason", not sure which is more correct but "be" is missing here for sure. Another one: it should be "it's" instead of "its" in this context.

A "be" is missing indeed ! Fixed.

Thanks,

C.

Quoted 25 lines

Regards,
BALATON Zoltan

Quoted 21 lines

it has been kept under the PPC_FLOAT_EXT. This means 970 CPUs can not use it under QEMU.

---
target/ppc/cpu_init.c | 1 +

1 file changed, 1 insertion(+)
target/ppc/cpu_init.c +0 -0
index f15a52259c90..e30e86fe9d04 100644
@@ -6953,6 +6953,7 @@ POWERPC_FAMILY(POWER5P)(ObjectClass *oc, void *data)

                       PPC_FLOAT | PPC_FLOAT_FSEL | PPC_FLOAT_FRES | PPC_FLOAT_FSQRT | PPC_FLOAT_FRSQRTE | PPC_FLOAT_STFIWX |
+                       PPC_FLOAT_EXT |
                       PPC_CACHE | PPC_CACHE_ICBI | PPC_CACHE_DCBZ | PPC_MEM_SYNC | PPC_MEM_EIEIO | PPC_MEM_TLBIE | PPC_MEM_TLBSYNC |

author Applied
#3 lore raw
In reply to Cédric Le Goater
Quoted 10 lines · Cédric Le Goater

ISA v2.03 introduced Floating Round to Integer instructions : frin, friz, frip, and frim. Add them to POWER5+.

The PPC_FLOAT_EXT flag also includes the fre (Floating Reciprocal Estimate) instruction which was introduced in ISA v2.0x. The architecture document says its optional and that might the reason why it has been kept under the PPC_FLOAT_EXT. This means 970 CPUs can not use it under QEMU.

Applied to ppc7.0.

Thanks,

C.