arm: socfpga: gen5: Enable cache driver in SPL
Subsystems (3)
PATCH 1/1 arm: socfpga: gen5: Enable cache driver in SPL
Adding "u-boot,dm-pre-reloc" and enable CONFIG_SPL_CACHE to enable cache driver in SPL.
This fixed error below in SPL:
cache controller driver NOT found!
--- arch/arm/dts/socfpga-common-u-boot.dtsi | 4 ++++ arch/arm/mach-socfpga/Kconfig | 1 + 2 files changed, 5 insertions(+)
arch/arm/dts/socfpga-common-u-boot.dtsi +4 -0
@@ -14,6 +14,10 @@ u-boot,dm-pre-reloc; }; +&L2 { + u-boot,dm-pre-reloc; +}; + &rst { u-boot,dm-pre-reloc; };
arch/arm/mach-socfpga/Kconfig +1 -0
@@ -67,6 +67,7 @@ config TARGET_SOCFPGA_CYCLONE5 config TARGET_SOCFPGA_GEN5 bool select SPL_ALTERA_SDRAM + select SPL_CACHE if SPL imply FPGA_SOCFPGA imply SPL_SIZE_LIMIT_SUBTRACT_GD imply SPL_SIZE_LIMIT_SUBTRACT_MALLOC
Signature · 1 line
2.19.0
PATCH 1/1 arm: socfpga: gen5: Enable cache driver in SPL
Quoted 7 lines · Ley Foon Tan
Adding "u-boot,dm-pre-reloc" and enable
CONFIG_SPL_CACHEto enable cache driver in SPL.This fixed error below in SPL:
cache controller driver NOT found!Signed-off-by Ley Foon Tan <[email protected]>
Is this for current release or next ?
PATCH 1/1 arm: socfpga: gen5: Enable cache driver in SPL
Marek Vasut <[email protected]> schrieb am Fr., 5. Juni 2020, 14:52:
Quoted 7 lines · Ley Foon Tan
Quoted 5 lines
Adding "u-boot,dm-pre-reloc" and enable
CONFIG_SPL_CACHEto enable cache driver in SPL.This fixed error below in SPL:
cache controller driver NOT found!
What's the size impact of this? What is the actual problem? From this description, I would think the message needs to be fixed instead of adding cache drivers?
We're already quite constrained in gen5. I'm not keen on adding drivers just because of an error message...
Regards,
Simon
Quoted 5 lines
Quoted 2 lines
Signed-off-by Ley Foon Tan <[email protected]>Is this for current release or next ?
Tan
PATCH 1/1 arm: socfpga: gen5: Enable cache driver in SPL
In reply to Marek VasutQuoted 16 lines
-----Original Message-----
From: Marek Vasut <[email protected]>
Sent: Friday, June 5, 2020 8:53 PM
To: Tan, Ley Foon <[email protected]>; u-boot at lists.denx.de
Cc: Ley Foon Tan <[email protected]>; See, Chin Liang <[email protected]>; Simon Goldschmidt <[email protected]>; Ang, Chee Hong <[email protected]>
Subject: Re: [PATCH] arm: socfpga: gen5: Enable cache driver in SPLQuoted 3 lines · Ley Foon Tan
Adding "u-boot,dm-pre-reloc" and enable
CONFIG_SPL_CACHEto enable cache driver in SPL.
Quoted 6 lines
Quoted 4 lines
This fixed error below in SPL:
cache controller driver NOT found!Signed-off-by Ley Foon Tan <[email protected]>Is this for current release or next ?
Can drop this patch first. Just found out only see this error when enable ECC scrubbing with Dcache in Gen5 in our downstream branch. But, mainline Uboot haven't support ECC in Gen5 yet. Will add this patch when enable ECC in Gen5 later.
Thanks.
Regards
Ley Foon