Skip to contentSkip to conversation

arm: socfpga: gen5: Enable cache driver in SPL

PATCH New Ley Foon Tan 4 participants 4 messages Jun 5, 2020 – Jun 9, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: socfpga: gen5: Enable cache driver in SPL

Adding "u-boot,dm-pre-reloc" and enable CONFIG_SPL_CACHE to enable cache driver in SPL.

This fixed error below in SPL:
cache controller driver NOT found!

---
 arch/arm/dts/socfpga-common-u-boot.dtsi | 4 ++++
 arch/arm/mach-socfpga/Kconfig           | 1 +
 2 files changed, 5 insertions(+)
arch/arm/dts/socfpga-common-u-boot.dtsi +4 -0
index d55460755fe3..f65aca6ebaba 100644
@@ -14,6 +14,10 @@
 	u-boot,dm-pre-reloc;
 };
 
+&L2 {
+	u-boot,dm-pre-reloc;
+};
+
 &rst {
 	u-boot,dm-pre-reloc;
 };
arch/arm/mach-socfpga/Kconfig +1 -0
index a3699e82a19e..1173422b8f28 100644
@@ -67,6 +67,7 @@ config TARGET_SOCFPGA_CYCLONE5
 config TARGET_SOCFPGA_GEN5
 	bool
 	select SPL_ALTERA_SDRAM
+	select SPL_CACHE if SPL
 	imply FPGA_SOCFPGA
 	imply SPL_SIZE_LIMIT_SUBTRACT_GD
 	imply SPL_SIZE_LIMIT_SUBTRACT_MALLOC
Signature · 1 line
2.19.0
#1 lore raw

PATCH 1/1 arm: socfpga: gen5: Enable cache driver in SPL

Quoted 7 lines · Ley Foon Tan

Adding "u-boot,dm-pre-reloc" and enable CONFIG_SPL_CACHE to enable cache driver in SPL.

This fixed error below in SPL:
cache controller driver NOT found!

Is this for current release or next ?

#2 lore raw

PATCH 1/1 arm: socfpga: gen5: Enable cache driver in SPL

Marek Vasut <[email protected]> schrieb am Fr., 5. Juni 2020, 14:52:

Quoted 7 lines · Ley Foon Tan
Quoted 5 lines

Adding "u-boot,dm-pre-reloc" and enable CONFIG_SPL_CACHE to enable cache driver in SPL.

This fixed error below in SPL:
cache controller driver NOT found!

What's the size impact of this? What is the actual problem? From this description, I would think the message needs to be fixed instead of adding cache drivers?

We're already quite constrained in gen5. I'm not keen on adding drivers just because of an error message...

Regards,
Simon

Quoted 5 lines
Quoted 2 lines

Is this for current release or next ?

#3 lore raw

PATCH 1/1 arm: socfpga: gen5: Enable cache driver in SPL

In reply to Marek Vasut
Quoted 16 lines

-----Original Message-----
From: Marek Vasut <[email protected]>
Sent: Friday, June 5, 2020 8:53 PM
To: Tan, Ley Foon <[email protected]>; u-boot at lists.denx.de
Cc: Ley Foon Tan <[email protected]>; See, Chin Liang <[email protected]>; Simon Goldschmidt <[email protected]>; Ang, Chee Hong <[email protected]>
Subject: Re: [PATCH] arm: socfpga: gen5: Enable cache driver in SPL

Quoted 3 lines · Ley Foon Tan

Adding "u-boot,dm-pre-reloc" and enable CONFIG_SPL_CACHE to enable cache driver in SPL.

Quoted 6 lines
Quoted 4 lines

This fixed error below in SPL:
cache controller driver NOT found!

Is this for current release or next ?

Can drop this patch first. Just found out only see this error when enable ECC scrubbing with Dcache in Gen5 in our downstream branch. But, mainline Uboot haven't support ECC in Gen5 yet. Will add this patch when enable ECC in Gen5 later.

Thanks.

Regards
Ley Foon