Skip to contentSkip to conversation

selftests/bpf: add uprobe_multi test binary to .gitignore

PATCH Applied Andrii Nakryiko 4 participants 6 messages Aug 24, 2023

Subsystems (4)
lore
Share & tools
lore

Andrii Nakryiko

author maintainer
#0 lore raw

PATCH 1/2 selftests/bpf: add uprobe_multi test binary to .gitignore

It seems like it was forgotten to add uprobe_multi binary to .gitignore. Fix this trivial omission.

---
 tools/testing/selftests/bpf/.gitignore | 1 +
 1 file changed, 1 insertion(+)
tools/testing/selftests/bpf/.gitignore +1 -0
index 110518ba4804..f1aebabfb017 100644
@@ -44,6 +44,7 @@ test_cpp
 /bench
 /veristat
 /sign-file
+/uprobe_multi
 *.ko
 *.tmp
 xskxceiver
Signature · 1 line
2.34.1
author maintainer
#1 lore raw

PATCH 2/2 libbpf: fix signedness determination in CO-RE relo handling logic

Extracting btf_int_encoding() is only meaningful for BTF_KIND_INT, so we need to check that first before inferring signedness.

---
 tools/lib/bpf/relo_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/lib/bpf/relo_core.c +1 -1
index a26b2f5fa0fc..63a4d5ad12d1 100644
@@ -776,7 +776,7 @@ static int bpf_core_calc_field_relo(const char *prog_name,
 		break;
 	case BPF_CORE_FIELD_SIGNED:
 		*val = (btf_is_any_enum(mt) && BTF_INFO_KFLAG(mt->info)) ||
-		       (btf_int_encoding(mt) & BTF_INT_SIGNED);
+		       (btf_is_int(mt) && (btf_int_encoding(mt) & BTF_INT_SIGNED));
 		if (validate)
 			*validate = true; /* signedness is never ambiguous */
 		break;
Signature · 1 line
2.34.1
reviewer Acked-by on v1 2/2
#2 lore raw

Re: [PATCH bpf-next 2/2] libbpf: fix signedness determination in CO-RE relo handling logic

Quoted 6 lines · Andrii Nakryiko

Extracting btf_int_encoding() is only meaningful for BTF_KIND_INT, so we need to check that first before inferring signedness.

reviewer Acked-by on v1 1/2
#3 lore raw
In reply to Andrii Nakryiko
Quoted 4 lines · Andrii Nakryiko

It seems like it was forgotten to add uprobe_multi binary to .gitignore. Fix this trivial omission.

I actually noticed this problem as well. Thanks for the fix!

Quoted 16 lines
---
  tools/testing/selftests/bpf/.gitignore | 1 +
  1 file changed, 1 insertion(+)
tools/testing/selftests/bpf/.gitignore +1 -0
index 110518ba4804..f1aebabfb017 100644
@@ -44,6 +44,7 @@ test_cpp
  /bench
  /veristat
  /sign-file
+/uprobe_multi
  *.ko
  *.tmp
  xskxceiver
#4 lore raw
In reply to Andrii Nakryiko
This series was applied to bpf/bpf-next.git (master) by Martin KaFai Lau <[email protected]>:

Hello:

This series was applied to bpf/bpf-next.git (master) by Martin KaFai Lau <[email protected]>:

Quoted 7 lines · On Wed, 23 Aug 2023 17:00:15 -0700 you wrote:

It seems like it was forgotten to add uprobe_multi binary to .gitignore. Fix this trivial omission.

---
 tools/testing/selftests/bpf/.gitignore | 1 +
 1 file changed, 1 insertion(+)

Here is the summary with links:
- [bpf-next,1/2] selftests/bpf: add uprobe_multi test binary to .gitignore

    https://git.kernel.org/bpf/bpf-next/c/a182e64147f7
  - [bpf-next,2/2] libbpf: fix signedness determination in CO-RE relo handling logic
    https://git.kernel.org/bpf/bpf-next/c/f3bdb54f09ab

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Acked-by on v1 1/2
#5 lore raw
In reply to Andrii Nakryiko
Quoted 4 lines · Andrii Nakryiko

It seems like it was forgotten to add uprobe_multi binary to .gitignore. Fix this trivial omission.

thanks,
jirka

Quoted 20 lines
---
 tools/testing/selftests/bpf/.gitignore | 1 +
 1 file changed, 1 insertion(+)
tools/testing/selftests/bpf/.gitignore +1 -0
index 110518ba4804..f1aebabfb017 100644
@@ -44,6 +44,7 @@ test_cpp
 /bench
 /veristat
 /sign-file
+/uprobe_multi
 *.ko
 *.tmp
 xskxceiver
Signature · 1 line
2.34.1