Skip to contentSkip to conversation

arm: Remove nokia_rx51 board

PATCH New Tom Rini 7 participants 29 messages May 19, 2021 – Jun 17, 2021

Subsystems (5)
lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 arm: Remove nokia_rx51 board

This board has not been converted to CONFIG_DM_USB by the deadline. Remove it.

---
I assume you'll be trying to fix this so I've not removed all of the test related scripts.

---
 .azure-pipelines.yml              |  13 -
 .gitlab-ci.yml                    |   7 -
 arch/arm/mach-omap2/omap3/Kconfig |   4 -
 board/nokia/rx51/Kconfig          |  12 -
 board/nokia/rx51/MAINTAINERS      |   8 -
 board/nokia/rx51/Makefile         |   7 -
 board/nokia/rx51/lowlevel_init.S  | 196 --------
 board/nokia/rx51/rx51.c           | 724 ------------------------------
 board/nokia/rx51/tag_omap.h       | 294 ------------
 configs/nokia_rx51_defconfig      |  69 ---
 doc/README.nokia_rx51             |  94 ----
 include/configs/nokia_rx51.h      | 249 ----------
 test/nokia_rx51_test.sh           | 296 ------------
 13 files changed, 1973 deletions(-)
 delete mode 100644 board/nokia/rx51/Kconfig
 delete mode 100644 board/nokia/rx51/MAINTAINERS
 delete mode 100644 board/nokia/rx51/Makefile
 delete mode 100644 board/nokia/rx51/lowlevel_init.S
 delete mode 100644 board/nokia/rx51/rx51.c
 delete mode 100644 board/nokia/rx51/tag_omap.h
 delete mode 100644 configs/nokia_rx51_defconfig
 delete mode 100644 doc/README.nokia_rx51
 delete mode 100644 include/configs/nokia_rx51.h
 delete mode 100755 test/nokia_rx51_test.sh
.azure-pipelines.yml +0 -13
index 438139660219..90d5e4dc7244 100644
@@ -160,19 +160,6 @@ jobs:
           # seems to hang forever with pre-configured "container" environment
           docker run -v $PWD:$(work_dir) $(ci_runner_image) /bin/bash $(work_dir)/build.sh
 
-  - job: nokia_rx51_test
-    displayName: 'Run tests for Nokia RX-51 (aka N900)'
-    pool:
-      vmImage: $(ubuntu_vm)
-    container:
-      image: $(ci_runner_image)
-      options: $(container_option)
-    steps:
-      - script: |
-          ./tools/buildman/buildman --fetch-arch arm
-          export PATH=~/.buildman-toolchains/gcc-9.2.0-nolibc/arm-linux-gnueabi/bin/:$PATH
-          test/nokia_rx51_test.sh
-
   - job: test_py
     displayName: 'test.py'
     pool:
.gitlab-ci.yml +0 -7
index 5bf6f151b4fc..95aacdd9d74d 100644
@@ -163,13 +163,6 @@ Run binman, buildman, dtoc, Kconfig and patman testsuites:
       ./tools/patman/patman test;
       make testconfig
 
-Run tests for Nokia RX-51 (aka N900):
-  stage: testsuites
-  script:
-    - ./tools/buildman/buildman --fetch-arch arm;
-      export PATH=~/.buildman-toolchains/gcc-9.2.0-nolibc/arm-linux-gnueabi/bin/:$PATH;
-      test/nokia_rx51_test.sh
-
 # Test sandbox with test.py
 sandbox test.py:
   variables:
arch/arm/mach-omap2/omap3/Kconfig +0 -4
index 81c898b66e34..3c67a334d81c 100644
@@ -105,9 +105,6 @@ config TARGET_OMAP3_LOGIC
 	select OMAP3_GPIO_6
 	imply CMD_DM
 
-config TARGET_NOKIA_RX51
-	bool "Nokia RX51"
-
 config TARGET_TAO3530
 	bool "TAO3530"
 	select OMAP3_GPIO_2
@@ -160,7 +157,6 @@ source "board/timll/devkit8000/Kconfig"
 source "board/ti/evm/Kconfig"
 source "board/isee/igep00x0/Kconfig"
 source "board/logicpd/omap3som/Kconfig"
-source "board/nokia/rx51/Kconfig"
 source "board/lg/sniper/Kconfig"
 
 endif
board/nokia/rx51/Kconfig deleted +0 -12
deleted file mode 100644
index ec6a571a2263..000000000000
@@ -1,12 +0,0 @@
-if TARGET_NOKIA_RX51
-
-config SYS_BOARD
-	default "rx51"
-
-config SYS_VENDOR
-	default "nokia"
-
-config SYS_CONFIG_NAME
-	default "nokia_rx51"
-
-endif
board/nokia/rx51/MAINTAINERS deleted +0 -8
deleted file mode 100644
index 58b16bf9a95c..000000000000
@@ -1,8 +0,0 @@
-RX51 BOARD
-M:	Pali Roh?r <[email protected]>
-S:	Maintained
-F:	board/nokia/rx51/
-F:	include/configs/nokia_rx51.h
-F:	configs/nokia_rx51_defconfig
-F:	doc/README.nokia_rx51
-F:	test/nokia_rx51_test.sh
board/nokia/rx51/Makefile deleted +0 -7
deleted file mode 100644
index 842f9e6a650e..000000000000
@@ -1,7 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0+
-#
-# (C) Copyright 2000, 2001, 2002
-# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
-
-obj-y := rx51.o
-obj-y += lowlevel_init.o
board/nokia/rx51/lowlevel_init.S deleted +0 -196

196 lines not on this page · raw message

board/nokia/rx51/rx51.c deleted +0 -724

724 lines not on this page · raw message

board/nokia/rx51/tag_omap.h deleted +0 -294

294 lines not on this page · raw message

configs/nokia_rx51_defconfig deleted +0 -69

69 lines not on this page · raw message

doc/README.nokia_rx51 deleted +0 -94

94 lines not on this page · raw message

include/configs/nokia_rx51.h deleted +0 -249

249 lines not on this page · raw message

test/nokia_rx51_test.sh deleted +0 -296

296 lines not on this page · raw message

Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 arm: Remove nokia_rx51 board

Quoted 2 lines · On Tuesday 18 May 2021 21:26:40 Tom Rini wrote:

This board has not been converted to CONFIG_DM_USB by the deadline. Remove it.

I'm very disappointed that you want to remove Nokia N900 from U-Boot.

I was waiting waiting half of year because other developers did not react to issues which were introduced and neither to patches which I sent (+ trying to remind open issues). And also I was waiting another half of year until other N900 related patches were merged. So the whole slowdown was not caused by me, why it is taking so long.

Now there is still one N900 DM related patch waiting for review. I'm converting code step by step.

So the ball is not on my side.

Quoted 30 lines

---
I assume you'll be trying to fix this so I've not removed all of the test related scripts.

---
 .azure-pipelines.yml              |  13 -
 .gitlab-ci.yml                    |   7 -
 arch/arm/mach-omap2/omap3/Kconfig |   4 -
 board/nokia/rx51/Kconfig          |  12 -
 board/nokia/rx51/MAINTAINERS      |   8 -
 board/nokia/rx51/Makefile         |   7 -
 board/nokia/rx51/lowlevel_init.S  | 196 --------
 board/nokia/rx51/rx51.c           | 724 ------------------------------
 board/nokia/rx51/tag_omap.h       | 294 ------------
 configs/nokia_rx51_defconfig      |  69 ---
 doc/README.nokia_rx51             |  94 ----
 include/configs/nokia_rx51.h      | 249 ----------
 test/nokia_rx51_test.sh           | 296 ------------
 13 files changed, 1973 deletions(-)
 delete mode 100644 board/nokia/rx51/Kconfig
 delete mode 100644 board/nokia/rx51/MAINTAINERS
 delete mode 100644 board/nokia/rx51/Makefile
 delete mode 100644 board/nokia/rx51/lowlevel_init.S
 delete mode 100644 board/nokia/rx51/rx51.c
 delete mode 100644 board/nokia/rx51/tag_omap.h
 delete mode 100644 configs/nokia_rx51_defconfig
 delete mode 100644 doc/README.nokia_rx51
 delete mode 100644 include/configs/nokia_rx51.h
 delete mode 100755 test/nokia_rx51_test.sh
#2 lore raw

PATCH 1/1 arm: Remove nokia_rx51 board

Hello Pali,
Is there some wiki page on how to flash u-boot and Linux to N900 (JTAG, UART, etc.)?

I have this device and would like to play with that.

19.05.21 16:27, Pali Roh?r ????:

Quoted 46 lines · On Tuesday 18 May 2021 21:26:40 Tom Rini wrote:
Quoted 2 lines

This board has not been converted to CONFIG_DM_USB by the deadline. Remove it.

I'm very disappointed that you want to remove Nokia N900 from U-Boot.

I was waiting waiting half of year because other developers did not react to issues which were introduced and neither to patches which I sent (+ trying to remind open issues). And also I was waiting another half of year until other N900 related patches were merged. So the whole slowdown was not caused by me, why it is taking so long.

Now there is still one N900 DM related patch waiting for review. I'm converting code step by step.

So the ball is not on my side.

Quoted 30 lines

---
I assume you'll be trying to fix this so I've not removed all of the test related scripts.

---
 .azure-pipelines.yml              |  13 -
 .gitlab-ci.yml                    |   7 -
 arch/arm/mach-omap2/omap3/Kconfig |   4 -
 board/nokia/rx51/Kconfig          |  12 -
 board/nokia/rx51/MAINTAINERS      |   8 -
 board/nokia/rx51/Makefile         |   7 -
 board/nokia/rx51/lowlevel_init.S  | 196 --------
 board/nokia/rx51/rx51.c           | 724 ------------------------------
 board/nokia/rx51/tag_omap.h       | 294 ------------
 configs/nokia_rx51_defconfig      |  69 ---
 doc/README.nokia_rx51             |  94 ----
 include/configs/nokia_rx51.h      | 249 ----------
 test/nokia_rx51_test.sh           | 296 ------------
 13 files changed, 1973 deletions(-)
 delete mode 100644 board/nokia/rx51/Kconfig
 delete mode 100644 board/nokia/rx51/MAINTAINERS
 delete mode 100644 board/nokia/rx51/Makefile
 delete mode 100644 board/nokia/rx51/lowlevel_init.S
 delete mode 100644 board/nokia/rx51/rx51.c
 delete mode 100644 board/nokia/rx51/tag_omap.h
 delete mode 100644 configs/nokia_rx51_defconfig
 delete mode 100644 doc/README.nokia_rx51
 delete mode 100644 include/configs/nokia_rx51.h
 delete mode 100755 test/nokia_rx51_test.sh
#3 lore raw

PATCH 1/1 arm: Remove nokia_rx51 board

Quoted 3 lines · On Wednesday 19 May 2021 17:27:32 Oleh Kravchenko wrote:

Hello Pali,
Is there some wiki page on how to flash u-boot and Linux to N900 (JTAG, UART, etc.)?

Flashing UART or JTAG could be possible with proprietary Nokia flasher. But there are just very few people with UART access to Nokia N900 so I'm not sure if somebody has some guideline for UART and flashing.

What is working fine and is heavily tested is booting or flashing via USB. Some information is in doc/README.nokia_rx51 file, other in 0xFFFF manpage and I was planning to send a patch with doc update...

doc/README.nokia_rx51 +30 -0
index 84d1912ddd2b..9bead311fdf8 100644
@@ -21,6 +21,36 @@ called u-boot-gen-combined. It is available in following repository:
 
   https://github.com/pali/u-boot-maemo
 
+Flashed image must start with 2 kB "NOLO!img" header which contains size of
+the image. Header consist of bytes "NOLO!img\x02\x00\x00\x00\x00\x00\x00\x00"
+followed by 4 byte little endian size of the image and rest of the 2 kB header
+are just zero bytes.
+
+Nokia proprietary flasher and also open source 0xFFFF flasher automatically
+prepend required "NOLO!img" header and both applications expect that image
+does not contain "NOLO!img" header. Adding "NOLO!img" header is required
+only in case using "nandwrite" tool for flashing.
+
+Open source 0xFFFF flasher is available in following repository:
+
+  https://github.com/pali/0xFFFF
+
+It is possible to load u-boot.bin via USB to N900 RAM and boot it without
+need to flashing it. Via 0xFFFF running at host PC it is done:
+
+  0xFFFF -m u-boot.bin -l -b
+
+0xFFFF support also flashing kernel image either via USB or directly on
+N900 device. Flashing u-boot/kernel/combined image is done as:
+
+  0xFFFF -m combined.bin -f
+
+Via 0xFFFF is possible to generate also standard flashable image in Nokia
+FIASCO format which contains metadata information like device identification
+(RX-51) and version string (v2021.04):
+
+  0xFFFF -m RX-51:v2021.04:kernel:u-boot.bin -g u-boot.fiasco
+
 There is support for hardware watchdog. Hardware watchdog is started by
 NOLO so u-boot must kick watchdog to prevent reboot device (but not very
 often, max every 2 seconds). There is also support for framebuffer display
Quoted 1 line

I have this device and would like to play with that.

author
#4 lore raw

PATCH 1/1 arm: Remove nokia_rx51 board

In reply to Pali Rohár
Quoted 12 lines · Pali Roh?r
Quoted 2 lines · On Tuesday 18 May 2021 21:26:40 Tom Rini wrote:

This board has not been converted to CONFIG_DM_USB by the deadline. Remove it.

I'm very disappointed that you want to remove Nokia N900 from U-Boot.

I was waiting waiting half of year because other developers did not react to issues which were introduced and neither to patches which I sent (+ trying to remind open issues). And also I was waiting another half of year until other N900 related patches were merged. So the whole slowdown was not caused by me, why it is taking so long.

Quoted 4 lines

Now there is still one N900 DM related patch waiting for review. I'm converting code step by step.

So the ball is not on my side.

So, what patch(es) need to be applied to get DM_USB enabled? Thanks.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210519/e9410c97/attachment.sig>
author
#5 lore raw
Quoted 14 lines · Tom Rini
Quoted 12 lines · Pali Rohár
Quoted 2 lines · On Tuesday 18 May 2021 21:26:40 Tom Rini wrote:

This board has not been converted to CONFIG_DM_USB by the deadline. Remove it.

I'm very disappointed that you want to remove Nokia N900 from U-Boot.

I was waiting waiting half of year because other developers did not react to issues which were introduced and neither to patches which I sent (+ trying to remind open issues). And also I was waiting another half of year until other N900 related patches were merged. So the whole slowdown was not caused by me, why it is taking so long.

Quoted 6 lines
Quoted 4 lines

Now there is still one N900 DM related patch waiting for review. I'm converting code step by step.

So the ball is not on my side.

So, what patch(es) need to be applied to get DM_USB enabled? Thanks.

I don't see any open patches from you that look related to enabling DM_USB on the platform. If you want to disable USB on the platform for now instead, that's fine too.

Signature · 1 line
Tom
#6 lore raw
Quoted 18 lines · On Friday 21 May 2021 10:44:18 Tom Rini wrote:
Quoted 17 lines · Tom Rini
Quoted 15 lines · Pali Rohár
Quoted 2 lines · On Tuesday 18 May 2021 21:26:40 Tom Rini wrote:

This board has not been converted to CONFIG_DM_USB by the deadline. Remove it.

I'm very disappointed that you want to remove Nokia N900 from U-Boot.

I was waiting waiting half of year because other developers did not react to issues which were introduced and neither to patches which I sent (+ trying to remind open issues). And also I was waiting another half of year until other N900 related patches were merged. So the whole slowdown was not caused by me, why it is taking so long.

Now there is still one N900 DM related patch waiting for review. I'm converting code step by step.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

So the ball is not on my side.

So, what patch(es) need to be applied to get DM_USB enabled? Thanks.

I don't see any open patches from you that look related to enabling DM_USB on the platform. If you want to disable USB on the platform for now instead, that's fine too.

I wanted to look at next DM step -- USB -- after current DM step watchdog is finished. But patch for watchdog is still waiting for review:

http://patchwork.ozlabs.org/project/uboot/patch/[email protected]/

Due to big chance of diff conflicts between these board patches, I do not want to have more than one part of code in "in progress" state.

author
#7 lore raw
Quoted 27 lines · Pali Rohár
Quoted 18 lines · On Friday 21 May 2021 10:44:18 Tom Rini wrote:
Quoted 17 lines · Tom Rini
Quoted 15 lines · Pali Rohár
Quoted 2 lines · On Tuesday 18 May 2021 21:26:40 Tom Rini wrote:

This board has not been converted to CONFIG_DM_USB by the deadline. Remove it.

I'm very disappointed that you want to remove Nokia N900 from U-Boot.

I was waiting waiting half of year because other developers did not react to issues which were introduced and neither to patches which I sent (+ trying to remind open issues). And also I was waiting another half of year until other N900 related patches were merged. So the whole slowdown was not caused by me, why it is taking so long.

Now there is still one N900 DM related patch waiting for review. I'm converting code step by step.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

So the ball is not on my side.

So, what patch(es) need to be applied to get DM_USB enabled? Thanks.

I don't see any open patches from you that look related to enabling DM_USB on the platform. If you want to disable USB on the platform for now instead, that's fine too.

Quoted 8 lines

I wanted to look at next DM step -- USB -- after current DM step watchdog is finished. But patch for watchdog is still waiting for review:

http://patchwork.ozlabs.org/project/uboot/patch/[email protected]/

Due to big chance of diff conflicts between these board patches, I do not want to have more than one part of code in "in progress" state.

The watchdog patch is blocked on LTO, which I will grab for this current release, but also has a deadline of v2019.10 and USB is v2019.07, so that's backwards.

Please work on a DM_USB / OF_CONTROL (as USB requires this) patch on top of the WDT one which looks fine and hasn't been merged due to the LTO series needing to come in first. I'll drop this part from my full DM_USB series posting. Thanks!

Signature · 1 line
Tom
#8 lore raw
In reply to Pali Rohár

Hi,

Quoted 19 lines · Pali Rohár
Quoted 18 lines · On Friday 21 May 2021 10:44:18 Tom Rini wrote:
Quoted 17 lines · Tom Rini
Quoted 15 lines · Pali Rohár
Quoted 2 lines · On Tuesday 18 May 2021 21:26:40 Tom Rini wrote:

This board has not been converted to CONFIG_DM_USB by the deadline. Remove it.

I'm very disappointed that you want to remove Nokia N900 from U-Boot.

I was waiting waiting half of year because other developers did not react to issues which were introduced and neither to patches which I sent (+ trying to remind open issues). And also I was waiting another half of year until other N900 related patches were merged. So the whole slowdown was not caused by me, why it is taking so long.

Now there is still one N900 DM related patch waiting for review. I'm converting code step by step.

Quoted 8 lines
Quoted 7 lines
Quoted 3 lines
Quoted 1 line

So the ball is not on my side.

So, what patch(es) need to be applied to get DM_USB enabled? Thanks.

I don't see any open patches from you that look related to enabling DM_USB on the platform. If you want to disable USB on the platform for now instead, that's fine too.

I tried to migrate the latest master to DM_USB, but unfortunately the results are pretty much sad - adding OF_CONTROL (which is a prerequisite to have DM_USB IIUC) and OF_BOARD (so binary to be compiled), adds ~100k to the size of the u-boot binary, so it becomes 370284 bytes. Given that we have less than 256k of storage space for the u-boot, the produced binary cannot be used on n900 the same way current (no DM_USB) binary is used.

As I see it, there are not much options left - u-boot on N900 is not SPL, so we can't use OF_PLATDATA, which in turn always links libfdt. Also, if I read the code (usb-uclass.c) correctly, enabling DM_USB requires the board to be converted to DT and this is way bigger change.

Please advice on how to proceed.

Quoted 8 lines

I wanted to look at next DM step -- USB -- after current DM step watchdog is finished. But patch for watchdog is still waiting for review:

http://patchwork.ozlabs.org/project/uboot/patch/[email protected]/

Due to big chance of diff conflicts between these board patches, I do not want to have more than one part of code in "in progress" state.

Regards,
Ivo

author
#9 lore raw
Quoted 38 lines · Ivaylo Dimitrov

Hi,

Quoted 19 lines · Pali Rohár
Quoted 18 lines · On Friday 21 May 2021 10:44:18 Tom Rini wrote:
Quoted 17 lines · Tom Rini
Quoted 15 lines · Pali Rohár
Quoted 2 lines · On Tuesday 18 May 2021 21:26:40 Tom Rini wrote:

This board has not been converted to CONFIG_DM_USB by the deadline. Remove it.

I'm very disappointed that you want to remove Nokia N900 from U-Boot.

I was waiting waiting half of year because other developers did not react to issues which were introduced and neither to patches which I sent (+ trying to remind open issues). And also I was waiting another half of year until other N900 related patches were merged. So the whole slowdown was not caused by me, why it is taking so long.

Now there is still one N900 DM related patch waiting for review. I'm converting code step by step.

Quoted 8 lines
Quoted 7 lines
Quoted 3 lines
Quoted 1 line

So the ball is not on my side.

So, what patch(es) need to be applied to get DM_USB enabled? Thanks.

I don't see any open patches from you that look related to enabling DM_USB on the platform. If you want to disable USB on the platform for now instead, that's fine too.

I tried to migrate the latest master to DM_USB, but unfortunately the results are pretty much sad - adding OF_CONTROL (which is a prerequisite to have DM_USB IIUC) and OF_BOARD (so binary to be compiled), adds ~100k to the size of the u-boot binary, so it becomes 370284 bytes. Given that we have less than 256k of storage space for the u-boot, the produced binary cannot be used on n900 the same way current (no DM_USB) binary is used.

Quoted 6 lines

As I see it, there are not much options left - u-boot on N900 is not SPL, so we can't use OF_PLATDATA, which in turn always links libfdt. Also, if I read the code (usb-uclass.c) correctly, enabling DM_USB requires the board to be converted to DT and this is way bigger change.

Please advice on how to proceed.

Please post your WIP patches, thanks.

Signature · 1 line
Tom
#10 lore raw

Hi,

Quoted 39 lines · Tom Rini
Quoted 38 lines · Ivaylo Dimitrov

Hi,

Quoted 19 lines · Pali Rohár
Quoted 18 lines · On Friday 21 May 2021 10:44:18 Tom Rini wrote:
Quoted 17 lines · Tom Rini
Quoted 15 lines · Pali Rohár
Quoted 2 lines · On Tuesday 18 May 2021 21:26:40 Tom Rini wrote:

This board has not been converted to CONFIG_DM_USB by the deadline. Remove it.

I'm very disappointed that you want to remove Nokia N900 from U-Boot.

I was waiting waiting half of year because other developers did not react to issues which were introduced and neither to patches which I sent (+ trying to remind open issues). And also I was waiting another half of year until other N900 related patches were merged. So the whole slowdown was not caused by me, why it is taking so long.

Now there is still one N900 DM related patch waiting for review. I'm converting code step by step.

Quoted 8 lines
Quoted 7 lines
Quoted 3 lines
Quoted 1 line

So the ball is not on my side.

So, what patch(es) need to be applied to get DM_USB enabled? Thanks.

I don't see any open patches from you that look related to enabling DM_USB on the platform. If you want to disable USB on the platform for now instead, that's fine too.

I tried to migrate the latest master to DM_USB, but unfortunately the results are pretty much sad - adding OF_CONTROL (which is a prerequisite to have DM_USB IIUC) and OF_BOARD (so binary to be compiled), adds ~100k to the size of the u-boot binary, so it becomes 370284 bytes. Given that we have less than 256k of storage space for the u-boot, the produced binary cannot be used on n900 the same way current (no DM_USB) binary is used.

Quoted 9 lines
Quoted 6 lines

As I see it, there are not much options left - u-boot on N900 is not SPL, so we can't use OF_PLATDATA, which in turn always links libfdt. Also, if I read the code (usb-uclass.c) correctly, enabling DM_USB requires the board to be converted to DT and this is way bigger change.

Please advice on how to proceed.

Please post your WIP patches, thanks.

Sorry, I am not sure I understand what patches you want me to post:

WDT patch has already been sent couple of months ago - https://lists.denx.de/pipermail/u-boot/2021-March/443868.html
Do you want it to be rebased and resend?

DM_USB, I just started writing one and I immediately hit the OF_CONTROL requirement. Enabling OF_CONTROL requires a full blown migration to DT, which is a huge task and not really equal to "Please update the board to use CONFIG_DM_USB...". Without OF_CONTROL, I simply get link failures:

/usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld: /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld: DWARF error: could not find abbrev number 3998 /tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_child_post_bind':
<artificial>:(.text+0x5672): undefined reference to `ofnode_read_u32_default'
/usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld: <artificial>:(.text+0x568c): undefined reference to ofnode_read_u32_default' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld: /tmp/cc0BOqms.ltrans0.ltrans.o: in function usb_scan_device':
<artificial>:(.text+0x6c84): undefined reference to `ofnode_first_subnode'
/usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld: <artificial>:(.text+0x6c96): undefined reference to ofnode_read_u32' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld: <artificial>:(.text+0x6ca4): undefined reference to ofnode_next_subnode' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld: /tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb+0x8): undefined reference to dm_scan_fdt_dev' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld: /tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb_hub+0x8): undefined reference to dm_scan_fdt_dev'

Fixing those requires enabling of OF_CONTROL and this in turn means the board must be migrated to DT, unless I am missing something. That's why my "please advice..." stance.

Thanks,
Ivo

#11 lore raw
Quoted 42 lines · Ivaylo Dimitrov

Hi,

Quoted 38 lines · Tom Rini
Quoted 37 lines · Ivaylo Dimitrov

Hi,

Quoted 19 lines · Pali Rohár
Quoted 18 lines · On Friday 21 May 2021 10:44:18 Tom Rini wrote:
Quoted 17 lines · Tom Rini
Quoted 15 lines · Pali Rohár
Quoted 2 lines · On Tuesday 18 May 2021 21:26:40 Tom Rini wrote:

This board has not been converted to CONFIG_DM_USB by the deadline. Remove it.

I'm very disappointed that you want to remove Nokia N900 from U-Boot.

I was waiting waiting half of year because other developers did not react to issues which were introduced and neither to patches which I sent (+ trying to remind open issues). And also I was waiting another half of year until other N900 related patches were merged. So the whole slowdown was not caused by me, why it is taking so long.

Now there is still one N900 DM related patch waiting for review. I'm converting code step by step.

Quoted 8 lines
Quoted 7 lines
Quoted 3 lines
Quoted 1 line

So the ball is not on my side.

So, what patch(es) need to be applied to get DM_USB enabled? Thanks.

I don't see any open patches from you that look related to enabling DM_USB on the platform. If you want to disable USB on the platform for now instead, that's fine too.

I tried to migrate the latest master to DM_USB, but unfortunately the results are pretty much sad - adding OF_CONTROL (which is a prerequisite to have DM_USB IIUC) and OF_BOARD (so binary to be compiled), adds ~100k to the size of the u-boot binary, so it becomes 370284 bytes. Given that we have less than 256k of storage space for the u-boot, the produced binary cannot be used on n900 the same way current (no DM_USB) binary is used.

Have you experimented with enabling LTO? I was successful in enabling LTO on an OMAP3530 and a DM3730 which really helped reduce the code size and I didn't notice any obvious regressions.

adam

Quoted 51 lines
Quoted 10 lines
Quoted 7 lines

As I see it, there are not much options left - u-boot on N900 is not SPL, so we can't use OF_PLATDATA, which in turn always links libfdt. Also, if I read the code (usb-uclass.c) correctly, enabling DM_USB requires the board to be converted to DT and this is way bigger change.

Please advice on how to proceed.

Please post your WIP patches, thanks.

Sorry, I am not sure I understand what patches you want me to post:

WDT patch has already been sent couple of months ago -
https://lists.denx.de/pipermail/u-boot/2021-March/443868.html
Do you want it to be rebased and resend?

DM_USB, I just started writing one and I immediately hit the OF_CONTROL requirement. Enabling OF_CONTROL requires a full blown migration to DT, which is a huge task and not really equal to "Please update the board to use CONFIG_DM_USB...". Without OF_CONTROL, I simply get link failures:

/usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
DWARF error: could not find abbrev number 3998 /tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_child_post_bind':
<artificial>:(.text+0x5672): undefined reference to `ofnode_read_u32_default' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x568c): undefined reference to `ofnode_read_u32_default' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_scan_device':
<artificial>:(.text+0x6c84): undefined reference to `ofnode_first_subnode' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x6c96): undefined reference to `ofnode_read_u32' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x6ca4): undefined reference to `ofnode_next_subnode' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb+0x8):
undefined reference to `dm_scan_fdt_dev' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb_hub+0x8):
undefined reference to `dm_scan_fdt_dev'

Fixing those requires enabling of OF_CONTROL and this in turn means the board must be migrated to DT, unless I am missing something. That's why my "please advice..." stance.

Thanks,
Ivo

#12 lore raw
Quoted 3 lines · On Wednesday 16 June 2021 06:52:30 Adam Ford wrote:

Have you experimented with enabling LTO? I was successful in enabling LTO on an OMAP3530 and a DM3730 which really helped reduce the code size and I didn't notice any obvious regressions.

Nokia N900 is one of the board where LTO was tested and is enabled.

author
#13 lore raw
In reply to Ivaylo Dimitrov
Quoted 86 lines · Ivaylo Dimitrov

Hi,

Quoted 39 lines · Tom Rini
Quoted 38 lines · Ivaylo Dimitrov

Hi,

Quoted 19 lines · Pali Rohár
Quoted 18 lines · On Friday 21 May 2021 10:44:18 Tom Rini wrote:
Quoted 17 lines · Tom Rini
Quoted 15 lines · Pali Rohár
Quoted 2 lines · On Tuesday 18 May 2021 21:26:40 Tom Rini wrote:

This board has not been converted to CONFIG_DM_USB by the deadline. Remove it.

I'm very disappointed that you want to remove Nokia N900 from U-Boot.

I was waiting waiting half of year because other developers did not react to issues which were introduced and neither to patches which I sent (+ trying to remind open issues). And also I was waiting another half of year until other N900 related patches were merged. So the whole slowdown was not caused by me, why it is taking so long.

Now there is still one N900 DM related patch waiting for review. I'm converting code step by step.

Quoted 8 lines
Quoted 7 lines
Quoted 3 lines
Quoted 1 line

So the ball is not on my side.

So, what patch(es) need to be applied to get DM_USB enabled? Thanks.

I don't see any open patches from you that look related to enabling DM_USB on the platform. If you want to disable USB on the platform for now instead, that's fine too.

I tried to migrate the latest master to DM_USB, but unfortunately the results are pretty much sad - adding OF_CONTROL (which is a prerequisite to have DM_USB IIUC) and OF_BOARD (so binary to be compiled), adds ~100k to the size of the u-boot binary, so it becomes 370284 bytes. Given that we have less than 256k of storage space for the u-boot, the produced binary cannot be used on n900 the same way current (no DM_USB) binary is used.

Quoted 9 lines
Quoted 6 lines

As I see it, there are not much options left - u-boot on N900 is not SPL, so we can't use OF_PLATDATA, which in turn always links libfdt. Also, if I read the code (usb-uclass.c) correctly, enabling DM_USB requires the board to be converted to DT and this is way bigger change.

Please advice on how to proceed.

Please post your WIP patches, thanks.

Sorry, I am not sure I understand what patches you want me to post:

WDT patch has already been sent couple of months ago -
https://lists.denx.de/pipermail/u-boot/2021-March/443868.html
Do you want it to be rebased and resend?

DM_USB, I just started writing one and I immediately hit the OF_CONTROL requirement. Enabling OF_CONTROL requires a full blown migration to DT, which is a huge task and not really equal to "Please update the board to use CONFIG_DM_USB...". Without OF_CONTROL, I simply get link failures:

/usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
DWARF error: could not find abbrev number 3998 /tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_child_post_bind':
<artificial>:(.text+0x5672): undefined reference to `ofnode_read_u32_default' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x568c): undefined reference to `ofnode_read_u32_default' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_scan_device':
<artificial>:(.text+0x6c84): undefined reference to `ofnode_first_subnode' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x6c96): undefined reference to `ofnode_read_u32' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x6ca4): undefined reference to `ofnode_next_subnode' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb+0x8):
undefined reference to `dm_scan_fdt_dev' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb_hub+0x8):
undefined reference to `dm_scan_fdt_dev'

Quoted 3 lines

Fixing those requires enabling of OF_CONTROL and this in turn means the board must be migrated to DT, unless I am missing something. That's why my "please advice..." stance.

Please post the patches that bring you to the above link errors, yes, thanks.

Signature · 1 line
Tom
author
#14 lore raw
Quoted 87 lines · Tom Rini
Quoted 86 lines · Ivaylo Dimitrov

Hi,

Quoted 39 lines · Tom Rini
Quoted 38 lines · Ivaylo Dimitrov

Hi,

Quoted 19 lines · Pali Rohár
Quoted 18 lines · On Friday 21 May 2021 10:44:18 Tom Rini wrote:
Quoted 17 lines · Tom Rini
Quoted 15 lines · Pali Rohár
Quoted 2 lines · On Tuesday 18 May 2021 21:26:40 Tom Rini wrote:

This board has not been converted to CONFIG_DM_USB by the deadline. Remove it.

I'm very disappointed that you want to remove Nokia N900 from U-Boot.

I was waiting waiting half of year because other developers did not react to issues which were introduced and neither to patches which I sent (+ trying to remind open issues). And also I was waiting another half of year until other N900 related patches were merged. So the whole slowdown was not caused by me, why it is taking so long.

Now there is still one N900 DM related patch waiting for review. I'm converting code step by step.

Quoted 8 lines
Quoted 7 lines
Quoted 3 lines
Quoted 1 line

So the ball is not on my side.

So, what patch(es) need to be applied to get DM_USB enabled? Thanks.

I don't see any open patches from you that look related to enabling DM_USB on the platform. If you want to disable USB on the platform for now instead, that's fine too.

I tried to migrate the latest master to DM_USB, but unfortunately the results are pretty much sad - adding OF_CONTROL (which is a prerequisite to have DM_USB IIUC) and OF_BOARD (so binary to be compiled), adds ~100k to the size of the u-boot binary, so it becomes 370284 bytes. Given that we have less than 256k of storage space for the u-boot, the produced binary cannot be used on n900 the same way current (no DM_USB) binary is used.

Quoted 9 lines
Quoted 6 lines

As I see it, there are not much options left - u-boot on N900 is not SPL, so we can't use OF_PLATDATA, which in turn always links libfdt. Also, if I read the code (usb-uclass.c) correctly, enabling DM_USB requires the board to be converted to DT and this is way bigger change.

Please advice on how to proceed.

Please post your WIP patches, thanks.

Sorry, I am not sure I understand what patches you want me to post:

WDT patch has already been sent couple of months ago -
https://lists.denx.de/pipermail/u-boot/2021-March/443868.html
Do you want it to be rebased and resend?

DM_USB, I just started writing one and I immediately hit the OF_CONTROL requirement. Enabling OF_CONTROL requires a full blown migration to DT, which is a huge task and not really equal to "Please update the board to use CONFIG_DM_USB...". Without OF_CONTROL, I simply get link failures:

/usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
DWARF error: could not find abbrev number 3998 /tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_child_post_bind':
<artificial>:(.text+0x5672): undefined reference to `ofnode_read_u32_default' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x568c): undefined reference to `ofnode_read_u32_default' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_scan_device':
<artificial>:(.text+0x6c84): undefined reference to `ofnode_first_subnode' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x6c96): undefined reference to `ofnode_read_u32' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x6ca4): undefined reference to `ofnode_next_subnode' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb+0x8):
undefined reference to `dm_scan_fdt_dev' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb_hub+0x8):
undefined reference to `dm_scan_fdt_dev'

Quoted 6 lines
Quoted 3 lines

Fixing those requires enabling of OF_CONTROL and this in turn means the board must be migrated to DT, unless I am missing something. That's why my "please advice..." stance.

Please post the patches that bring you to the above link errors, yes, thanks.

To be clearer, finish up a patch that completes the migration but is too large to install on the hardware so that others can take a look.

Signature · 1 line
Tom
#15 lore raw

Hi,

Quoted 92 lines · Tom Rini
Quoted 91 lines · Tom Rini
Quoted 89 lines · Ivaylo Dimitrov

Hi,

Quoted 39 lines · Tom Rini
Quoted 38 lines · Ivaylo Dimitrov

Hi,

Quoted 19 lines · Pali Rohár
Quoted 18 lines · On Friday 21 May 2021 10:44:18 Tom Rini wrote:
Quoted 17 lines · Tom Rini
Quoted 15 lines · Pali Rohár
Quoted 2 lines · On Tuesday 18 May 2021 21:26:40 Tom Rini wrote:

This board has not been converted to CONFIG_DM_USB by the deadline. Remove it.

I'm very disappointed that you want to remove Nokia N900 from U-Boot.

I was waiting waiting half of year because other developers did not react to issues which were introduced and neither to patches which I sent (+ trying to remind open issues). And also I was waiting another half of year until other N900 related patches were merged. So the whole slowdown was not caused by me, why it is taking so long.

Now there is still one N900 DM related patch waiting for review. I'm converting code step by step.

Quoted 8 lines
Quoted 7 lines
Quoted 3 lines
Quoted 1 line

So the ball is not on my side.

So, what patch(es) need to be applied to get DM_USB enabled? Thanks.

I don't see any open patches from you that look related to enabling DM_USB on the platform. If you want to disable USB on the platform for now instead, that's fine too.

I tried to migrate the latest master to DM_USB, but unfortunately the results are pretty much sad - adding OF_CONTROL (which is a prerequisite to have DM_USB IIUC) and OF_BOARD (so binary to be compiled), adds ~100k to the size of the u-boot binary, so it becomes 370284 bytes. Given that we have less than 256k of storage space for the u-boot, the produced binary cannot be used on n900 the same way current (no DM_USB) binary is used.

Quoted 9 lines
Quoted 6 lines

As I see it, there are not much options left - u-boot on N900 is not SPL, so we can't use OF_PLATDATA, which in turn always links libfdt. Also, if I read the code (usb-uclass.c) correctly, enabling DM_USB requires the board to be converted to DT and this is way bigger change.

Please advice on how to proceed.

Please post your WIP patches, thanks.

Sorry, I am not sure I understand what patches you want me to post:

WDT patch has already been sent couple of months ago -
https://lists.denx.de/pipermail/u-boot/2021-March/443868.html
Do you want it to be rebased and resend?

DM_USB, I just started writing one and I immediately hit the OF_CONTROL requirement. Enabling OF_CONTROL requires a full blown migration to DT, which is a huge task and not really equal to "Please update the board to use CONFIG_DM_USB...". Without OF_CONTROL, I simply get link failures:

/usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
DWARF error: could not find abbrev number 3998 /tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_child_post_bind':
<artificial>:(.text+0x5672): undefined reference to `ofnode_read_u32_default' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x568c): undefined reference to `ofnode_read_u32_default' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_scan_device':
<artificial>:(.text+0x6c84): undefined reference to `ofnode_first_subnode' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x6c96): undefined reference to `ofnode_read_u32' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x6ca4): undefined reference to `ofnode_next_subnode' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb+0x8):
undefined reference to `dm_scan_fdt_dev' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb_hub+0x8):
undefined reference to `dm_scan_fdt_dev'

Fixing those requires enabling of OF_CONTROL and this in turn means the board must be migrated to DT, unless I am missing something. That's why my "please advice..." stance.

Quoted 6 lines
Quoted 2 lines

Please post the patches that bring you to the above link errors, yes, thanks.

To be clearer, finish up a patch that completes the migration but is too large to install on the hardware so that others can take a look.

I am not sure I understand that - a patch that completes the migration to DM_USB cannot be done ATM as the binary does not link without OF_CONTROL. And I am not going to enable OF_CONTROL as this means I will have to migrate everything to DT. That's why I enable DM_USB only - see reply to the other mail.

Thanks,
Ivo

author
#16 lore raw
Quoted 98 lines · Ivaylo Dimitrov

Hi,

Quoted 95 lines · Tom Rini
Quoted 93 lines · Tom Rini
Quoted 86 lines · Ivaylo Dimitrov

Hi,

Quoted 39 lines · Tom Rini
Quoted 38 lines · Ivaylo Dimitrov

Hi,

Quoted 19 lines · Pali Rohár
Quoted 18 lines · On Friday 21 May 2021 10:44:18 Tom Rini wrote:
Quoted 17 lines · Tom Rini
Quoted 15 lines · Pali Rohár
Quoted 2 lines · On Tuesday 18 May 2021 21:26:40 Tom Rini wrote:

This board has not been converted to CONFIG_DM_USB by the deadline. Remove it.

I'm very disappointed that you want to remove Nokia N900 from U-Boot.

I was waiting waiting half of year because other developers did not react to issues which were introduced and neither to patches which I sent (+ trying to remind open issues). And also I was waiting another half of year until other N900 related patches were merged. So the whole slowdown was not caused by me, why it is taking so long.

Now there is still one N900 DM related patch waiting for review. I'm converting code step by step.

Quoted 8 lines
Quoted 7 lines
Quoted 3 lines
Quoted 1 line

So the ball is not on my side.

So, what patch(es) need to be applied to get DM_USB enabled? Thanks.

I don't see any open patches from you that look related to enabling DM_USB on the platform. If you want to disable USB on the platform for now instead, that's fine too.

I tried to migrate the latest master to DM_USB, but unfortunately the results are pretty much sad - adding OF_CONTROL (which is a prerequisite to have DM_USB IIUC) and OF_BOARD (so binary to be compiled), adds ~100k to the size of the u-boot binary, so it becomes 370284 bytes. Given that we have less than 256k of storage space for the u-boot, the produced binary cannot be used on n900 the same way current (no DM_USB) binary is used.

Quoted 9 lines
Quoted 6 lines

As I see it, there are not much options left - u-boot on N900 is not SPL, so we can't use OF_PLATDATA, which in turn always links libfdt. Also, if I read the code (usb-uclass.c) correctly, enabling DM_USB requires the board to be converted to DT and this is way bigger change.

Please advice on how to proceed.

Please post your WIP patches, thanks.

Sorry, I am not sure I understand what patches you want me to post:

WDT patch has already been sent couple of months ago -
https://lists.denx.de/pipermail/u-boot/2021-March/443868.html
Do you want it to be rebased and resend?

DM_USB, I just started writing one and I immediately hit the OF_CONTROL requirement. Enabling OF_CONTROL requires a full blown migration to DT, which is a huge task and not really equal to "Please update the board to use CONFIG_DM_USB...". Without OF_CONTROL, I simply get link failures:

/usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
DWARF error: could not find abbrev number 3998 /tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_child_post_bind':
<artificial>:(.text+0x5672): undefined reference to `ofnode_read_u32_default' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x568c): undefined reference to `ofnode_read_u32_default' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_scan_device':
<artificial>:(.text+0x6c84): undefined reference to `ofnode_first_subnode' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x6c96): undefined reference to `ofnode_read_u32' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x6ca4): undefined reference to `ofnode_next_subnode' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb+0x8):
undefined reference to `dm_scan_fdt_dev' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb_hub+0x8):
undefined reference to `dm_scan_fdt_dev'

Quoted 3 lines

Fixing those requires enabling of OF_CONTROL and this in turn means the board must be migrated to DT, unless I am missing something. That's why my "please advice..." stance.

Please post the patches that bring you to the above link errors, yes, thanks.

Quoted 8 lines
Quoted 2 lines

To be clearer, finish up a patch that completes the migration but is too large to install on the hardware so that others can take a look.

I am not sure I understand that - a patch that completes the migration to DM_USB cannot be done ATM as the binary does not link without OF_CONTROL. And I am not going to enable OF_CONTROL as this means I will have to migrate everything to DT. That's why I enable DM_USB only - see reply to the other mail.

My advise is to provide a linkable but not runnable (or, only runnable in QEMU, the problem is the fixed layout of the actual device flash, right?) patch so that we can figure out how and what needs to be tuned where so that we can see what to do about this platform.

Signature · 1 line
Tom
#17 lore raw

Hi Tom,

Quoted 108 lines · Tom Rini
Quoted 98 lines · Ivaylo Dimitrov

Hi,

Quoted 95 lines · Tom Rini
Quoted 93 lines · Tom Rini
Quoted 86 lines · Ivaylo Dimitrov

Hi,

Quoted 39 lines · Tom Rini
Quoted 38 lines · Ivaylo Dimitrov

Hi,

Quoted 19 lines · Pali Rohár
Quoted 18 lines · On Friday 21 May 2021 10:44:18 Tom Rini wrote:
Quoted 17 lines · Tom Rini
Quoted 15 lines · Pali Rohár
Quoted 2 lines · On Tuesday 18 May 2021 21:26:40 Tom Rini wrote:

This board has not been converted to CONFIG_DM_USB by the deadline. Remove it.

I'm very disappointed that you want to remove Nokia N900 from U-Boot.

I was waiting waiting half of year because other developers did not react to issues which were introduced and neither to patches which I sent (+ trying to remind open issues). And also I was waiting another half of year until other N900 related patches were merged. So the whole slowdown was not caused by me, why it is taking so long.

Now there is still one N900 DM related patch waiting for review. I'm converting code step by step.

Quoted 8 lines
Quoted 7 lines
Quoted 3 lines
Quoted 1 line

So the ball is not on my side.

So, what patch(es) need to be applied to get DM_USB enabled? Thanks.

I don't see any open patches from you that look related to enabling DM_USB on the platform. If you want to disable USB on the platform for now instead, that's fine too.

I tried to migrate the latest master to DM_USB, but unfortunately the results are pretty much sad - adding OF_CONTROL (which is a prerequisite to have DM_USB IIUC) and OF_BOARD (so binary to be compiled), adds ~100k to the size of the u-boot binary, so it becomes 370284 bytes. Given that we have less than 256k of storage space for the u-boot, the produced binary cannot be used on n900 the same way current (no DM_USB) binary is used.

Quoted 9 lines
Quoted 6 lines

As I see it, there are not much options left - u-boot on N900 is not SPL, so we can't use OF_PLATDATA, which in turn always links libfdt. Also, if I read the code (usb-uclass.c) correctly, enabling DM_USB requires the board to be converted to DT and this is way bigger change.

Please advice on how to proceed.

Please post your WIP patches, thanks.

Sorry, I am not sure I understand what patches you want me to post:

WDT patch has already been sent couple of months ago -
https://lists.denx.de/pipermail/u-boot/2021-March/443868.html
Do you want it to be rebased and resend?

DM_USB, I just started writing one and I immediately hit the OF_CONTROL requirement. Enabling OF_CONTROL requires a full blown migration to DT, which is a huge task and not really equal to "Please update the board to use CONFIG_DM_USB...". Without OF_CONTROL, I simply get link failures:

/usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
DWARF error: could not find abbrev number 3998 /tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_child_post_bind':
<artificial>:(.text+0x5672): undefined reference to `ofnode_read_u32_default' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x568c): undefined reference to `ofnode_read_u32_default' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_scan_device':
<artificial>:(.text+0x6c84): undefined reference to `ofnode_first_subnode' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x6c96): undefined reference to `ofnode_read_u32' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x6ca4): undefined reference to `ofnode_next_subnode' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb+0x8):
undefined reference to `dm_scan_fdt_dev' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb_hub+0x8):
undefined reference to `dm_scan_fdt_dev'

Quoted 3 lines

Fixing those requires enabling of OF_CONTROL and this in turn means the board must be migrated to DT, unless I am missing something. That's why my "please advice..." stance.

Please post the patches that bring you to the above link errors, yes, thanks.

Quoted 8 lines
Quoted 2 lines

To be clearer, finish up a patch that completes the migration but is too large to install on the hardware so that others can take a look.

I am not sure I understand that - a patch that completes the migration to DM_USB cannot be done ATM as the binary does not link without OF_CONTROL. And I am not going to enable OF_CONTROL as this means I will have to migrate everything to DT. That's why I enable DM_USB only - see reply to the other mail.

Quoted 5 lines

My advise is to provide a linkable but not runnable (or, only runnable in QEMU, the problem is the fixed layout of the actual device flash, right?) patch so that we can figure out how and what needs to be tuned where so that we can see what to do about this platform.

What about the following patch (once you confirm I am on the right track, I will send a proper patch as well). Enabling thumb is a must, otherwise binary does not fit. With the below changes code compiles and runs on a real HW:

common/usb_hub.c +2 -0
index ba11a188ca..c6b042a684 100644
@@ -956,7 +956,9 @@ U_BOOT_DRIVER(usb_generic_hub) = {
 UCLASS_DRIVER(usb_hub) = {
 	.id		= UCLASS_USB_HUB,
 	.name		= "usb_hub",
+#if CONFIG_IS_ENABLED(OF_CONTROL) && !CONFIG_IS_ENABLED(OF_PLATDATA)
 	.post_bind	= dm_scan_fdt_dev,
+#endif
 	.post_probe	= usb_hub_post_probe,
 	.child_pre_probe	= usb_child_pre_probe,
 	.per_child_auto	= sizeof(struct usb_device),
configs/nokia_rx51_defconfig +5 -1
index 3548aab0e1..daaf6690ef 100644
@@ -1,5 +1,5 @@
 CONFIG_ARM=y
-# CONFIG_SYS_THUMB_BUILD is not set
+CONFIG_SYS_THUMB_BUILD=y
 CONFIG_ARCH_OMAP2PLUS=y
 CONFIG_SYS_TEXT_BASE=0x80008000
 CONFIG_NR_DRAM_BANKS=2
@@ -61,6 +61,10 @@ CONFIG_CONS_INDEX=3
 CONFIG_SYS_NS16550=y
 CONFIG_SPI=y
 CONFIG_USB=y
+CONFIG_DM_USB=y
+CONFIG_OF_LIBFDT=y
+CONFIG_OF_LIBFDT_OVERLAY=n
+CONFIG_EFI_LOADER=n
 CONFIG_USB_MUSB_UDC=y
 CONFIG_USB_OMAP3=y
 CONFIG_CFB_CONSOLE=y
drivers/core/Makefile +2 -2
index 5edd4e4135..e7213143c4 100644
@@ -2,7 +2,7 @@
 #
 # Copyright (c) 2013 Google, Inc
 
-obj-y	+= device.o fdtaddr.o lists.o root.o uclass.o util.o
+obj-y	+= device.o fdtaddr.o lists.o root.o uclass.o util.o ofnode.o
 obj-$(CONFIG_$(SPL_TPL_)ACPIGEN) += acpi.o
 obj-$(CONFIG_DEVRES) += devres.o
 obj-$(CONFIG_$(SPL_)DM_DEVICE_REMOVE)	+= device-remove.o
@@ -15,6 +15,6 @@ obj-$(CONFIG_$(SPL_)OF_LIVE) += of_access.o of_addr.o
 ifndef CONFIG_DM_DEV_READ_INLINE
 obj-$(CONFIG_OF_CONTROL) += read.o
 endif
-obj-$(CONFIG_OF_CONTROL) += of_extra.o ofnode.o read_extra.o
+obj-$(CONFIG_OF_CONTROL) += of_extra.o read_extra.o
 
 ccflags-$(CONFIG_DM_DEBUG) += -DDEBUG
drivers/usb/host/usb-uclass.c +4 -1
index e3b616c326..71dc578550 100644
@@ -770,6 +770,7 @@ int usb_detect_change(void)
 
 static int usb_child_post_bind(struct udevice *dev)
 {
+#if CONFIG_IS_ENABLED(OF_CONTROL) && !CONFIG_IS_ENABLED(OF_PLATDATA)
 	struct usb_dev_plat *plat = dev_get_parent_plat(dev);
 	int val;
 
@@ -787,7 +788,7 @@ static int usb_child_post_bind(struct udevice *dev)
 		plat->id.match_flags |= USB_DEVICE_ID_MATCH_INT_CLASS;
 		plat->id.bInterfaceClass = val;
 	}
-
+#endif
 	return 0;
 }
 
@@ -848,7 +849,9 @@ UCLASS_DRIVER(usb) = {
 	.id		= UCLASS_USB,
 	.name		= "usb",
 	.flags		= DM_UC_FLAG_SEQ_ALIAS,
+#if CONFIG_IS_ENABLED(OF_CONTROL) && !CONFIG_IS_ENABLED(OF_PLATDATA)
 	.post_bind	= dm_scan_fdt_dev,
+#endif
 	.priv_auto	= sizeof(struct usb_uclass_priv),
 	.per_child_auto	= sizeof(struct usb_device),
 	.per_device_auto	= sizeof(struct usb_bus_priv),
author
#18 lore raw
Quoted 117 lines · Ivaylo Dimitrov

Hi Tom,

Quoted 108 lines · Tom Rini
Quoted 98 lines · Ivaylo Dimitrov

Hi,

Quoted 95 lines · Tom Rini
Quoted 93 lines · Tom Rini
Quoted 86 lines · Ivaylo Dimitrov

Hi,

Quoted 39 lines · Tom Rini
Quoted 38 lines · Ivaylo Dimitrov

Hi,

Quoted 19 lines · Pali Rohár
Quoted 18 lines · On Friday 21 May 2021 10:44:18 Tom Rini wrote:
Quoted 17 lines · Tom Rini
Quoted 15 lines · Pali Rohár
Quoted 2 lines · On Tuesday 18 May 2021 21:26:40 Tom Rini wrote:

This board has not been converted to CONFIG_DM_USB by the deadline.
Remove it.

I'm very disappointed that you want to remove Nokia N900 from U-Boot.

I was waiting waiting half of year because other developers did not react to issues which were introduced and neither to patches which I sent (+ trying to remind open issues). And also I was waiting another half of year until other N900 related patches were merged. So the whole slowdown was not caused by me, why it is taking so long.

Now there is still one N900 DM related patch waiting for review. I'm converting code step by step.

Quoted 8 lines
Quoted 7 lines
Quoted 3 lines
Quoted 1 line

So the ball is not on my side.

So, what patch(es) need to be applied to get DM_USB enabled? Thanks.

I don't see any open patches from you that look related to enabling DM_USB on the platform. If you want to disable USB on the platform for now instead, that's fine too.

I tried to migrate the latest master to DM_USB, but unfortunately the results are pretty much sad - adding OF_CONTROL (which is a prerequisite to have DM_USB IIUC) and OF_BOARD (so binary to be compiled), adds ~100k to the size of the u-boot binary, so it becomes 370284 bytes. Given that we have less than 256k of storage space for the u-boot, the produced binary cannot be used on n900 the same way current (no DM_USB) binary is used.

Quoted 9 lines
Quoted 6 lines

As I see it, there are not much options left - u-boot on N900 is not SPL, so we can't use OF_PLATDATA, which in turn always links libfdt. Also, if I read the code (usb-uclass.c) correctly, enabling DM_USB requires the board to be converted to DT and this is way bigger change.

Please advice on how to proceed.

Please post your WIP patches, thanks.

Sorry, I am not sure I understand what patches you want me to post:

WDT patch has already been sent couple of months ago -
https://lists.denx.de/pipermail/u-boot/2021-March/443868.html
Do you want it to be rebased and resend?

DM_USB, I just started writing one and I immediately hit the OF_CONTROL requirement. Enabling OF_CONTROL requires a full blown migration to DT, which is a huge task and not really equal to "Please update the board to use CONFIG_DM_USB...". Without OF_CONTROL, I simply get link failures:

/usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
DWARF error: could not find abbrev number 3998 /tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_child_post_bind':
<artificial>:(.text+0x5672): undefined reference to `ofnode_read_u32_default' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x568c): undefined reference to `ofnode_read_u32_default' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_scan_device':
<artificial>:(.text+0x6c84): undefined reference to `ofnode_first_subnode' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x6c96): undefined reference to `ofnode_read_u32' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x6ca4): undefined reference to `ofnode_next_subnode' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb+0x8):
undefined reference to `dm_scan_fdt_dev' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb_hub+0x8):
undefined reference to `dm_scan_fdt_dev'

Quoted 3 lines

Fixing those requires enabling of OF_CONTROL and this in turn means the board must be migrated to DT, unless I am missing something. That's why my "please advice..." stance.

Please post the patches that bring you to the above link errors, yes, thanks.

Quoted 8 lines
Quoted 2 lines

To be clearer, finish up a patch that completes the migration but is too large to install on the hardware so that others can take a look.

I am not sure I understand that - a patch that completes the migration to DM_USB cannot be done ATM as the binary does not link without OF_CONTROL. And I am not going to enable OF_CONTROL as this means I will have to migrate everything to DT. That's why I enable DM_USB only - see reply to the other mail.

Quoted 5 lines

My advise is to provide a linkable but not runnable (or, only runnable in QEMU, the problem is the fixed layout of the actual device flash, right?) patch so that we can figure out how and what needs to be tuned where so that we can see what to do about this platform.

Quoted 4 lines

What about the following patch (once you confirm I am on the right track, I will send a proper patch as well). Enabling thumb is a must, otherwise binary does not fit. With the below changes code compiles and runs on a real HW:

Wait, why is thumb disabled? That's something I'd really like to know why on as my first guess is there's units with old enough cores that have some thumb errata maybe? For the second part, how are you binding the device? And oh, we didn't disable the EFI loader support already? Yeah, that would be another pretty easy choice to win back a bunch of space. So yes, this is certainly on the right track, thanks!

Signature · 1 line
Tom
#19 lore raw
Quoted 3 lines · On Wednesday 16 June 2021 17:12:13 Tom Rini wrote:

Wait, why is thumb disabled? That's something I'd really like to know why on as my first guess is there's units with old enough cores that have some thumb errata maybe?

IIRC we disabled at time when N900 support was merged into U-Boot (about 10 years ago) as built binary did not work on real N900 HW. Non-thumb build work fine.

I thought it was due to thumb errata but yesterday I was told that thumb errata affects running system only when virtual memory and context switches are used. And correct me if I'm wrong, but u-boot is not using virtual memory mapping and neither multiprocessing context switches.

So it looks like that at that time (10 years ago) there was another bug in u-boot which caused that thumb build was non-working.

author
#20 lore raw
Quoted 9 lines · Pali Rohár
Quoted 3 lines · On Wednesday 16 June 2021 17:12:13 Tom Rini wrote:

Wait, why is thumb disabled? That's something I'd really like to know why on as my first guess is there's units with old enough cores that have some thumb errata maybe?

IIRC we disabled at time when N900 support was merged into U-Boot (about 10 years ago) as built binary did not work on real N900 HW. Non-thumb build work fine.

Quoted 7 lines

I thought it was due to thumb errata but yesterday I was told that thumb errata affects running system only when virtual memory and context switches are used. And correct me if I'm wrong, but u-boot is not using virtual memory mapping and neither multiprocessing context switches.

So it looks like that at that time (10 years ago) there was another bug in u-boot which caused that thumb build was non-working.

Thanks for explaining, yes, we should be able to enable thumb and disable EFI and see just how close things are again to the size limit.

Oh, and we have things set such that the hooks to cause link time errors on size overflow are enabled here, right?

Signature · 1 line
Tom
#21 lore raw
Quoted 15 lines · On Wednesday 16 June 2021 17:20:20 Tom Rini wrote:
Quoted 14 lines · Pali Rohár
Quoted 3 lines · On Wednesday 16 June 2021 17:12:13 Tom Rini wrote:

Wait, why is thumb disabled? That's something I'd really like to know why on as my first guess is there's units with old enough cores that have some thumb errata maybe?

IIRC we disabled at time when N900 support was merged into U-Boot (about 10 years ago) as built binary did not work on real N900 HW. Non-thumb build work fine.

I thought it was due to thumb errata but yesterday I was told that thumb errata affects running system only when virtual memory and context switches are used. And correct me if I'm wrong, but u-boot is not using virtual memory mapping and neither multiprocessing context switches.

Quoted 4 lines
Quoted 2 lines

So it looks like that at that time (10 years ago) there was another bug in u-boot which caused that thumb build was non-working.

Thanks for explaining, yes, we should be able to enable thumb and

This needs to be tested on N900 hw if it really works.

Quoted 1 line

disable EFI and see just how close things are again to the size limit.

EFI is not used on N900 and I'm not aware why it is enabled. Maybe somebody proactively enabled it and nobody noticed? So very good candidate for immediate disabling to reduce space.

Quoted 2 lines

Oh, and we have things set such that the hooks to cause link time errors on size overflow are enabled here, right?

Seems that link time errors are not enabled. But "integration" test for N900 which is running on Azure is checking this enforcement. Just because generating final MTD image (for running test) fails.

Also you can run this test manually on local computer:

./test/nokia_rx51_test.sh

So thanks to Azure CI testing, we are sure if tests passes, N900 code is working fine (at least in qemu) and also has "correct" size.

#22 lore raw
In reply to Tom Rini
Quoted 118 lines · Tom Rini
Quoted 117 lines · Ivaylo Dimitrov

Hi Tom,

Quoted 113 lines · Tom Rini
Quoted 98 lines · Ivaylo Dimitrov

Hi,

Quoted 95 lines · Tom Rini
Quoted 93 lines · Tom Rini
Quoted 86 lines · Ivaylo Dimitrov

Hi,

Quoted 39 lines · Tom Rini
Quoted 38 lines · Ivaylo Dimitrov

Hi,

Quoted 19 lines · Pali Rohár
Quoted 18 lines · On Friday 21 May 2021 10:44:18 Tom Rini wrote:
Quoted 17 lines · Tom Rini
Quoted 15 lines · Pali Rohár

On Tuesday 18 May 2021 21:26:40 Tom Rini wrote:
This board has not been converted to CONFIG_DM_USB by the deadline.
Remove it.

I'm very disappointed that you want to remove Nokia N900 from U-Boot.

I was waiting waiting half of year because other developers did not
react to issues which were introduced and neither to patches which I
sent (+ trying to remind open issues). And also I was waiting another
half of year until other N900 related patches were merged. So the whole
slowdown was not caused by me, why it is taking so long.

Now there is still one N900 DM related patch waiting for review. I'm
converting code step by step.

Quoted 8 lines
Quoted 7 lines
Quoted 3 lines
Quoted 1 line

So the ball is not on my side.

So, what patch(es) need to be applied to get DM_USB enabled? Thanks.

I don't see any open patches from you that look related to enabling DM_USB on the platform. If you want to disable USB on the platform for now instead, that's fine too.

I tried to migrate the latest master to DM_USB, but unfortunately the results are pretty much sad - adding OF_CONTROL (which is a prerequisite to have DM_USB IIUC) and OF_BOARD (so binary to be compiled), adds ~100k to the size of the u-boot binary, so it becomes 370284 bytes. Given that we have less than 256k of storage space for the u-boot, the produced binary cannot be used on n900 the same way current (no DM_USB) binary is used.

Quoted 9 lines
Quoted 6 lines

As I see it, there are not much options left - u-boot on N900 is not SPL, so we can't use OF_PLATDATA, which in turn always links libfdt. Also, if I read the code (usb-uclass.c) correctly, enabling DM_USB requires the board to be converted to DT and this is way bigger change.

Please advice on how to proceed.

Please post your WIP patches, thanks.

Sorry, I am not sure I understand what patches you want me to post:

WDT patch has already been sent couple of months ago -
https://lists.denx.de/pipermail/u-boot/2021-March/443868.html
Do you want it to be rebased and resend?

DM_USB, I just started writing one and I immediately hit the OF_CONTROL requirement. Enabling OF_CONTROL requires a full blown migration to DT, which is a huge task and not really equal to "Please update the board to use CONFIG_DM_USB...". Without OF_CONTROL, I simply get link failures:

/usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
DWARF error: could not find abbrev number 3998 /tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_child_post_bind':
<artificial>:(.text+0x5672): undefined reference to `ofnode_read_u32_default' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x568c): undefined reference to `ofnode_read_u32_default' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_scan_device':
<artificial>:(.text+0x6c84): undefined reference to `ofnode_first_subnode' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x6c96): undefined reference to `ofnode_read_u32' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x6ca4): undefined reference to `ofnode_next_subnode' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb+0x8):
undefined reference to `dm_scan_fdt_dev' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb_hub+0x8):
undefined reference to `dm_scan_fdt_dev'

Quoted 3 lines

Fixing those requires enabling of OF_CONTROL and this in turn means the board must be migrated to DT, unless I am missing something. That's why my "please advice..." stance.

Please post the patches that bring you to the above link errors, yes, thanks.

Quoted 8 lines
Quoted 2 lines

To be clearer, finish up a patch that completes the migration but is too large to install on the hardware so that others can take a look.

I am not sure I understand that - a patch that completes the migration to DM_USB cannot be done ATM as the binary does not link without OF_CONTROL. And I am not going to enable OF_CONTROL as this means I will have to migrate everything to DT. That's why I enable DM_USB only - see reply to the other mail.

My advise is to provide a linkable but not runnable (or, only runnable in QEMU, the problem is the fixed layout of the actual device flash, right?) patch so that we can figure out how and what needs to be tuned where so that we can see what to do about this platform.

Quoted 8 lines
Quoted 4 lines

What about the following patch (once you confirm I am on the right track, I will send a proper patch as well). Enabling thumb is a must, otherwise binary does not fit. With the below changes code compiles and runs on a real HW:

Wait, why is thumb disabled? That's something I'd really like to know why on as my first guess is there's units with old enough cores that have some thumb errata maybe?

omap3 in N900 suffers from ARM errata 430973, I guess that's why -mthumb was disabled back then. I implemented N900 specific workaround to set the IBE bit in ACR in the board code, but I don't see flush BTAC/BTB being executed on context switch (if there are context switches at all). The only places I was able to find that flush BTAC/BTB instruction are on startup (cpu_init_cp15()) and cache invalidate (invalidate_icache_all()).

BTW the code in cpu_init_cp15() is buggy, as flush is executed before IBE bit in ACR is set, making that flush effectively a noop on boards where IBE bit was not set by the previous stage loader, but that's another story not affecting N900 :).

So, as soon as there are no context switches in u-boot that may land different code on a same physical address, we should be safe. Could you confirm this is the case? Is there virtual addressing? Multiple processes?

Quoted 2 lines

For the second part, how are you binding
the device? And oh, we didn't disable the EFI loader support already?

Yeah, looks like selecting libfdt automagically selects a whole bunch of other things (like CMD_FDT and OF_LIBFDT_OVERLAY)

Quoted 3 lines

Yeah, that would be another pretty easy choice to win back a bunch of space. So yes, this is certainly on the right track, thanks!

Ok, we'll send a proper patch series as soon as it is confirmed that it is safe to enable -mthumb.

In the meanwhile, could you please have a look at the WDT patch Pali posted back then?

Thanks,
Ivo

author
#23 lore raw
Quoted 137 lines · Ivaylo Dimitrov
Quoted 118 lines · Tom Rini
Quoted 117 lines · Ivaylo Dimitrov

Hi Tom,

Quoted 113 lines · Tom Rini
Quoted 98 lines · Ivaylo Dimitrov

Hi,

Quoted 95 lines · Tom Rini
Quoted 93 lines · Tom Rini
Quoted 86 lines · Ivaylo Dimitrov

Hi,

Quoted 39 lines · Tom Rini
Quoted 38 lines · Ivaylo Dimitrov

Hi,

Quoted 19 lines · Pali Rohár
Quoted 18 lines · On Friday 21 May 2021 10:44:18 Tom Rini wrote:
Quoted 17 lines · Tom Rini

On Wed, May 19, 2021 at 03:27:48PM +0200, Pali Rohár wrote:

On Tuesday 18 May 2021 21:26:40 Tom Rini wrote:
This board has not been converted to CONFIG_DM_USB by the deadline.
Remove it.

I'm very disappointed that you want to remove Nokia N900 from U-Boot.

I was waiting waiting half of year because other developers did not
react to issues which were introduced and neither to patches which I
sent (+ trying to remind open issues). And also I was waiting another
half of year until other N900 related patches were merged. So the whole
slowdown was not caused by me, why it is taking so long.

Now there is still one N900 DM related patch waiting for review. I'm
converting code step by step.

Quoted 8 lines
Quoted 7 lines
Quoted 3 lines

So the ball is not on my side.

So, what patch(es) need to be applied to get DM_USB enabled? Thanks.

I don't see any open patches from you that look related to enabling DM_USB on the platform. If you want to disable USB on the platform for now instead, that's fine too.

I tried to migrate the latest master to DM_USB, but unfortunately the results are pretty much sad - adding OF_CONTROL (which is a prerequisite to have DM_USB IIUC) and OF_BOARD (so binary to be compiled), adds ~100k to the size of the u-boot binary, so it becomes 370284 bytes. Given that we have less than 256k of storage space for the u-boot, the produced binary cannot be used on n900 the same way current (no DM_USB) binary is used.

Quoted 9 lines
Quoted 6 lines

As I see it, there are not much options left - u-boot on N900 is not SPL, so we can't use OF_PLATDATA, which in turn always links libfdt. Also, if I read the code (usb-uclass.c) correctly, enabling DM_USB requires the board to be converted to DT and this is way bigger change.

Please advice on how to proceed.

Please post your WIP patches, thanks.

Sorry, I am not sure I understand what patches you want me to post:

WDT patch has already been sent couple of months ago -
https://lists.denx.de/pipermail/u-boot/2021-March/443868.html
Do you want it to be rebased and resend?

DM_USB, I just started writing one and I immediately hit the OF_CONTROL requirement. Enabling OF_CONTROL requires a full blown migration to DT, which is a huge task and not really equal to "Please update the board to use CONFIG_DM_USB...". Without OF_CONTROL, I simply get link failures:

/usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
DWARF error: could not find abbrev number 3998 /tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_child_post_bind':
<artificial>:(.text+0x5672): undefined reference to `ofnode_read_u32_default' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x568c): undefined reference to `ofnode_read_u32_default' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_scan_device':
<artificial>:(.text+0x6c84): undefined reference to `ofnode_first_subnode' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x6c96): undefined reference to `ofnode_read_u32' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x6ca4): undefined reference to `ofnode_next_subnode' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb+0x8):
undefined reference to `dm_scan_fdt_dev' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb_hub+0x8):
undefined reference to `dm_scan_fdt_dev'

Quoted 3 lines

Fixing those requires enabling of OF_CONTROL and this in turn means the board must be migrated to DT, unless I am missing something. That's why my "please advice..." stance.

Please post the patches that bring you to the above link errors, yes, thanks.

Quoted 8 lines
Quoted 2 lines

To be clearer, finish up a patch that completes the migration but is too large to install on the hardware so that others can take a look.

I am not sure I understand that - a patch that completes the migration to DM_USB cannot be done ATM as the binary does not link without OF_CONTROL. And I am not going to enable OF_CONTROL as this means I will have to migrate everything to DT. That's why I enable DM_USB only - see reply to the other mail.

My advise is to provide a linkable but not runnable (or, only runnable in QEMU, the problem is the fixed layout of the actual device flash, right?) patch so that we can figure out how and what needs to be tuned where so that we can see what to do about this platform.

Quoted 8 lines
Quoted 4 lines

What about the following patch (once you confirm I am on the right track, I will send a proper patch as well). Enabling thumb is a must, otherwise binary does not fit. With the below changes code compiles and runs on a real HW:

Wait, why is thumb disabled? That's something I'd really like to know why on as my first guess is there's units with old enough cores that have some thumb errata maybe?

omap3 in N900 suffers from ARM errata 430973, I guess that's why -mthumb was disabled back then. I implemented N900 specific workaround to set the IBE bit in ACR in the board code, but I don't see flush BTAC/BTB being executed on context switch (if there are context switches at all). The only places I was able to find that flush BTAC/BTB instruction are on startup (cpu_init_cp15()) and cache invalidate (invalidate_icache_all()).

Quoted 4 lines

BTW the code in cpu_init_cp15() is buggy, as flush is executed before IBE bit in ACR is set, making that flush effectively a noop on boards where IBE bit was not set by the previous stage loader, but that's another story not affecting N900 :).

A separate thread / patch on that would be much appreciated :)

Quoted 3 lines

So, as soon as there are no context switches in u-boot that may land different code on a same physical address, we should be safe. Could you confirm this is the case? Is there virtual addressing? Multiple processes?

The only place I'm not 100% sure we wouldn't have virtual addressing would be when you start to involve the EFI loader and in turn EFI applications are running. But we're specifically disabling this here (and I don't think it's useful on this era hardware anyhow).

Quoted 6 lines
Quoted 2 lines

For the second part, how are you binding
the device? And oh, we didn't disable the EFI loader support already?

Yeah, looks like selecting libfdt automagically selects a whole bunch of other things (like CMD_FDT and OF_LIBFDT_OVERLAY)

Quoted 6 lines
Quoted 3 lines

Yeah, that would be another pretty easy choice to win back a bunch of space. So yes, this is certainly on the right track, thanks!

Ok, we'll send a proper patch series as soon as it is confirmed that it is safe to enable -mthumb.

Thanks.

Quoted 2 lines

In the meanwhile, could you please have a look at the WDT patch Pali posted back then?

It's been merged to -next for a little while now, via the TI tree.

Signature · 1 line
Tom
#24 lore raw
In reply to Tom Rini

Hi Tom,

Quoted 16 lines · Tom Rini
Quoted 7 lines
Quoted 7 lines
Quoted 6 lines
Quoted 3 lines

Fixing those requires enabling of OF_CONTROL and this in turn means the board must be migrated to DT, unless I am missing something. That's why my "please advice..." stance.

Please post the patches that bring you to the above link errors, yes, thanks.

Quoted 8 lines
Quoted 2 lines

To be clearer, finish up a patch that completes the migration but is too large to install on the hardware so that others can take a look.

I am not sure I understand that - a patch that completes the migration to DM_USB cannot be done ATM as the binary does not link without OF_CONTROL. And I am not going to enable OF_CONTROL as this means I will have to migrate everything to DT. That's why I enable DM_USB only - see reply to the other mail.

Quoted 5 lines

My advise is to provide a linkable but not runnable (or, only runnable in QEMU, the problem is the fixed layout of the actual device flash, right?) patch so that we can figure out how and what needs to be tuned where so that we can see what to do about this platform.

It looks to me that there are at least two problems:

* Size of the produced u-boot with additional features could be too large
* Porting RX51 to DM_USB seemingly also requires porting RX51 to device-tree (since OF_CONTROL is required), adding additional complications.

When you ask for patches, are you asking for patches that just enable DM_USB and stub functions to make the linking succeed (although it clearly won't result in a functional u-boot), or are you asking for patches that enable DM_USB and OF_CONTROL, and also port the device to device tree? To me it seems like you meant the former, but I'd like to confirm.

Also, I believe Ivaylo and Pali are wondering if porting to DTS is a hard requirement for porting to DM_USB (since OF_CONTROL would be required)?

Cheers,
Merlijn

author
#25 lore raw
Quoted 39 lines · Merlijn Wajer

Hi Tom,

Quoted 16 lines · Tom Rini
Quoted 7 lines
Quoted 7 lines
Quoted 6 lines
Quoted 3 lines

Fixing those requires enabling of OF_CONTROL and this in turn means the board must be migrated to DT, unless I am missing something. That's why my "please advice..." stance.

Please post the patches that bring you to the above link errors, yes, thanks.

Quoted 8 lines
Quoted 2 lines

To be clearer, finish up a patch that completes the migration but is too large to install on the hardware so that others can take a look.

I am not sure I understand that - a patch that completes the migration to DM_USB cannot be done ATM as the binary does not link without OF_CONTROL. And I am not going to enable OF_CONTROL as this means I will have to migrate everything to DT. That's why I enable DM_USB only - see reply to the other mail.

Quoted 5 lines

My advise is to provide a linkable but not runnable (or, only runnable in QEMU, the problem is the fixed layout of the actual device flash, right?) patch so that we can figure out how and what needs to be tuned where so that we can see what to do about this platform.

It looks to me that there are at least two problems:

* Size of the produced u-boot with additional features could be too large
* Porting RX51 to DM_USB seemingly also requires porting RX51 to device-tree (since OF_CONTROL is required), adding additional complications.

When you ask for patches, are you asking for patches that just enable DM_USB and stub functions to make the linking succeed (although it clearly won't result in a functional u-boot), or are you asking for patches that enable DM_USB and OF_CONTROL, and also port the device to device tree? To me it seems like you meant the former, but I'd like to confirm.

Quoted 2 lines

Also, I believe Ivaylo and Pali are wondering if porting to DTS is a hard requirement for porting to DM_USB (since OF_CONTROL would be required)?

So, part of the high level answer here is that long term, yes, enabling DM for everything is required. That may mean additional infrastructure work, if we don't already have all of the knobs in place today to let space constrained platforms like this continue to work. Does that mean we _have_to_ have OF_CONTROL? Well, today we don't have platdata for non-SPL/TPL. Saying we can't support this platform without adding as an option and then enablig OF_PLATDATA for U-Boot itself is something to bring up on the U-Boot mailing list and cc the relevant custodians.

Signature · 1 line
Tom
#26 lore raw
In reply to Tom Rini

Hi,

Quoted 87 lines · Tom Rini
Quoted 86 lines · Ivaylo Dimitrov

Hi,

Quoted 39 lines · Tom Rini
Quoted 38 lines · Ivaylo Dimitrov

Hi,

Quoted 19 lines · Pali Rohár
Quoted 18 lines · On Friday 21 May 2021 10:44:18 Tom Rini wrote:
Quoted 17 lines · Tom Rini
Quoted 15 lines · Pali Rohár
Quoted 2 lines · On Tuesday 18 May 2021 21:26:40 Tom Rini wrote:

This board has not been converted to CONFIG_DM_USB by the deadline. Remove it.

I'm very disappointed that you want to remove Nokia N900 from U-Boot.

I was waiting waiting half of year because other developers did not react to issues which were introduced and neither to patches which I sent (+ trying to remind open issues). And also I was waiting another half of year until other N900 related patches were merged. So the whole slowdown was not caused by me, why it is taking so long.

Now there is still one N900 DM related patch waiting for review. I'm converting code step by step.

Quoted 8 lines
Quoted 7 lines
Quoted 3 lines
Quoted 1 line

So the ball is not on my side.

So, what patch(es) need to be applied to get DM_USB enabled? Thanks.

I don't see any open patches from you that look related to enabling DM_USB on the platform. If you want to disable USB on the platform for now instead, that's fine too.

I tried to migrate the latest master to DM_USB, but unfortunately the results are pretty much sad - adding OF_CONTROL (which is a prerequisite to have DM_USB IIUC) and OF_BOARD (so binary to be compiled), adds ~100k to the size of the u-boot binary, so it becomes 370284 bytes. Given that we have less than 256k of storage space for the u-boot, the produced binary cannot be used on n900 the same way current (no DM_USB) binary is used.

Quoted 9 lines
Quoted 6 lines

As I see it, there are not much options left - u-boot on N900 is not SPL, so we can't use OF_PLATDATA, which in turn always links libfdt. Also, if I read the code (usb-uclass.c) correctly, enabling DM_USB requires the board to be converted to DT and this is way bigger change.

Please advice on how to proceed.

Please post your WIP patches, thanks.

Sorry, I am not sure I understand what patches you want me to post:

WDT patch has already been sent couple of months ago -
https://lists.denx.de/pipermail/u-boot/2021-March/443868.html
Do you want it to be rebased and resend?

DM_USB, I just started writing one and I immediately hit the OF_CONTROL requirement. Enabling OF_CONTROL requires a full blown migration to DT, which is a huge task and not really equal to "Please update the board to use CONFIG_DM_USB...". Without OF_CONTROL, I simply get link failures:

/usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
DWARF error: could not find abbrev number 3998 /tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_child_post_bind':
<artificial>:(.text+0x5672): undefined reference to `ofnode_read_u32_default' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x568c): undefined reference to `ofnode_read_u32_default' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_scan_device':
<artificial>:(.text+0x6c84): undefined reference to `ofnode_first_subnode' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x6c96): undefined reference to `ofnode_read_u32' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
<artificial>:(.text+0x6ca4): undefined reference to `ofnode_next_subnode' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb+0x8):
undefined reference to `dm_scan_fdt_dev' /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/ld:
/tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb_hub+0x8):
undefined reference to `dm_scan_fdt_dev'

Quoted 7 lines
Quoted 3 lines

Fixing those requires enabling of OF_CONTROL and this in turn means the board must be migrated to DT, unless I am missing something. That's why my "please advice..." stance.

Please post the patches that bring you to the above link errors, yes, thanks.

configs/nokia_rx51_defconfig +1 -0
index 3548aab0e1..36ec05a8b3 100644
@@ -61,6 +61,7 @@ CONFIG_CONS_INDEX=3
 CONFIG_SYS_NS16550=y
 CONFIG_SPI=y
 CONFIG_USB=y
+CONFIG_DM_USB=y
 CONFIG_USB_MUSB_UDC=y
 CONFIG_USB_OMAP3=y
 CONFIG_CFB_CONSOLE=y
#27 lore raw

PATCH 1/1 arm: Remove nokia_rx51 board

In reply to Tom Rini
Quoted 2 lines · Tom Rini

This board has not been converted to CONFIG_DM_USB by the deadline. Remove it.

Given that the board is in a active use and that Pali is actively working on it... That does not seem like good idea or sensible thing to do.

Best regards,
Pavel

Signature · 8 lines
http://www.livejournal.com/~pavelmachek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210519/d9a1411f/attachment.sig>
author
#28 lore raw

PATCH 1/1 arm: Remove nokia_rx51 board

Quoted 7 lines · Pavel Machek
Quoted 2 lines · Tom Rini

This board has not been converted to CONFIG_DM_USB by the deadline. Remove it.

Given that the board is in a active use and that Pali is actively working on it... That does not seem like good idea or sensible thing to do.

That's why I posted this patch now, while I'm working on the rest of the to be removed boards. We're about to be 2 years past the conversion deadline which has been part of every build for at least a year prior to that. One way or another, whatever is blocking progress needs to get resolved.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210519/89877be3/attachment.sig>