Skip to contentSkip to conversation

small compile warning fix

PATCH Petr Vandrovec 1 participant 1 message Oct 30, 2001

lore
Share & tools
lore
#0 lore raw
Quoted 9 lines
Quoted 6 lines

You can remove it completely. It should not be '#ifdef LATER', but '#ifdef OLDVERSION'... ncp_add_mem_fromfs was invoked with lock on ncp_server structure, but then it directly accessed userspace. It was possible to use this to cause deadlock, so now ncpfs uses bounce buffers and double copy instead of this.

would you include this in your patches or would you like me to make it #ifdef OLDVERSION ?

I removed ncp_add_mem_fromfs() from my tree...

Quoted 2 lines
Quoted 2 lines

I have some ncpfs patches, but I though that I'll leave them for 2.5.x. Maybe it is time to change this decision.

... but as diff between my ncpfs and Alan's is about 30KB, I still did not decide whether I'll send it for 2.4.x...
Petr Vandrovec [email protected]