2.5.48 Compilation Failure

DISCUSSION Petr Vandrovec 1 participant 1 message Nov 18, 2002

lore

Share & tools

lore

Petr Vandrovec

author

2002-11-18 12:29 UTC #0 lore raw

fs/devfs/base.c Mon Nov 18 06:20:34 2002 line 2514

Quoted 13 lines

diff -Nru a/fs/devfs/base.c b/fs/devfs/base.c

fs/devfs/base.c Mon Nov 18 06:20:34 2002 +3 -3

@@ -2509,9 +2509,9 @@
     de->mode = inode->i_mode;
     de->inode.uid = inode->i_uid;
     de->inode.gid = inode->i_gid;
-    de->inode.atime = inode->i_atime.tv_sec;
-    de->inode.mtime = inode->i_mtime.tv_sec;
-    de->inode.ctime = inode->i_ctime.tv_sec;
+    de->inode.atime.tv_sec = inode->i_atime.tv_sec;
+    de->inode.mtime.tv_sec = inode->i_mtime.tv_sec;
+    de->inode.ctime.tv_sec = inode->i_ctime.tv_sec;

No, just do

        de->inode.xtime = inode->i_xtime;

gcc will copy whole structure automatically. Otherwise uninitialized tv_nsec can contain value > 999999999us and it is not legal.

Quoted 9 lines

fs/devfs/base.c Mon Nov 18 06:20:34 2002 +3 -3

-    inode->i_atime.tv_sec = de->inode.atime;
-    inode->i_mtime.tv_sec = de->inode.mtime;
-    inode->i_ctime.tv_sec = de->inode.ctime;
+    inode->i_atime.tv_sec = de->inode.atime.tv_sec;
+    inode->i_mtime.tv_sec = de->inode.mtime.tv_sec;
+    inode->i_ctime.tv_sec = de->inode.ctime.tv_sec;

     inode->i_atime.tv_nsec = 0;
     inode->i_mtime.tv_nsec = 0;
     inode->i_ctime.tv_nsec = 0;

And here other way around. Just do

       inode->i_xtime = de->inode.xtime;

and remove assigning of zero to tv_nsec.

Although there is question, why devfs cannot use inode directly. Due to memory consumption?
Thanks,
Petr Vandrovec [email protected]