Skip to contentSkip to conversation

Fix help message of xm network-attach

PATCH New Masaki Kanno 1 participant 1 message Dec 14, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix help message of xm network-attach

Hi,

Currently, the help message of xm network-attach is as follows.

  # xm network-attach --help
  Usage: xm network-attach <Domain> [--script=<script>] [--ip=<ip>] 
  [--mac=<mac>]

Create a new virtual network device.

I think that the help message is wrong.
- Some parameters are not in the help message.
- "--" is needless.

This patch fixes the help message. The showing parameters are the same as vif of --help_config of xm create.

  # xm network-attach --help
  Usage: xm network-attach <Domain> [type=<type>] [mac=<mac>] 
  [bridge=<bridge>] [ip=<ip>] [script=<script>] [backend=<BackDomain>] 
  [vifname=<name>]

Create a new virtual network device.

Best regards,
Kan

tools/python/xen/xm/main.py +3 -2
diff -r 35c724302bdd tools/python/xen/xm/main.py
@@ -146,8 +146,9 @@ SUBCOMMAND_HELP = {
                         'Destroy a domain\'s virtual block device.'),
     'block-list'    :  ('<Domain> [--long]',
                         'List virtual block devices for a domain.'),
-    'network-attach':  ('<Domain> [--script=<script>] [--ip=<ip>] '
-                        '[--mac=<mac>]',
+    'network-attach':  ('<Domain> [type=<type>] [mac=<mac>] [bridge=<bridge>] '
+                        '[ip=<ip>] [script=<script>] [backend=<BackDomain>] '
+                        '[vifname=<name>]',
                         'Create a new virtual network device.'),
     'network-detach':  ('<Domain> <DevId> [-f|--force]',
                         'Destroy a domain\'s virtual network device.'),

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel