meta-ti-extras: ti-unpack: Drop update_data call
PATCH 1/1 meta-ti-extras: ti-unpack: Drop update_data call
Bitbake made it's data store dynamic many releases ago and finally removed the update_data command altogether in commit 584989ed2b5af4e8799571dece0cf94f995ef14e. This drops our references as well.
--- meta-ti-extras/recipes-ti/includes/ti-unpack.inc | 1 - 1 file changed, 1 deletion(-)
meta-ti-extras/recipes-ti/includes/ti-unpack.inc +0 -1
@@ -24,7 +24,6 @@ python ti_bin_do_unpack() { bb.fatal("TI installer requires 32bit glibc libraries for proper operation\nrun 'yum install glibc.i686' on Fedora or 'apt-get install libc6:i386' on Ubuntu/Debian") localdata = bb.data.createCopy(d) - bb.data.update_data(localdata) binfile = localdata.getVar('BINFILE') binfile = bb.data.expand(binfile, localdata)
Signature · 1 line
2.34.1
This change was already made on the master branch back in November to address this issue. Are you seeing this on other branches? I do not believe that this patch needs to be applied to dunfell or kirkstone unless you are seeing an issue.
Quoted 22 lines · Randolph Sapp
Bitbake made it's data store dynamic many releases ago and finally removed the
update_datacommand altogether in commit584989ed2b5af4e8799571dece0cf94f995ef14e. This drops our references as well.Signed-off-by Randolph Sapp <[email protected]>--- meta-ti-extras/recipes-ti/includes/ti-unpack.inc | 1 - 1 file changed, 1 deletion(-)meta-ti-extras/recipes-ti/includes/ti-unpack.inc +0
-1@@ -24,7 +24,6 @@ python ti_bin_do_unpack() { bb.fatal("TI installer requires 32bit glibc libraries for proper operation\nrun 'yum install glibc.i686' on Fedora or 'apt-get install libc6:i386' on Ubuntu/Debian") localdata = bb.data.createCopy(d) - bb.data.update_data(localdata) binfile = localdata.getVar('BINFILE') binfile = bb.data.expand(binfile, localdata)
Signature · 3 lines
Ryan Eatmon [email protected] ----------------------------------------- Texas Instruments, Inc. - LCPD - MGTS
Quoted 1 line · Ryan Eatmon
This change was already made on the master branch back in November to address this issue. Are you seeing this on other branches? I do not believe that this patch needs to be applied to dunfell or kirkstone unless you are seeing an issue.
I saw this issue under kirkstone with the latest version of my GPU patch for meta-ti and meta-arago.
Quoted 4 lines · Randolph
Quoted 1 line · Ryan Eatmon
This change was already made on the master branch back in November to address this issue. Are you seeing this on other branches? I do not believe that this patch needs to be applied to dunfell or kirkstone unless you are seeing an issue.
I saw this issue under kirkstone with the latest version of my GPU patch for meta-ti and meta-arago.
They must have back ported it.
Signature · 3 lines
Ryan Eatmon [email protected] ----------------------------------------- Texas Instruments, Inc. - LCPD - MGTS
Quoted 7 lines · Ryan Eatmon
Quoted 4 lines · Randolph
Quoted 1 line · On Fri, Jan 27 2023 at 12:12:55 PM -0600, Ryan Eatmon <[email protected]> wrote:
This change was already made on the master branch back in November to address this issue. Are you seeing this on other branches? I do not believe that this patch needs to be applied to dunfell or kirkstone unless you are seeing an issue.
I saw this issue under kirkstone with the latest version of my GPU patch for meta-ti and meta-arago.
They must have back ported it.
Whoops, I was tracking bitbake main. Kirkstone doesn't appear to have that commit yet. Still, there should be no reason to call update_data as it is a deprecated function and a NOOP. Entirely up to you whether you want to take this, I don't care.