Skip to contentSkip to conversation

ti-img-rogue-*: Bump the graphics recipes

PATCH In review Randolph Sapp 2 participants 7 messages Oct 6, 2022 – Oct 12, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ti-img-rogue-*: Bump the graphics recipes

Bump the graphics recipes source revision and remove the old BVNC switch. The BVNC is now baked into the platform Makefile that is selected with PVR_BUILD_DIR / TARGET_PRODUCT.

---
 .../ti-img-rogue-driver_1.15.6133109.bb                | 10 ++--------
 .../libgles/ti-img-rogue-umlibs_1.15.6133109.bb        |  2 +-
 2 files changed, 3 insertions(+), 9 deletions(-)
recipes-bsp/powervr-drivers/ti-img-rogue-driver_1.15.6133109.bb +2 -8
index 1127c5d1..4f6dc4d4 100644
@@ -26,7 +26,7 @@ SRC_URI = " \
 
 S = "${WORKDIR}/git"
 
-SRCREV = "ea2ac3fda4ac442b639bc3a0b73e9c4feac2081a"
+SRCREV = "a353b9524399d927af8e824f92902065947b2fbe"
 
 TARGET_PRODUCT_j7-evm = "j721e_linux"
 TARGET_PRODUCT_j7-hs-evm = "j721e_linux"
@@ -34,16 +34,10 @@ TARGET_PRODUCT_j721s2-evm = "j721s2_linux"
 TARGET_PRODUCT_j721s2-hs-evm = "j721s2_linux"
 TARGET_PRODUCT_j784s4-evm = "j784s4_linux"
 TARGET_PRODUCT_am62xx = "am62_linux"
-TARGET_BVNC_j7-evm = "22.104.208.318"
-TARGET_BVNC_j7-hs-evm = "22.104.208.318"
-TARGET_BVNC_j721s2-evm = "36.53.104.796"
-TARGET_BVNC_j721s2-hs-evm = "36.53.104.796"
-TARGET_BVNC_j784s4-evm = "36.53.104.796"
-TARGET_BVNC_am62xx = "33.15.11.3"
 PVR_BUILD = "release"
 PVR_WS = "wayland"
 
-EXTRA_OEMAKE += 'KERNELDIR="${STAGING_KERNEL_DIR}" RGX_BVNC=${TARGET_BVNC} BUILD=${PVR_BUILD} PVR_BUILD_DIR=${TARGET_PRODUCT} WINDOW_SYSTEM=${PVR_WS}'
+EXTRA_OEMAKE += 'KERNELDIR="${STAGING_KERNEL_DIR}" BUILD=${PVR_BUILD} PVR_BUILD_DIR=${TARGET_PRODUCT} WINDOW_SYSTEM=${PVR_WS}'
 
 do_install() {
     make -C ${STAGING_KERNEL_DIR} M=${B}/binary_${TARGET_PRODUCT}_${PVR_WS}_${PVR_BUILD}/target_aarch64/kbuild INSTALL_MOD_PATH=${D}${root_prefix} PREFIX=${STAGING_DIR_HOST} modules_install
recipes-graphics/libgles/ti-img-rogue-umlibs_1.15.6133109.bb +1 -1
index b6bb4324..de979be0 100644
@@ -15,7 +15,7 @@ PR = "r2"
 BRANCH = "linuxws/dunfell/k5.10/${PV}_unified_fw_pagesize"
 
 SRC_URI = "git://git.ti.com/git/graphics/ti-img-rogue-umlibs.git;protocol=https;branch=${BRANCH}"
-SRCREV = "4207c0ea429ec751b1ff5f831a84ceeb76ad578d"
+SRCREV = "5977e82b96028f783d39c7219f016c1faf8dc5f5"
 
 TARGET_PRODUCT_j7-evm = "j721e_linux"
 TARGET_PRODUCT_j7-hs-evm = "j721e_linux"
Signature · 1 line
2.25.1
#1 lore raw
Quoted 3 lines · Randolph Sapp via lists.yoctoproject.org

Bump the graphics recipes source revision and remove the old BVNC switch. The BVNC is now baked into the platform Makefile that is selected with PVR_BUILD_DIR / TARGET_PRODUCT.

Any useful changelog between the 2 SRCREVs, besides removal of BVNC?

Quoted 52 lines
---
 .../ti-img-rogue-driver_1.15.6133109.bb                | 10 ++--------
 .../libgles/ti-img-rogue-umlibs_1.15.6133109.bb        |  2 +-
 2 files changed, 3 insertions(+), 9 deletions(-)
recipes-bsp/powervr-drivers/ti-img-rogue-driver_1.15.6133109.bb +2 -8
index 1127c5d1..4f6dc4d4 100644
@@ -26,7 +26,7 @@ SRC_URI = " \
 
 S = "${WORKDIR}/git"
 
-SRCREV = "ea2ac3fda4ac442b639bc3a0b73e9c4feac2081a"
+SRCREV = "a353b9524399d927af8e824f92902065947b2fbe"
 
 TARGET_PRODUCT_j7-evm = "j721e_linux"
 TARGET_PRODUCT_j7-hs-evm = "j721e_linux"
@@ -34,16 +34,10 @@ TARGET_PRODUCT_j721s2-evm = "j721s2_linux"
 TARGET_PRODUCT_j721s2-hs-evm = "j721s2_linux"
 TARGET_PRODUCT_j784s4-evm = "j784s4_linux"
 TARGET_PRODUCT_am62xx = "am62_linux"
-TARGET_BVNC_j7-evm = "22.104.208.318"
-TARGET_BVNC_j7-hs-evm = "22.104.208.318"
-TARGET_BVNC_j721s2-evm = "36.53.104.796"
-TARGET_BVNC_j721s2-hs-evm = "36.53.104.796"
-TARGET_BVNC_j784s4-evm = "36.53.104.796"
-TARGET_BVNC_am62xx = "33.15.11.3"
 PVR_BUILD = "release"
 PVR_WS = "wayland"
 
-EXTRA_OEMAKE += 'KERNELDIR="${STAGING_KERNEL_DIR}" RGX_BVNC=${TARGET_BVNC} BUILD=${PVR_BUILD} PVR_BUILD_DIR=${TARGET_PRODUCT} WINDOW_SYSTEM=${PVR_WS}'
+EXTRA_OEMAKE += 'KERNELDIR="${STAGING_KERNEL_DIR}" BUILD=${PVR_BUILD} PVR_BUILD_DIR=${TARGET_PRODUCT} WINDOW_SYSTEM=${PVR_WS}'
 
 do_install() {
     make -C ${STAGING_KERNEL_DIR} M=${B}/binary_${TARGET_PRODUCT}_${PVR_WS}_${PVR_BUILD}/target_aarch64/kbuild INSTALL_MOD_PATH=${D}${root_prefix} PREFIX=${STAGING_DIR_HOST} modules_install
recipes-graphics/libgles/ti-img-rogue-umlibs_1.15.6133109.bb +1 -1
index b6bb4324..de979be0 100644
@@ -15,7 +15,7 @@ PR = "r2"
 BRANCH = "linuxws/dunfell/k5.10/${PV}_unified_fw_pagesize"
 
 SRC_URI = "git://git.ti.com/git/graphics/ti-img-rogue-umlibs.git;protocol=https;branch=${BRANCH}"
-SRCREV = "4207c0ea429ec751b1ff5f831a84ceeb76ad578d"
+SRCREV = "5977e82b96028f783d39c7219f016c1faf8dc5f5"
 
 TARGET_PRODUCT_j7-evm = "j721e_linux"
 TARGET_PRODUCT_j7-hs-evm = "j721e_linux"
Signature · 1 line
2.25.1
#2 lore raw
Quoted 1 line · Denys Dmytriyenko

Any useful changelog between the 2 SRCREVs, besides removal of BVNC?

Yeah, actually. Two main things. The default precision for GL fragmentation shaders was bumped up, which helps with some visual bugs in applications like glmark2. In addition to this, a firmware patch was added that should help some of the hardware recoveries clients were experiencing on am62.

This is roughly the latest commit message for the selected UM version.

KM was really only a Makefile cleanup because I was tired of trying to remember what platform had what BVNC and there were a few legacy variables being set that had no effect.

#3 lore raw
Quoted 10 lines · Randolph Sapp via lists.yoctoproject.org
Quoted 1 line · Denys Dmytriyenko

Any useful changelog between the 2 SRCREVs, besides removal of BVNC?

Yeah, actually. Two main things. The default precision for GL fragmentation shaders was bumped up, which helps with some visual bugs in applications like glmark2. In addition to this, a firmware patch was added that should help some of the hardware recoveries clients were experiencing on am62.

Quoted 5 lines

This is roughly the latest commit message for the selected UM version.

KM was really only a Makefile cleanup because I was tired of trying to remember what platform had what BVNC and there were a few legacy variables being set that had no effect.

Should these be mentioned in the git commit message?

Signature · 1 line
Denys
#4 lore raw
Quoted 1 line · Denys Dmytriyenko

Should these be mentioned in the git commit message?

Depends on what we're actually trying to track in these commit messages. As far as I'm concerned these commit messages should only track changes to the recipes and reasoning, but if you believe they should also track upstream change notes then I will modify it accordingly.

#5 lore raw
Quoted 9 lines · Randolph
Quoted 1 line · Denys Dmytriyenko

Should these be mentioned in the git commit message?

Depends on what we're actually trying to track in these commit messages. As far as I'm concerned these commit messages should only track changes to the recipes and reasoning, but if you believe they should also track upstream change notes then I will modify it accordingly.

And that's part of the reasoning. If those upstream change notes are public, you can simply link to them in git history. Otherwise it is recommended to provide a brief high level summary of the changes in the corresponding component.

https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

Signature · 1 line
Denys