Skip to contentSkip to conversation

drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

PATCH In review Jeff Layton 5 participants 14 messages Apr 13, 2023 – Apr 17, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

I've been experiencing some intermittent crashes down in the display driver code. The symptoms are ususally a line like this in dmesg:

    amdgpu 0000:30:00.0: [drm] Failed to create MST payload for port 000000006d3a3885: -5

...followed by an Oops due to a NULL pointer dereference.

The real bug is probably in the caller of this function, which is passing it a NULL state pointer, but this patch at least keeps my machine from oopsing when this occurs.

---
 drivers/gpu/drm/display/drm_dp_mst_topology.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/display/drm_dp_mst_topology.c +2 -1
index 38dab76ae69e..87ad406c50f9 100644
@@ -3404,7 +3404,8 @@ int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr,
 
 	/* Skip failed payloads */
 	if (payload->vc_start_slot == -1) {
-		drm_dbg_kms(state->dev, "Part 1 of payload creation for %s failed, skipping part 2\n",
+		drm_dbg_kms(state ? state->dev : NULL,
+			    "Part 1 of payload creation for %s failed, skipping part 2\n",
 			    payload->port->connector->name);
 		return -EIO;
 	}
Signature · 1 line
2.39.2
#1 lore raw
Quoted 10 lines · Jeff Layton

I've been experiencing some intermittent crashes down in the display driver code. The symptoms are ususally a line like this in dmesg:

    amdgpu 0000:30:00.0: [drm] Failed to create MST payload for port 000000006d3a3885: -5

...followed by an Oops due to a NULL pointer dereference.

The real bug is probably in the caller of this function, which is passing it a NULL state pointer, but this patch at least keeps my machine from oopsing when this occurs.

My fear is that papering over this makes the root cause harder to find.

Cc Harry, Alex

BR,
Jani.

Quoted 21 lines
---
 drivers/gpu/drm/display/drm_dp_mst_topology.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/display/drm_dp_mst_topology.c +2 -1
index 38dab76ae69e..87ad406c50f9 100644
@@ -3404,7 +3404,8 @@ int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr,
 
 	/* Skip failed payloads */
 	if (payload->vc_start_slot == -1) {
-		drm_dbg_kms(state->dev, "Part 1 of payload creation for %s failed, skipping part 2\n",
+		drm_dbg_kms(state ? state->dev : NULL,
+			    "Part 1 of payload creation for %s failed, skipping part 2\n",
 			    payload->port->connector->name);
 		return -EIO;
 	}
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
#2 lore raw
Quoted 12 lines · Jani Nikula
Quoted 10 lines · Jeff Layton

I've been experiencing some intermittent crashes down in the display driver code. The symptoms are ususally a line like this in dmesg:

    amdgpu 0000:30:00.0: [drm] Failed to create MST payload for port 000000006d3a3885: -5

...followed by an Oops due to a NULL pointer dereference.

The real bug is probably in the caller of this function, which is passing it a NULL state pointer, but this patch at least keeps my machine from oopsing when this occurs.

Quoted 9 lines

My fear is that papering over this makes the root cause harder to find.

Cc Harry, Alex

BR,
Jani.

I'm happy to help track down the root cause. Display drivers are somewhat outside my wheelhouse though.

Maybe we can throw a WARNING when this happens? I'd just like it to not crash my machine.

Quoted 22 lines
Quoted 21 lines
---
 drivers/gpu/drm/display/drm_dp_mst_topology.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/display/drm_dp_mst_topology.c +2 -1
index 38dab76ae69e..87ad406c50f9 100644
@@ -3404,7 +3404,8 @@ int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr,
 
 	/* Skip failed payloads */
 	if (payload->vc_start_slot == -1) {
-		drm_dbg_kms(state->dev, "Part 1 of payload creation for %s failed, skipping part 2\n",
+		drm_dbg_kms(state ? state->dev : NULL,
+			    "Part 1 of payload creation for %s failed, skipping part 2\n",
 			    payload->port->connector->name);
 		return -EIO;
 	}
Signature · 1 line
Jeff Layton <[email protected]>
#3 lore raw
In reply to Jani Nikula

+ Wayne

Quoted 46 lines · Jani Nikula
Quoted 10 lines · Jeff Layton

I've been experiencing some intermittent crashes down in the display driver code. The symptoms are ususally a line like this in dmesg:

    amdgpu 0000:30:00.0: [drm] Failed to create MST payload for port 000000006d3a3885: -5

...followed by an Oops due to a NULL pointer dereference.

The real bug is probably in the caller of this function, which is passing it a NULL state pointer, but this patch at least keeps my machine from oopsing when this occurs.

My fear is that papering over this makes the root cause harder to find.

Cc Harry, Alex

BR,
Jani.

Quoted 12 lines
---
 drivers/gpu/drm/display/drm_dp_mst_topology.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/display/drm_dp_mst_topology.c +0 -0
index 38dab76ae69e..87ad406c50f9 100644

drivers/gpu/drm/display/drm_dp_mst_topology.c int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr, · line 3411

Quoted 9 lines
drivers/gpu/drm/display/drm_dp_mst_topology.c +2 -1
@@ -3404,7 +3404,8 @@ int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr,
 
      /* Skip failed payloads */
      if (payload->vc_start_slot == -1) {
-             drm_dbg_kms(state->dev, "Part 1 of payload creation for %s failed, skipping part 2\n",
+             drm_dbg_kms(state ? state->dev : NULL,
+                         "Part 1 of payload creation for %s failed, skipping part 2\n",
                          payload->port->connector->name);
              return -EIO;
      }

--
Jani Nikula, Intel Open Source Graphics Center

#4 lore raw

[Public]

Hi Jeff,

Thanks. I might need more information to understand why we can't retrieve the drm atomic state. Also , "Failed to create MST payload for port" indicates error while configuring DPCD payload ID table. Could you help to provide log with KMS + ATOMIC + DP debug on please? Thanks in advance!

Regards,
Wayne

Quoted 67 lines

-----Original Message-----
From: Alex Deucher <[email protected]>
Sent: Thursday, April 13, 2023 8:59 PM
To: Jani Nikula <[email protected]>; Lin, Wayne <[email protected]>
Cc: Jeff Layton <[email protected]>; David Airlie <[email protected]>; Daniel Vetter <[email protected]>; Deucher, Alexander <[email protected]>; [email protected]; dri- [email protected]
Subject: Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

+ Wayne

Quoted 38 lines · Jani Nikula
Quoted 11 lines · Jeff Layton

I've been experiencing some intermittent crashes down in the display driver code. The symptoms are ususally a line like this in dmesg:

amdgpu 0000:30:00.0: [drm] Failed to create MST payload for port
000000006d3a3885: -5

...followed by an Oops due to a NULL pointer dereference.

The real bug is probably in the caller of this function, which is passing it a NULL state pointer, but this patch at least keeps my machine from oopsing when this occurs.

My fear is that papering over this makes the root cause harder to find.

Cc Harry, Alex

BR,
Jani.

Quoted 15 lines
---
 drivers/gpu/drm/display/drm_dp_mst_topology.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/display/drm_dp_mst_topology.c +0 -0
index 38dab76ae69e..87ad406c50f9 100644
@@ -3404,7 +3404,8 @@ int drm_dp_add_payload_part2(struct
 drm_dp_mst_topology_mgr *mgr,
 
Quoted 3 lines

drivers/gpu/drm/display/drm_dp_mst_topology.c int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr,

Quoted 3 lines
drivers/gpu/drm/display/drm_dp_mst_topology.c +0 -1
      /* Skip failed payloads */
      if (payload->vc_start_slot == -1) {
-             drm_dbg_kms(state->dev, "Part 1 of payload creation for %s

failed, skipping part 2\n",

Quoted 9 lines

drivers/gpu/drm/display/drm_dp_mst_topology.c int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr, · line 3411

Quoted 6 lines
drivers/gpu/drm/display/drm_dp_mst_topology.c +3 -0
+             drm_dbg_kms(state ? state->dev : NULL,
+                         "Part 1 of payload creation for %s failed,
+ skipping part 2\n",
                          payload->port->connector->name);
              return -EIO;
      }

--
Jani Nikula, Intel Open Source Graphics Center

#5 lore raw
Quoted 4 lines · Wayne

[Public]

Hi Jeff,

Quoted 8 lines

Thanks. I might need more information to understand why we can't retrieve the drm atomic state. Also , "Failed to create MST payload for port" indicates error while configuring DPCD payload ID table. Could you help to provide log with KMS + ATOMIC + DP debug on please? Thanks in advance!

Regards,
Wayne

Possibly. I'm not that familiar with display driver debugging. Can you send me some directions on how to crank up that sort of debug logging?

Note that this problem is _very_ intermittent too: I went about 2 weeks between crashes, and then I got 3 in one day. I'd rather not run with a lot of debug logging for a long time if that's what this is going to require, as this is my main workstation.

The last time I got this log message, my proposed patch did prevent the box from oopsing, so I'd really like to see it go in unless it's just categorically wrong for the caller to pass down a NULL state pointer to drm_dp_add_payload_part2.

Quoted 67 lines
Quoted 67 lines

-----Original Message-----
From: Alex Deucher <[email protected]>
Sent: Thursday, April 13, 2023 8:59 PM
To: Jani Nikula <[email protected]>; Lin, Wayne <[email protected]>
Cc: Jeff Layton <[email protected]>; David Airlie <[email protected]>; Daniel Vetter <[email protected]>; Deucher, Alexander <[email protected]>; [email protected]; dri- [email protected]
Subject: Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

+ Wayne

Quoted 38 lines · Jani Nikula
Quoted 11 lines · Jeff Layton

I've been experiencing some intermittent crashes down in the display driver code. The symptoms are ususally a line like this in dmesg:

amdgpu 0000:30:00.0: [drm] Failed to create MST payload for port
000000006d3a3885: -5

...followed by an Oops due to a NULL pointer dereference.

The real bug is probably in the caller of this function, which is passing it a NULL state pointer, but this patch at least keeps my machine from oopsing when this occurs.

My fear is that papering over this makes the root cause harder to find.

Cc Harry, Alex

BR,
Jani.

Quoted 15 lines
---
 drivers/gpu/drm/display/drm_dp_mst_topology.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/display/drm_dp_mst_topology.c +0 -0
index 38dab76ae69e..87ad406c50f9 100644
@@ -3404,7 +3404,8 @@ int drm_dp_add_payload_part2(struct
 drm_dp_mst_topology_mgr *mgr,
 
Quoted 3 lines

drivers/gpu/drm/display/drm_dp_mst_topology.c int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr,

Quoted 3 lines
drivers/gpu/drm/display/drm_dp_mst_topology.c +0 -1
      /* Skip failed payloads */
      if (payload->vc_start_slot == -1) {
-             drm_dbg_kms(state->dev, "Part 1 of payload creation for %s

failed, skipping part 2\n",

Quoted 9 lines

drivers/gpu/drm/display/drm_dp_mst_topology.c int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr, · line 3411

Quoted 6 lines
drivers/gpu/drm/display/drm_dp_mst_topology.c +3 -0
+             drm_dbg_kms(state ? state->dev : NULL,
+                         "Part 1 of payload creation for %s failed,
+ skipping part 2\n",
                          payload->port->connector->name);
              return -EIO;
      }

--
Jani Nikula, Intel Open Source Graphics Center

Signature · 1 line
Jeff Layton <[email protected]>
#6 lore raw
Quoted 22 lines · Jeff Layton
Quoted 4 lines · Wayne

[Public]

Hi Jeff,

Quoted 8 lines

Thanks. I might need more information to understand why we can't retrieve the drm atomic state. Also , "Failed to create MST payload for port" indicates error while configuring DPCD payload ID table. Could you help to provide log with KMS + ATOMIC + DP debug on please? Thanks in advance!

Regards,
Wayne

Possibly. I'm not that familiar with display driver debugging. Can you send me some directions on how to crank up that sort of debug logging?

Note that this problem is _very_ intermittent too: I went about 2 weeks between crashes, and then I got 3 in one day. I'd rather not run with a lot of debug logging for a long time if that's what this is going to require, as this is my main workstation.

Quoted 4 lines

The last time I got this log message, my proposed patch did prevent the box from oopsing, so I'd really like to see it go in unless it's just categorically wrong for the caller to pass down a NULL state pointer to drm_dp_add_payload_part2.

Cc Lyude.

Looks like the state parameter was added in commit 4d07b0bc4034 ("drm/display/dp_mst: Move all payload info into the atomic state") and its only use is to get at state->dev for debug logging.

What's the plan for the parameter? Surely something more than that! :)

Instead of "state ? state->dev : NULL" I guess we could use mgr->dev like the other logging calls do. It's papering over the NULL parameter too, but perhaps in a slightly cleaner way...

BR,
Jani.

Quoted 68 lines
Quoted 68 lines
Quoted 68 lines

-----Original Message-----
From: Alex Deucher <[email protected]>
Sent: Thursday, April 13, 2023 8:59 PM
To: Jani Nikula <[email protected]>; Lin, Wayne <[email protected]>
Cc: Jeff Layton <[email protected]>; David Airlie <[email protected]>; Daniel Vetter <[email protected]>; Deucher, Alexander <[email protected]>; [email protected]; dri- [email protected]
Subject: Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

+ Wayne

Quoted 38 lines · Jani Nikula
Quoted 11 lines · Jeff Layton

I've been experiencing some intermittent crashes down in the display driver code. The symptoms are ususally a line like this in dmesg:

amdgpu 0000:30:00.0: [drm] Failed to create MST payload for port
000000006d3a3885: -5

...followed by an Oops due to a NULL pointer dereference.

The real bug is probably in the caller of this function, which is passing it a NULL state pointer, but this patch at least keeps my machine from oopsing when this occurs.

My fear is that papering over this makes the root cause harder to find.

Cc Harry, Alex

BR,
Jani.

Quoted 15 lines
---
 drivers/gpu/drm/display/drm_dp_mst_topology.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/display/drm_dp_mst_topology.c +0 -0
index 38dab76ae69e..87ad406c50f9 100644
@@ -3404,7 +3404,8 @@ int drm_dp_add_payload_part2(struct
 drm_dp_mst_topology_mgr *mgr,
 
Quoted 3 lines

drivers/gpu/drm/display/drm_dp_mst_topology.c int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr,

Quoted 3 lines
drivers/gpu/drm/display/drm_dp_mst_topology.c +0 -1
      /* Skip failed payloads */
      if (payload->vc_start_slot == -1) {
-             drm_dbg_kms(state->dev, "Part 1 of payload creation for %s

failed, skipping part 2\n",

Quoted 9 lines

drivers/gpu/drm/display/drm_dp_mst_topology.c int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr, · line 3411

Quoted 6 lines
drivers/gpu/drm/display/drm_dp_mst_topology.c +3 -0
+             drm_dbg_kms(state ? state->dev : NULL,
+                         "Part 1 of payload creation for %s failed,
+ skipping part 2\n",
                          payload->port->connector->name);
              return -EIO;
      }

--
Jani Nikula, Intel Open Source Graphics Center

Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
#7 lore raw
Quoted 28 lines · Jani Nikula
Quoted 22 lines · Jeff Layton
Quoted 4 lines · Wayne

[Public]

Hi Jeff,

Quoted 8 lines

Thanks. I might need more information to understand why we can't retrieve the drm atomic state. Also , "Failed to create MST payload for port" indicates error while configuring DPCD payload ID table. Could you help to provide log with KMS + ATOMIC + DP debug on please? Thanks in advance!

Regards,
Wayne

Possibly. I'm not that familiar with display driver debugging. Can you send me some directions on how to crank up that sort of debug logging?

Note that this problem is _very_ intermittent too: I went about 2 weeks between crashes, and then I got 3 in one day. I'd rather not run with a lot of debug logging for a long time if that's what this is going to require, as this is my main workstation.

Quoted 4 lines

The last time I got this log message, my proposed patch did prevent the box from oopsing, so I'd really like to see it go in unless it's just categorically wrong for the caller to pass down a NULL state pointer to drm_dp_add_payload_part2.

Quoted 7 lines
Cc Lyude.

Looks like the state parameter was added in commit 4d07b0bc4034 ("drm/display/dp_mst: Move all payload info into the atomic state") and its only use is to get at state->dev for debug logging.

What's the plan for the parameter? Surely something more than that! :)

I don't think there was any plan for that, or at least I certainly don't even remember adding that D:. It must totally have been by mistake and snuck by review, if that's the only thing that we're using it for I'd say it's definitely fine to just drop it entirely

Quoted 79 lines

Instead of "state ? state->dev : NULL" I guess we could use mgr->dev like the other logging calls do. It's papering over the NULL parameter too, but perhaps in a slightly cleaner way...

BR,
Jani.

Quoted 68 lines
Quoted 68 lines
Quoted 68 lines

-----Original Message-----
From: Alex Deucher <[email protected]>
Sent: Thursday, April 13, 2023 8:59 PM
To: Jani Nikula <[email protected]>; Lin, Wayne <[email protected]>
Cc: Jeff Layton <[email protected]>; David Airlie <[email protected]>; Daniel Vetter <[email protected]>; Deucher, Alexander <[email protected]>; [email protected]; dri- [email protected]
Subject: Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

+ Wayne

Quoted 38 lines · Jani Nikula
Quoted 11 lines · Jeff Layton

I've been experiencing some intermittent crashes down in the display driver code. The symptoms are ususally a line like this in dmesg:

amdgpu 0000:30:00.0: [drm] Failed to create MST payload for port
000000006d3a3885: -5

...followed by an Oops due to a NULL pointer dereference.

The real bug is probably in the caller of this function, which is passing it a NULL state pointer, but this patch at least keeps my machine from oopsing when this occurs.

My fear is that papering over this makes the root cause harder to find.

Cc Harry, Alex

BR,
Jani.

Quoted 15 lines
---
 drivers/gpu/drm/display/drm_dp_mst_topology.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/display/drm_dp_mst_topology.c +0 -0
index 38dab76ae69e..87ad406c50f9 100644
@@ -3404,7 +3404,8 @@ int drm_dp_add_payload_part2(struct
 drm_dp_mst_topology_mgr *mgr,
 
Quoted 3 lines

drivers/gpu/drm/display/drm_dp_mst_topology.c int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr,

Quoted 3 lines
drivers/gpu/drm/display/drm_dp_mst_topology.c +0 -1
      /* Skip failed payloads */
      if (payload->vc_start_slot == -1) {
-             drm_dbg_kms(state->dev, "Part 1 of payload creation for %s

failed, skipping part 2\n",

Quoted 9 lines

drivers/gpu/drm/display/drm_dp_mst_topology.c int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr, · line 3411

Quoted 6 lines
drivers/gpu/drm/display/drm_dp_mst_topology.c +3 -0
+             drm_dbg_kms(state ? state->dev : NULL,
+                         "Part 1 of payload creation for %s failed,
+ skipping part 2\n",
                          payload->port->connector->name);
              return -EIO;
      }

--
Jani Nikula, Intel Open Source Graphics Center

Signature · 3 lines
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat
#8 lore raw
Quoted 35 lines · Lyude Paul
Quoted 34 lines · Jani Nikula
Quoted 22 lines · Jeff Layton
Quoted 4 lines · Wayne

[Public]

Hi Jeff,

Quoted 8 lines

Thanks. I might need more information to understand why we can't retrieve the drm atomic state. Also , "Failed to create MST payload for port" indicates error while configuring DPCD payload ID table. Could you help to provide log with KMS + ATOMIC + DP debug on please? Thanks in advance!

Regards,
Wayne

Possibly. I'm not that familiar with display driver debugging. Can you send me some directions on how to crank up that sort of debug logging?

Note that this problem is _very_ intermittent too: I went about 2 weeks between crashes, and then I got 3 in one day. I'd rather not run with a lot of debug logging for a long time if that's what this is going to require, as this is my main workstation.

Quoted 4 lines

The last time I got this log message, my proposed patch did prevent the box from oopsing, so I'd really like to see it go in unless it's just categorically wrong for the caller to pass down a NULL state pointer to drm_dp_add_payload_part2.

Cc Lyude.

Looks like the state parameter was added in commit 4d07b0bc4034 ("drm/display/dp_mst: Move all payload info into the atomic state") and its only use is to get at state->dev for debug logging.

Quoted 6 lines
Quoted 1 line

What's the plan for the parameter? Surely something more than that! :)

I don't think there was any plan for that, or at least I certainly don't even remember adding that D:. It must totally have been by mistake and snuck by review, if that's the only thing that we're using it for I'd say it's definitely fine to just drop it entirely

I guess we could use two patches then, first replace state->dev with mgr->dev as something that can be backported as needed, and second drop the state parameter altogether.

Jeff, up for it? At least the first one?

BR,
Jani.

Quoted 80 lines
Quoted 80 lines

Instead of "state ? state->dev : NULL" I guess we could use mgr->dev like the other logging calls do. It's papering over the NULL parameter too, but perhaps in a slightly cleaner way...

BR,
Jani.

Quoted 68 lines
Quoted 68 lines
Quoted 68 lines

-----Original Message-----
From: Alex Deucher <[email protected]>
Sent: Thursday, April 13, 2023 8:59 PM
To: Jani Nikula <[email protected]>; Lin, Wayne <[email protected]>
Cc: Jeff Layton <[email protected]>; David Airlie <[email protected]>; Daniel Vetter <[email protected]>; Deucher, Alexander <[email protected]>; [email protected]; dri- [email protected]
Subject: Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

+ Wayne

Quoted 38 lines · Jani Nikula
Quoted 11 lines · Jeff Layton

I've been experiencing some intermittent crashes down in the display driver code. The symptoms are ususally a line like this in dmesg:

amdgpu 0000:30:00.0: [drm] Failed to create MST payload for port
000000006d3a3885: -5

...followed by an Oops due to a NULL pointer dereference.

The real bug is probably in the caller of this function, which is passing it a NULL state pointer, but this patch at least keeps my machine from oopsing when this occurs.

My fear is that papering over this makes the root cause harder to find.

Cc Harry, Alex

BR,
Jani.

Quoted 15 lines
---
 drivers/gpu/drm/display/drm_dp_mst_topology.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/display/drm_dp_mst_topology.c +0 -0
index 38dab76ae69e..87ad406c50f9 100644
@@ -3404,7 +3404,8 @@ int drm_dp_add_payload_part2(struct
 drm_dp_mst_topology_mgr *mgr,
 
Quoted 3 lines

drivers/gpu/drm/display/drm_dp_mst_topology.c int drm_dp_add_payload_part2(struct · line 3408

Quoted 3 lines
drivers/gpu/drm/display/drm_dp_mst_topology.c +0 -1
      /* Skip failed payloads */
      if (payload->vc_start_slot == -1) {
-             drm_dbg_kms(state->dev, "Part 1 of payload creation for %s

failed, skipping part 2\n",

Quoted 9 lines

drivers/gpu/drm/display/drm_dp_mst_topology.c int drm_dp_add_payload_part2(struct

Quoted 6 lines
drivers/gpu/drm/display/drm_dp_mst_topology.c +3 -0
+             drm_dbg_kms(state ? state->dev : NULL,
+                         "Part 1 of payload creation for %s failed,
+ skipping part 2\n",
                          payload->port->connector->name);
              return -EIO;
      }

--
Jani Nikula, Intel Open Source Graphics Center

Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
#9 lore raw
Quoted 47 lines · Jani Nikula
Quoted 35 lines · Lyude Paul
Quoted 34 lines · Jani Nikula
Quoted 22 lines · Jeff Layton
Quoted 4 lines · Wayne

[Public]

Hi Jeff,

Quoted 8 lines

Thanks. I might need more information to understand why we can't retrieve the drm atomic state. Also , "Failed to create MST payload for port" indicates error while configuring DPCD payload ID table. Could you help to provide log with KMS + ATOMIC + DP debug on please? Thanks in advance!

Regards,
Wayne

Possibly. I'm not that familiar with display driver debugging. Can you send me some directions on how to crank up that sort of debug logging?

Note that this problem is _very_ intermittent too: I went about 2 weeks between crashes, and then I got 3 in one day. I'd rather not run with a lot of debug logging for a long time if that's what this is going to require, as this is my main workstation.

Quoted 4 lines

The last time I got this log message, my proposed patch did prevent the box from oopsing, so I'd really like to see it go in unless it's just categorically wrong for the caller to pass down a NULL state pointer to drm_dp_add_payload_part2.

Cc Lyude.

Looks like the state parameter was added in commit 4d07b0bc4034 ("drm/display/dp_mst: Move all payload info into the atomic state") and its only use is to get at state->dev for debug logging.

Quoted 6 lines
Quoted 1 line

What's the plan for the parameter? Surely something more than that! :)

I don't think there was any plan for that, or at least I certainly don't even remember adding that D:. It must totally have been by mistake and snuck by review, if that's the only thing that we're using it for I'd say it's definitely fine to just drop it entirely

I guess we could use two patches then, first replace state->dev with mgr->dev as something that can be backported as needed, and second drop the state parameter altogether.

Quoted 6 lines

Jeff, up for it? At least the first one?

BR,
Jani.

Sure. I'm happy to test patches if you send them along.

Thanks,

Signature · 1 line
Jeff Layton <[email protected]>
#10 lore raw
Quoted 48 lines · Jeff Layton
Quoted 47 lines · Jani Nikula
Quoted 35 lines · Lyude Paul
Quoted 34 lines · Jani Nikula
Quoted 22 lines · Jeff Layton
Quoted 4 lines · Wayne

[Public]

Hi Jeff,

Quoted 8 lines

Thanks. I might need more information to understand why we can't retrieve the drm atomic state. Also , "Failed to create MST payload for port" indicates error while configuring DPCD payload ID table. Could you help to provide log with KMS + ATOMIC + DP debug on please? Thanks in advance!

Regards,
Wayne

Possibly. I'm not that familiar with display driver debugging. Can you send me some directions on how to crank up that sort of debug logging?

Note that this problem is _very_ intermittent too: I went about 2 weeks between crashes, and then I got 3 in one day. I'd rather not run with a lot of debug logging for a long time if that's what this is going to require, as this is my main workstation.

Quoted 4 lines

The last time I got this log message, my proposed patch did prevent the box from oopsing, so I'd really like to see it go in unless it's just categorically wrong for the caller to pass down a NULL state pointer to drm_dp_add_payload_part2.

Cc Lyude.

Looks like the state parameter was added in commit 4d07b0bc4034 ("drm/display/dp_mst: Move all payload info into the atomic state") and its only use is to get at state->dev for debug logging.

Quoted 6 lines
Quoted 1 line

What's the plan for the parameter? Surely something more than that! :)

I don't think there was any plan for that, or at least I certainly don't even remember adding that D:. It must totally have been by mistake and snuck by review, if that's the only thing that we're using it for I'd say it's definitely fine to just drop it entirely

I guess we could use two patches then, first replace state->dev with mgr->dev as something that can be backported as needed, and second drop the state parameter altogether.

Quoted 8 lines
Quoted 6 lines

Jeff, up for it? At least the first one?

BR,
Jani.

Sure. I'm happy to test patches if you send them along.

I was hoping to lure you into sending patches. ;)

Anyway, I'm not working on this.

BR,
Jani.

Quoted 2 lines

Thanks,

Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
#11 lore raw

[AMD Official Use Only - General]

Quoted 71 lines

-----Original Message-----
From: Jani Nikula <[email protected]>
Sent: Monday, April 17, 2023 6:30 PM
To: Jeff Layton <[email protected]>; Lyude Paul <[email protected]>; Lin, Wayne <[email protected]>; Alex Deucher <[email protected]>
Cc: David Airlie <[email protected]>; Daniel Vetter <[email protected]>; Deucher, Alexander <[email protected]>; linux- [email protected]; [email protected]
Subject: Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

Quoted 5 lines · Jeff Layton
Quoted 4 lines · Jani Nikula
Quoted 3 lines · Lyude Paul
Quoted 2 lines · Jani Nikula
Quoted 1 line · Jeff Layton

On Fri, 2023-04-14 at 04:40 +0000, Lin, Wayne wrote:

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

[Public]

Hi Jeff,

Thanks. I might need more information to understand why we can't retrieve the drm atomic state. Also , "Failed to create MST payload for port" indicates error while configuring DPCD payload ID table. Could you help to provide log with KMS +

ATOMIC + DP debug on please? Thanks in advance!

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 4 lines

Regards,
Wayne

Possibly. I'm not that familiar with display driver debugging. Can you send me some directions on how to crank up that sort of

debug logging?

Quoted 37 lines
Quoted 36 lines
Quoted 17 lines
Quoted 17 lines
Quoted 10 lines

Note that this problem is _very_ intermittent too: I went about 2 weeks between crashes, and then I got 3 in one day. I'd rather not run with a lot of debug logging for a long time if that's what this is going to require, as this is my main workstation.

The last time I got this log message, my proposed patch did prevent the box from oopsing, so I'd really like to see it go in unless it's just categorically wrong for the caller to pass down a NULL state pointer to drm_dp_add_payload_part2.

Cc Lyude.

Looks like the state parameter was added in commit 4d07b0bc4034 ("drm/display/dp_mst: Move all payload info into the atomic state") and its only use is to get at state->dev for debug logging.

Quoted 7 lines
Quoted 2 lines

What's the plan for the parameter? Surely something more than that! :)

I don't think there was any plan for that, or at least I certainly don't even remember adding that D:. It must totally have been by mistake and snuck by review, if that's the only thing that we're using it for I'd say it's definitely fine to just drop it entirely

I guess we could use two patches then, first replace state->dev with mgr->dev as something that can be backported as needed, and second mgr->drop
the state parameter altogether.

Jeff, up for it? At least the first one?

BR,
Jani.

Quoted 7 lines
Quoted 1 line

Sure. I'm happy to test patches if you send them along.

I was hoping to lure you into sending patches. ;)

Anyway, I'm not working on this.

Hi Jeff,

I probably know the root cause.
But it doesn't need to use the state in the end, I will just rely on the patch that Jani suggested to fix it. I can help to provide the patch later : )

Quoted 8 lines

BR,
Jani.

Quoted 2 lines

Thanks,

--
Jani Nikula, Intel Open Source Graphics Center

--
Regards,
Wayne

#12 lore raw
Quoted 79 lines · Wayne

[AMD Official Use Only - General]

Quoted 75 lines

-----Original Message-----
From: Jani Nikula <[email protected]>
Sent: Monday, April 17, 2023 6:30 PM
To: Jeff Layton <[email protected]>; Lyude Paul <[email protected]>; Lin, Wayne <[email protected]>; Alex Deucher <[email protected]>
Cc: David Airlie <[email protected]>; Daniel Vetter <[email protected]>; Deucher, Alexander <[email protected]>; linux- [email protected]; [email protected]
Subject: Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

Quoted 5 lines · Jeff Layton
Quoted 4 lines · Jani Nikula
Quoted 3 lines · Lyude Paul
Quoted 2 lines · Jani Nikula
Quoted 1 line · Jeff Layton

On Fri, 2023-04-14 at 04:40 +0000, Lin, Wayne wrote:

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

[Public]

Hi Jeff,

Thanks. I might need more information to understand why we can't retrieve the drm atomic state. Also , "Failed to create MST payload for port" indicates error while configuring DPCD payload ID table. Could you help to provide log with KMS +

ATOMIC + DP debug on please? Thanks in advance!

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 4 lines

Regards,
Wayne

Possibly. I'm not that familiar with display driver debugging. Can you send me some directions on how to crank up that sort of

debug logging?

Quoted 30 lines
Quoted 30 lines
Quoted 17 lines
Quoted 17 lines
Quoted 10 lines

Note that this problem is _very_ intermittent too: I went about 2 weeks between crashes, and then I got 3 in one day. I'd rather not run with a lot of debug logging for a long time if that's what this is going to require, as this is my main workstation.

The last time I got this log message, my proposed patch did prevent the box from oopsing, so I'd really like to see it go in unless it's just categorically wrong for the caller to pass down a NULL state pointer to drm_dp_add_payload_part2.

Cc Lyude.

Looks like the state parameter was added in commit 4d07b0bc4034 ("drm/display/dp_mst: Move all payload info into the atomic state") and its only use is to get at state->dev for debug logging.

Quoted 7 lines
Quoted 2 lines

What's the plan for the parameter? Surely something more than that! :)

I don't think there was any plan for that, or at least I certainly don't even remember adding that D:. It must totally have been by mistake and snuck by review, if that's the only thing that we're using it for I'd say it's definitely fine to just drop it entirely

I guess we could use two patches then, first replace state->dev with mgr->dev as something that can be backported as needed, and second mgr->drop
the state parameter altogether.

Quoted 8 lines
Quoted 6 lines

Jeff, up for it? At least the first one?

BR,
Jani.

Sure. I'm happy to test patches if you send them along.

I was hoping to lure you into sending patches. ;)

Quoted 10 lines
Quoted 3 lines

Anyway, I'm not working on this.

Hi Jeff,

I probably know the root cause.
But it doesn't need to use the state in the end, I will just rely on the patch that Jani suggested to fix it. I can help to provide the patch later : )

Sounds good. If you want to send me a patch to solve the root cause, I'll put it in the kernel with the other one I'm testing.

Thanks,

Signature · 1 line
Jeff Layton <[email protected]>
#13 lore raw
In reply to Jani Nikula
Quoted 56 lines · Jani Nikula
Quoted 55 lines · Jeff Layton
Quoted 53 lines · Jani Nikula
Quoted 35 lines · Lyude Paul
Quoted 34 lines · Jani Nikula
Quoted 22 lines · Jeff Layton
Quoted 4 lines · Wayne

[Public]

Hi Jeff,

Quoted 8 lines

Thanks. I might need more information to understand why we can't retrieve the drm atomic state. Also , "Failed to create MST payload for port" indicates error while configuring DPCD payload ID table. Could you help to provide log with KMS + ATOMIC + DP debug on please? Thanks in advance!

Regards,
Wayne

Possibly. I'm not that familiar with display driver debugging. Can you send me some directions on how to crank up that sort of debug logging?

Note that this problem is _very_ intermittent too: I went about 2 weeks between crashes, and then I got 3 in one day. I'd rather not run with a lot of debug logging for a long time if that's what this is going to require, as this is my main workstation.

Quoted 4 lines

The last time I got this log message, my proposed patch did prevent the box from oopsing, so I'd really like to see it go in unless it's just categorically wrong for the caller to pass down a NULL state pointer to drm_dp_add_payload_part2.

Cc Lyude.

Looks like the state parameter was added in commit 4d07b0bc4034 ("drm/display/dp_mst: Move all payload info into the atomic state") and its only use is to get at state->dev for debug logging.

Quoted 6 lines
Quoted 1 line

What's the plan for the parameter? Surely something more than that! :)

I don't think there was any plan for that, or at least I certainly don't even remember adding that D:. It must totally have been by mistake and snuck by review, if that's the only thing that we're using it for I'd say it's definitely fine to just drop it entirely

I guess we could use two patches then, first replace state->dev with mgr->dev as something that can be backported as needed, and second drop the state parameter altogether.

Jeff, up for it? At least the first one?

BR,
Jani.

Quoted 7 lines
Quoted 1 line

Sure. I'm happy to test patches if you send them along.

I was hoping to lure you into sending patches. ;)

Anyway, I'm not working on this.

Ok. I misunderstood, I'll change the patch I've been using to use mgr-

Quoted 1 line

dev instead and will send along a v2 here in a few days (after some

testing).

Signature · 1 line
Jeff Layton <[email protected]>