f2fs: ignore valid ratio when free section count is low
PATCH 1/1 f2fs: ignore valid ratio when free section count is low
From: Daeho Jeong <[email protected]>
Otherwise F2FS will not do GC in background in low free section.
Signed-off-by Daeho Jeong <[email protected]>
--- fs/f2fs/gc.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-)
fs/f2fs/gc.c +12 -6
@@ -391,14 +391,15 @@ static unsigned int get_cb_cost(struct f2fs_sb_info *sbi, unsigned int segno) }static inline unsigned int get_gc_cost (struct f2fs_sb_info *sbi, -unsigned int segno,struct victim_sel_policy *p) +unsigned int segno,struct victim_sel_policy *p, +unsigned int valid_thresh_ratio) {if (p->alloc_mode ==SSR )return get_seg_entry (sbi, segno)->ckpt_valid_blocks; -if (p->one_time_gc && (get_valid_blocks (sbi, segno, true) >= -CAP_BLKS_PER_SEC (sbi) * sbi->gc_thread->valid_thresh_ratio / -100 )) +if (p->one_time_gc && (valid_thresh_ratio <100 ) && + (get_valid_blocks (sbi, segno, true) >= +CAP_BLKS_PER_SEC (sbi) * valid_thresh_ratio /100 ))return UINT_MAX ;/* alloc_mode == LFS */
@@ -779,6 +780,7 @@ int f2fs_get_victim(struct f2fs_sb_info *sbi, unsigned int *result,unsigned int secno, last_victim;unsigned int last_segment;unsigned int nsearched; +unsigned int valid_thresh_ratio =100 ;bool is_atgc;int ret =0 ;
@@ -788,7 +790,11 @@ int f2fs_get_victim(struct f2fs_sb_info *sbi, unsigned int *result, p.alloc_mode = alloc_mode; p.age = age; p.age_threshold = sbi->am.age_threshold; - p.one_time_gc = one_time; +if (one_time) { + p.one_time_gc = one_time; +if (has_enough_free_secs (sbi,0 ,NR_PERSISTENT_LOG )) + valid_thresh_ratio = sbi->gc_thread->valid_thresh_ratio; + } retry:select_policy (sbi, gc_type, type, &p);
@@ -914,7 +920,7 @@ int f2fs_get_victim(struct f2fs_sb_info *sbi, unsigned int *result, goto next; } - cost =get_gc_cost (sbi, segno, &p); + cost =get_gc_cost (sbi, segno, &p, valid_thresh_ratio);if (p.min_cost > cost) { p.min_segno = segno;
Signature · 1 line
2.50.0.727.gbf7dc18ff4-goog
Quoted 5 lines · Daeho Jeong
From: Daeho Jeong <[email protected]>
Otherwise F2FS will not do GC in background in low free section.
Signed-off-by Daeho Jeong <[email protected]>
Reviewed-by Chao Yu <[email protected]>
Thanks,
This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <[email protected]>:
Hello:
This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:
Quoted 8 lines · On Fri, 18 Jul 2025 15:04:31 -0700 you wrote:
From: Daeho Jeong <[email protected]>
Otherwise F2FS will not do GC in background in low free section.
Signed-off-by Daeho Jeong <[email protected]>--- fs/f2fs/gc.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-)
Here is the summary with links:
- [f2fs-dev] f2fs: ignore valid ratio when free section count is low
https://git.kernel.org/jaegeuk/f2fs/c/e6d5e789c3b2
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html