Skip to contentSkip to conversation

package/libgtk3: add missing !BR2_STATIC_LIBS dependency

PATCH Applied Thomas Petazzoni via buildroot 1 participant 3 messages Sep 15 – Sep 25

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libgtk3: add missing !BR2_STATIC_LIBS dependency

libgtk3 selects at-spi2-core, so it should inherit its !BR2_STATIC_LIBS, which this commit does.

This has been an issue since libgtk3 started using at-spi2-core instead of atk in commit 2c3ca7bea1de76163aeef432412eb14551ed0581.

Fixes 2c3ca7bea1de76163aeef432412eb14551ed0581 ("package/atk: remove package")
---
 package/libgtk3/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/libgtk3/Config.in +4 -2
index 52ee50db49..f7618832f1 100644
@@ -1,10 +1,11 @@
-comment "libgtk3 needs a toolchain w/ wchar, threads, C++, gcc >= 4.9"
+comment "libgtk3 needs a toolchain w/ wchar, threads, C++, gcc >= 4.9, dynamic library"
 	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS
 	depends on BR2_USE_MMU
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP || \
 		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
-		!BR2_TOOLCHAIN_HAS_THREADS
+		!BR2_TOOLCHAIN_HAS_THREADS || \
+		BR2_STATIC_LIBS
 
 comment "libgtk3 needs an OpenGL or an OpenGL-EGL backend"
 	depends on BR2_USE_MMU
@@ -23,6 +24,7 @@ config BR2_PACKAGE_LIBGTK3
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # pango -> harfbuzz
 	depends on BR2_PACKAGE_HAS_LIBEGL || \
 		BR2_PACKAGE_HAS_LIBGL
+	depends on !BR2_STATIC_LIBS # at-spi2-core
 	select BR2_PACKAGE_AT_SPI2_CORE
 	select BR2_PACKAGE_CAIRO
 	select BR2_PACKAGE_CAIRO_PNG
Signature · 6 lines
2.55.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 8 lines · Thomas Petazzoni via buildroot

libgtk3 selects at-spi2-core, so it should inherit its !BR2_STATIC_LIBS, which this commit does.

This has been an issue since libgtk3 started using at-spi2-core instead of atk in commit 2c3ca7bea1de76163aeef432412eb14551ed0581.

Fixes 2c3ca7bea1de76163aeef432412eb14551ed0581 ("package/atk: remove package")

Applied to master, thanks.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw
In reply to Thomas Petazzoni via buildroot

In reply of:

Quoted 8 lines

libgtk3 selects at-spi2-core, so it should inherit its !BR2_STATIC_LIBS, which this commit does.

This has been an issue since libgtk3 started using at-spi2-core instead of atk in commit 2c3ca7bea1de76163aeef432412eb14551ed0581.

Fixes 2c3ca7bea1de76163aeef432412eb14551ed0581 ("package/atk: remove package")

Applied to 2025.02.x, 2026.08.x. Thanks

Quoted 23 lines
---
 package/libgtk3/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/libgtk3/Config.in +3 -2
index 52ee50db49..f7618832f1 100644
@@ -1,10 +1,11 @@
-comment "libgtk3 needs a toolchain w/ wchar, threads, C++, gcc >= 4.9"
+comment "libgtk3 needs a toolchain w/ wchar, threads, C++, gcc >= 4.9, dynamic library"
 	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS
 	depends on BR2_USE_MMU
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP || \
 		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
-		!BR2_TOOLCHAIN_HAS_THREADS
+		!BR2_TOOLCHAIN_HAS_THREADS || \
+		BR2_STATIC_LIBS
 
 comment "libgtk3 needs an OpenGL or an OpenGL-EGL backend"
 	depends on BR2_USE_MMU

package/libgtk3/Config.in config BR2_PACKAGE_LIBGTK3 · line 30

Quoted 7 lines
package/libgtk3/Config.in +1 -0
@@ -23,6 +24,7 @@ config BR2_PACKAGE_LIBGTK3
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # pango -> harfbuzz
 	depends on BR2_PACKAGE_HAS_LIBEGL || \
 		BR2_PACKAGE_HAS_LIBGL
+	depends on !BR2_STATIC_LIBS # at-spi2-core
 	select BR2_PACKAGE_AT_SPI2_CORE
 	select BR2_PACKAGE_CAIRO
 	select BR2_PACKAGE_CAIRO_PNG

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot