selftests/mm: clean up build output and verbosity
Subsystems (3)
v3 cover selftests/mm: clean up build output and verbosity
Currently, the build process for the mm selftests is unnecessarily noisy.
First, it leaks raw compiler errors during the liburing feature probe if the headers are missing, which is confusing since the build system already handles this gracefully with a clear warning.
Second, the specific 32-bit and 64-bit compilation targets ignore the standard kbuild verbosity settings, always printing their full compiler commands even during a default quiet build.
Notes:
My email address has changed due to employment change. Previous Signed-off-by was with <[email protected]>. Resent it after -rc1, as requested by Andrew.
V3:
- Nothing special but email change.
V2:
- Drop 2/4, 3/4 from v1 to v2, since Andrew wasn't able to confirm the patch works for the rarely happening issue now, so I decided to just hand on the process of the parallel issue.
- Refine the 4/4 patch only to hide compiler errors when missing liburing.
Li Wang (2):
selftests/mm: respect build verbosity settings for 32/64-bit targets selftests/mm: suppress compiler error in liburing check
tools/testing/selftests/mm/Makefile | 9 ++++++--- tools/testing/selftests/mm/check_config.sh | 2 +- 2 files changed, 7 insertions(+), 4 deletions(-)
Signature · 1 line
2.53.0
PATCH v3 1/2 selftests/mm: respect build verbosity settings for 32/64-bit targets
The 32-bit and 64-bit compilation rules invoke $(CC) directly, bypassing the $(Q) quiet prefix and $(call msg,...) helper used by the rest of the selftests build system. This causes these rules to always print the full compiler command line, even when V=0 (the default).
Wrap the commands with $(Q) and $(call msg,CC,,$@) to match the convention used by lib.mk, so that quiet and verbose builds behave consistently across all targets.
==== Build logs ====
...
CC merge CC rmap CC soft-dirty
gcc -Wall -O2 -I /usr/src/25/tools/testing/selftests/../../..
-isystem /usr/src/25/tools/testing/selftests/../../../usr/include -isystem /usr/src/25/tools/testing/selftests/../../../tools/include/uapi -Wunreachable-code -U_FORTIFY_SOURCE -no-pie -D_GNU_SOURCE= -I/usr/src/25/tools/testing/selftests/../../../tools/testing/selftests -m32 -mxsave protection_keys.c vm_util.c thp_settings.c pkey_util.c -lrt -lpthread -lm -lrt -ldl -lm
-o /usr/src/25/tools/testing/selftests/mm/protection_keys_32
gcc -Wall -O2 -I /usr/src/25/tools/testing/selftests/../../..
-isystem /usr/src/25/tools/testing/selftests/../../../usr/include -isystem /usr/src/25/tools/testing/selftests/../../../tools/include/uapi -Wunreachable-code -U_FORTIFY_SOURCE -no-pie -D_GNU_SOURCE= -I/usr/src/25/tools/testing/selftests/../../../tools/testing/selftests -m32 -mxsave pkey_sighandler_tests.c vm_util.c thp_settings.c pkey_util.c -lrt -lpthread -lm -lrt -ldl -lm
-o /usr/src/25/tools/testing/selftests/mm/pkey_sighandler_tests_32
...
--- tools/testing/selftests/mm/Makefile | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
tools/testing/selftests/mm/Makefile +4 -2
@@ -216,7 +216,8 @@ ifeq ($(CAN_BUILD_I386),1) $(BINARIES_32): CFLAGS += -m32 -mxsave $(BINARIES_32): LDLIBS += -lrt -ldl -lm $(BINARIES_32): $(OUTPUT)/%_32: %.c - $(CC) $(CFLAGS) $(EXTRA_CFLAGS) $(notdir $^) $(LDLIBS) -o $@ + $(call msg,CC,,$@) + $(Q)$(CC) $(CFLAGS) $(EXTRA_CFLAGS) $(notdir $^) $(LDLIBS) -o $@ $(foreach t,$(VMTARGETS),$(eval $(call gen-target-rule-32,$(t)))) endif
@@ -224,7 +225,8 @@ ifeq ($(CAN_BUILD_X86_64),1) $(BINARIES_64): CFLAGS += -m64 -mxsave $(BINARIES_64): LDLIBS += -lrt -ldl $(BINARIES_64): $(OUTPUT)/%_64: %.c - $(CC) $(CFLAGS) $(EXTRA_CFLAGS) $(notdir $^) $(LDLIBS) -o $@ + $(call msg,CC,,$@) + $(Q)$(CC) $(CFLAGS) $(EXTRA_CFLAGS) $(notdir $^) $(LDLIBS) -o $@ $(foreach t,$(VMTARGETS),$(eval $(call gen-target-rule-64,$(t)))) endif
Signature · 1 line
2.53.0
Re: [PATCH v3 1/2] selftests/mm: respect build verbosity settings for 32/64-bit targets
Quoted 32 lines · Li Wang
The 32-bit and 64-bit compilation rules invoke $(CC) directly, bypassing the $(Q) quiet prefix and $(call msg,...) helper used by the rest of the selftests build system. This causes these rules to always print the full compiler command line, even when V=0 (the default).
Wrap the commands with $(Q) and $(call msg,CC,,$@) to match the convention used by lib.mk, so that quiet and verbose builds behave consistently across all targets.
==== Build logs ====
...CC merge CC rmap CC soft-dirtygcc -Wall -O2 -I
/usr/src/25/tools/testing/selftests/../../..
-isystem/usr/src/25/tools/testing/selftests/../../../usr/include-isystem/usr/src/25/tools/testing/selftests/../../../tools/include/uapi-Wunreachable-code -U_FORTIFY_SOURCE -no-pie -D_GNU_SOURCE= -I/usr/src/25/tools/testing/selftests/../../../tools/testing/selftests -m32 -mxsaveprotection_keys.cvm_util.cthp_settings.cpkey_util.c-lrt -lpthread -lm -lrt -ldl -lm
-o/usr/src/25/tools/testing/selftests/mm/protection_keys_32
gcc -Wall -O2 -I/usr/src/25/tools/testing/selftests/../../..
-isystem/usr/src/25/tools/testing/selftests/../../../usr/include-isystem/usr/src/25/tools/testing/selftests/../../../tools/include/uapi-Wunreachable-code -U_FORTIFY_SOURCE -no-pie -D_GNU_SOURCE= -I/usr/src/25/tools/testing/selftests/../../../tools/testing/selftests -m32 -mxsavepkey_sighandler_tests.cvm_util.cthp_settings.cpkey_util.c-lrt -lpthread -lm -lrt -ldl -lm
-o/usr/src/25/tools/testing/selftests/mm/pkey_sighandler_tests_32
...
Quoted 4 lines
Reported-by Andrew Morton <[email protected]>Signed-off-by Li Wang <[email protected]>Tested-by Andrew Morton <[email protected]>---
Great
Signature · 3 lines
Cheers, David
PATCH v3 2/2 selftests/mm: suppress compiler error in liburing check
In reply to Li WangWhen building the mm selftests on a system without liburing development headers, check_config.sh leaks a raw compiler error:
/tmp/tmp.kIIOIqwe3n.c:2:10: fatal error: liburing.h: No such file or directory
2 | #include <liburing.h>
| ^~~~~~~~~~~~
Since this is an expected failure during the configuration probe, redirect the compiler output to /dev/null to hide it.
And the build system prints a clear warning when this occurs:
Warning: missing liburing support. Some tests will be skipped.
Because the user is properly notified about the missing dependency, the raw compiler error is redundant and only confuse users.
Additionally, update the Makefile to use $(Q) and $(call msg,...) for the check_config.sh execution. This aligns the probe with standard kbuild output formatting, providing a clean "CHK" message instead of printing the raw command during the build.
--- tools/testing/selftests/mm/Makefile | 3 ++- tools/testing/selftests/mm/check_config.sh | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-)
tools/testing/selftests/mm/Makefile +2 -1
@@ -263,7 +263,8 @@ $(OUTPUT)/migration: LDLIBS += -lnuma $(OUTPUT)/rmap: LDLIBS += -lnuma local_config.mk local_config.h: check_config.sh - CC="$(CC)" CFLAGS="$(CFLAGS)" ./check_config.sh + $(call msg,CHK,config,$@) + $(Q)CC="$(CC)" CFLAGS="$(CFLAGS)" ./check_config.sh EXTRA_CLEAN += local_config.mk local_config.h
tools/testing/selftests/mm/check_config.sh +1 -1
@@ -16,7 +16,7 @@ echo "#include <sys/types.h>" > $tmpfile_c echo "#include <liburing.h>" >> $tmpfile_c echo "int func(void) { return 0; }" >> $tmpfile_c -$CC $CFLAGS -c $tmpfile_c -o $tmpfile_o +$CC $CFLAGS -c $tmpfile_c -o $tmpfile_o >/dev/null 2>&1 if [ -f $tmpfile_o ]; then echo "#define LOCAL_CONFIG_HAVE_LIBURING 1" > $OUTPUT_H_FILE
Signature · 1 line
2.53.0
Re: [PATCH v3 2/2] selftests/mm: suppress compiler error in liburing check
Quoted 17 lines · Li Wang
When building the mm selftests on a system without liburing development headers,
check_config.shleaks a raw compiler error:
/tmp/tmp.kIIOIqwe3n.c:2:10: fatal error:liburing.h: No such file or directory
2 | #include <liburing.h>
| ^~~~~~~~~~~~Since this is an expected failure during the configuration probe, redirect the compiler output to
/dev/nullto hide it.And the build system prints a clear warning when this occurs:
Warning: missing liburing support. Some tests will be skipped.
Because the user is properly notified about the missing dependency, the raw compiler error is redundant and only confuse users.
Quoted 7 lines
Additionally, update the
Makefileto use $(Q) and $(call msg,...) for thecheck_config.shexecution. This aligns the probe with standard kbuild output formatting, providing a clean "CHK" message instead of printing the raw command during the build.Signed-off-by Li Wang <[email protected]>---
Thanks!
Signature · 3 lines
Cheers, David
David Hildenbrand (Arm)
maintainerQuoted 6 lines · Li Wang
Currently, the build process for the mm selftests is unnecessarily noisy.
First, it leaks raw compiler errors during the liburing feature probe if the headers are missing, which is confusing since the build system already handles this gracefully with a clear warning.
Quoted 7 lines
Second, the specific 32-bit and 64-bit compilation targets ignore the standard kbuild verbosity settings, always printing their full compiler commands even during a default quiet build.
Notes:
My email address has changed due to employment change. Previous Signed-off-by was with <[email protected]>.
:(
As a former RH'er, I'm deeply sorry for what has happened there, really.
Thank you for continuing to contribute upstream, highly appreciated!
Signature · 3 lines
Cheers, David
Quoted 15 lines · David Hildenbrand (Arm)
Quoted 6 lines · Li Wang
Currently, the build process for the mm selftests is unnecessarily noisy.
First, it leaks raw compiler errors during the liburing feature probe if the headers are missing, which is confusing since the build system already handles this gracefully with a clear warning.
Quoted 7 lines
Second, the specific 32-bit and 64-bit compilation targets ignore the standard kbuild verbosity settings, always printing their full compiler commands even during a default quiet build.
Notes:
My email address has changed due to employment change. Previous Signed-off-by was with <[email protected]>.
Quoted 5 lines
:(
As a former RH'er, I'm deeply sorry for what has happened there, really.
Thank you for continuing to contribute upstream, highly appreciated!
Thank you David, I got a new account from kernel org yesterday:
In the next, I hope to dedicate this email address to Linux and LTP development work.
Signature · 2 lines
Regards, Li Wang