When to kmap PT BOs?
Hi,
Currently PT BOs are kmapped in amdgpu_vm_update_directories. That means, to avoid kernel oopses after page table evictions, I need to call amdgpu_vm_update_directories before calling amdgpu_vm_bo_update.
But amdgpu_vm_bo_update can also move PTs on the vm->relocated list during huge page handling. That means I also need to call amdgpu_vm_update_directories after amdgpu_vm_bo_update.
I think a better solution is to move kmapping out of amdgpu_vm_update_directories. But I'm not sure what's the right place for it. Any suggestions? For a quick fix for kernel oopses after page table evictions in the ROCm 1.9 release I'll call amdgpu_vm_update_directories twice. If there are no new entries on the vm->relocated lists, the second call won't add much overhead anyway.
Thanks,
Felix
Signature · 13 lines
F e l i x K u e h l i n g PMTS Software Development Engineer | Linux Compute Kernel 1 Commerce Valley Dr. East, Markham, ON L3T 7X6 Canada (O) +1(289)695-1597 _ _ _ _____ _____ / \ | \ / | | _ \ \ _ | / A \ | \M/ | | |D) ) /|_| | /_/ \_\ |_| |_| |_____/ |__/ \| facebook.com/AMD | amd.com _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 7a9aa339-e771-c667-4eb8-6f30c7c37c15-5C7GfCeVMHo@public.gmane.org
Quoted 9 lines · Felix Kuehling
Hi,
Currently PT BOs are kmapped in
amdgpu_vm_update_directories. That means, to avoid kernel oopses after page table evictions, I need to callamdgpu_vm_update_directoriesbefore callingamdgpu_vm_bo_update.But
amdgpu_vm_bo_updatecan also move PTs on thevm->relocatedlist during huge page handling. That means I also need to callamdgpu_vm_update_directoriesafteramdgpu_vm_bo_update.
Not very familiar with huge page handling.
But from code, maybe we can kmap the PTE entry right here.
Then it will update current non-huge page PTE later in amdgpu_vm_update_ptes().
Regards,
Jerry
Quoted 11 lines
I think a better solution is to move kmapping out of
amdgpu_vm_update_directories. But I'm not sure what's the right place for it. Any suggestions? For a quick fix for kernel oopses after page table evictions in the ROCm 1.9 release I'll callamdgpu_vm_update_directoriestwice. If there are no new entries on thevm->relocatedlists, the second call won't add much overhead anyway.Thanks,
Felix
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Hi Felix,
ah, crap you are right.
I moved the kmap to amdgpu_vm_update_directories() because I thought that it would be cleaner to have that closer where it is used.
But that sounds like it doesn't work as intended. Going to revert that patch.
Thanks,
Christian.
Am 30.08.2018 um 00:30 schrieb Felix Kuehling:
Quoted 17 lines
Hi,
Currently PT BOs are kmapped in
amdgpu_vm_update_directories. That means, to avoid kernel oopses after page table evictions, I need to callamdgpu_vm_update_directoriesbefore callingamdgpu_vm_bo_update.But
amdgpu_vm_bo_updatecan also move PTs on thevm->relocatedlist during huge page handling. That means I also need to callamdgpu_vm_update_directoriesafteramdgpu_vm_bo_update.I think a better solution is to move kmapping out of
amdgpu_vm_update_directories. But I'm not sure what's the right place for it. Any suggestions? For a quick fix for kernel oopses after page table evictions in the ROCm 1.9 release I'll callamdgpu_vm_update_directoriestwice. If there are no new entries on thevm->relocatedlists, the second call won't add much overhead anyway.
Quoted 3 lines
Thanks,
Felix
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx