con3270.o is built twice, leading to errors
Hi,
if I create an s390 defconfig:
mkdir /tmp/s390/
make O=/tmp/s390/ ARCH=s390 CROSS_COMPILE=s390x-suse-linux- defconfig
And then if I try for a couple times:
make O=/tmp/s390/ -j17 ARCH=s390 CROSS_COMPILE=s390x-suse-linux- drivers/s390/char/con3270.o
Most of the time, I get:
make[1]: Entering directory '/tmp/s390'
GEN Makefile CALL /home/latest/linux/scripts/checksyscalls.sh CC drivers/s390/char/con3270.o CC drivers/s390/char/con3270.o
I.e. it is built twice.
Sometimes, I also get an error:
fixdep: error opening file: drivers/s390/char/.con3270.o.d: No such file or directory make[4]: *** [/home/latest/linux/scripts/Makefile.build:243: drivers/s390/char/con3270.o] Error 2 make[4]: *** Deleting file 'drivers/s390/char/con3270.o'
make[3]: *** [/home/latest/linux/scripts/Makefile.build:477: drivers]
Obviously due to some race.
Any ideas what is going on?
thanks,
Signature · 2 lines
js suse labs
Quoted 27 lines · On Fri, Jul 14, 2023 at 08:33:46AM +0200 Jiri Slaby wrote:
Hi,
if I create an s390 defconfig:
mkdir/tmp/s390/
make O=/tmp/s390/ ARCH=s390 CROSS_COMPILE=s390x-suse-linux- defconfigAnd then if I try for a couple times:
make O=/tmp/s390/ -j17 ARCH=s390 CROSS_COMPILE=s390x-suse-linux-drivers/s390/char/con3270.oMost of the time, I get:
make[1]: Entering directory '/tmp/s390'GEN Makefile CALL /home/latest/linux/scripts/checksyscalls.sh CC drivers/s390/char/con3270.o CC drivers/s390/char/con3270.oI.e. it is built twice.
Sometimes, I also get an error:
fixdep: error opening file:drivers/s390/char/.con3270.o.d: No such file or directory
make[4]: *** [/home/latest/linux/scripts/Makefile.build:243:drivers/s390/char/con3270.o] Error 2
make[4]: *** Deleting file 'drivers/s390/char/con3270.o' make[3]: *** [/home/latest/linux/scripts/Makefile.build:477: drivers]
Quoted 3 lines
Obviously due to some race.
Any ideas what is going on?
Which reason does compiling with V=2 reveal?
Kind regards,
Nicolas
Quoted 28 lines · Jiri Slaby
Hi,
if I create an s390 defconfig:
mkdir/tmp/s390/
make O=/tmp/s390/ ARCH=s390 CROSS_COMPILE=s390x-suse-linux- defconfigAnd then if I try for a couple times:
make O=/tmp/s390/ -j17 ARCH=s390 CROSS_COMPILE=s390x-suse-linux-drivers/s390/char/con3270.oMost of the time, I get:
make[1]: Entering directory '/tmp/s390'GEN Makefile CALL /home/latest/linux/scripts/checksyscalls.sh CC drivers/s390/char/con3270.o CC drivers/s390/char/con3270.oI.e. it is built twice.
Sometimes, I also get an error:
fixdep: error opening file:drivers/s390/char/.con3270.o.d: No such file or directory
make[4]: *** [/home/latest/linux/scripts/Makefile.build:243:drivers/s390/char/con3270.o] Error 2
make[4]: *** Deleting file 'drivers/s390/char/con3270.o' make[3]: *** [/home/latest/linux/scripts/Makefile.build:477: drivers]
Quoted 3 lines
Obviously due to some race.
Any ideas what is going on?
The reason is because ARCH=s390 descends into drivers/s390/ in a non-standard way.
See arch/s390/Makefile line 122.
This is a corner case in single builds, and I do not know how to make it work.
I really hope arch maintainers will follow the standard obj-y syntax unless there is a strong reason to opt out.
The following patch will fix the issue.
arch/s390/Makefile +0 -1
@@ -119,7 +119,6 @@ export KBUILD_CFLAGS_DECOMPRESSOR OBJCOPYFLAGS := -O binary libs-y += arch/s390/lib/ -drivers-y += drivers/s390/ boot := arch/s390/boot syscalls := arch/s390/kernel/syscalls
drivers/Makefile +2 -0
@@ -195,3 +195,5 @@ obj-$(CONFIG_PECI) += peci/ obj-$(CONFIG_HTE) += hte/ obj-$(CONFIG_DRM_ACCEL) += accel/ obj-$(CONFIG_CDX_BUS) += cdx/ + +obj-$(CONFIG_S390) += s390/
Signature · 2 lines
Best Regards Masahiro Yamada
Jiri Slaby
Tested-byQuoted 47 lines · Masahiro Yamada
Quoted 28 lines · Jiri Slaby
Hi,
if I create an s390 defconfig:
mkdir/tmp/s390/
make O=/tmp/s390/ ARCH=s390 CROSS_COMPILE=s390x-suse-linux- defconfigAnd then if I try for a couple times:
make O=/tmp/s390/ -j17 ARCH=s390 CROSS_COMPILE=s390x-suse-linux-drivers/s390/char/con3270.oMost of the time, I get:
make[1]: Entering directory '/tmp/s390'GEN Makefile CALL /home/latest/linux/scripts/checksyscalls.sh CC drivers/s390/char/con3270.o CC drivers/s390/char/con3270.oI.e. it is built twice.
Sometimes, I also get an error:
fixdep: error opening file:drivers/s390/char/.con3270.o.d: No such file or directory
make[4]: *** [/home/latest/linux/scripts/Makefile.build:243:drivers/s390/char/con3270.o] Error 2
make[4]: *** Deleting file 'drivers/s390/char/con3270.o' make[3]: *** [/home/latest/linux/scripts/Makefile.build:477: drivers]Quoted 3 lines
Obviously due to some race.
Any ideas what is going on?
The reason is because ARCH=s390 descends into
drivers/s390/in a non-standard way.See
arch/s390/Makefileline 122.This is a corner case in single builds, and I do not know how to make it work.
Quoted 5 lines
I really hope arch maintainers will follow the standard obj-y syntax unless there is a strong reason to opt out.
The following patch will fix the issue.
Will you send it as a patch?
Quoted 17 lines
arch/s390/Makefile +0
-1@@ -119,7 +119,6 @@ export KBUILD_CFLAGS_DECOMPRESSOR OBJCOPYFLAGS := -O binary libs-y += arch/s390/lib/ -drivers-y += drivers/s390/ boot := arch/s390/boot syscalls := arch/s390/kernel/syscallsdrivers/Makefile +0
-0
drivers/Makefile obj-$(CONFIG_PECI) += peci/ · line 199
Quoted 5 lines
drivers/Makefile +2
-0@@ -195,3 +195,5 @@ obj-$(CONFIG_PECI) += peci/ obj-$(CONFIG_HTE) += hte/ obj-$(CONFIG_DRM_ACCEL) += accel/ obj-$(CONFIG_CDX_BUS) += cdx/ + +obj-$(CONFIG_S390) += s390/
thanks,
Signature · 2 lines
js suse labs
arch/um's ssl.o [was: con3270.o] is built twice, leading to errors
In reply to Jiri SlabyQuoted 9 lines · Jiri Slaby
Hi,
if I create an s390 defconfig:
mkdir/tmp/s390/
make O=/tmp/s390/ ARCH=s390 CROSS_COMPILE=s390x-suse-linux- defconfigAnd then if I try for a couple times:
make O=/tmp/s390/ -j17 ARCH=s390 CROSS_COMPILE=s390x-suse-linux-drivers/s390/char/con3270.o
Quoted 8 lines
Most of the time, I get:
make[1]: Entering directory '/tmp/s390'
GENMakefile
CALL/home/latest/linux/scripts/checksyscalls.shCCdrivers/s390/char/con3270.o
CCdrivers/s390/char/con3270.oI.e. it is built twice.
Similarly, another tty driver, another arch (um):
$ make O=../a/arch/um/ -j17 ARCH=um arch/um/drivers/ssl.o V=2 GEN Makefile - due to target is PHONY CALL scripts/checksyscalls.sh - due to target is PHONY CC arch/um/drivers/ssl.o - due to: arch/um/drivers/ssl.c CC arch/um/drivers/ssl.o - due to: arch/um/drivers/ssl.c
This leads often to corrupted arch/um/arch/um/drivers/.ssl.o.cmd.
But in this case, I see:
obj-$(CONFIG_SSL) += ssl.o
So is this has this a different root cause?
Quoted 11 lines
Sometimes, I also get an error:
fixdep: error opening file:drivers/s390/char/.con3270.o.d: No such file or directory make[4]: *** [/home/latest/linux/scripts/Makefile.build:243:drivers/s390/char/con3270.o] Error 2 make[4]: *** Deleting file 'drivers/s390/char/con3270.o'
make[3]: *** [/home/latest/linux/scripts/Makefile.build:477: drivers]Obviously due to some race.
Any ideas what is going on?
thanks,
Signature · 2 lines
js suse labs
Re: arch/um's ssl.o [was: con3270.o] is built twice, leading to errors
Quoted 29 lines · Jiri Slaby
Quoted 10 lines · Jiri Slaby
Hi,
if I create an s390 defconfig:
mkdir/tmp/s390/
make O=/tmp/s390/ ARCH=s390 CROSS_COMPILE=s390x-suse-linux- defconfigAnd then if I try for a couple times:
make O=/tmp/s390/ -j17 ARCH=s390 CROSS_COMPILE=s390x-suse-linux-drivers/s390/char/con3270.oQuoted 8 lines
Most of the time, I get:
make[1]: Entering directory '/tmp/s390'GEN Makefile CALL /home/latest/linux/scripts/checksyscalls.sh CC drivers/s390/char/con3270.o CC drivers/s390/char/con3270.oI.e. it is built twice.
Similarly, another tty driver, another arch (um):
$ make O=../a/arch/um/ -j17 ARCH=um arch/um/drivers/ssl.o V=2 GEN Makefile - due to target is PHONY CALL scripts/checksyscalls.sh - due to target is PHONY CC arch/um/drivers/ssl.o - due to: arch/um/drivers/ssl.c CC arch/um/drivers/ssl.o - due to: arch/um/drivers/ssl.c
Quoted 6 lines
This leads often to corrupted
arch/um/arch/um/drivers/.ssl.o.cmd.But in this case, I see:
obj-$(CONFIG_SSL) += ssl.oSo is this has this a different root cause?
It is a similar symptom.
See arch/um/Makefile line 26
core-y += $(ARCH_DIR)/kernel/ \
$(ARCH_DIR)/drivers/ \
$(ARCH_DIR)/os-$(OS)/I will send a patch.
Quoted 19 lines
Quoted 9 lines
Sometimes, I also get an error:
fixdep: error opening file:drivers/s390/char/.con3270.o.d: No such file or directory
make[4]: *** [/home/latest/linux/scripts/Makefile.build:243:drivers/s390/char/con3270.o] Error 2
make[4]: *** Deleting file 'drivers/s390/char/con3270.o' make[3]: *** [/home/latest/linux/scripts/Makefile.build:477: drivers]Quoted 5 lines
Obviously due to some race.
Any ideas what is going on?
thanks,
--
js
suse labs
Signature · 2 lines
Best Regards Masahiro Yamada