Skip to contentSkip to conversation

Change in openvpn[master]: Clarify that the tls-crypt-v2-verify has a very limited env set

Openvpn-devel In review plaisthos (Code Review) 2 participants 7 messages Jan 3, 2024 – Jan 5, 2024 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): gerrit.1704298871000.Ida4d22455c51773b6713caf94a4b4fbe136a6ded@...2715...

#1 lore raw

Attention is currently required from: flichtenheld.

Hello flichtenheld,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/488?usp=email

to review the following change.

Change subject: Clarify that the tls-crypt-v2-verify has a very limited env set
......................................................................

Clarify that the tls-crypt-v2-verify has a very limited env set

Change-Id Ida4d22455c51773b6713caf94a4b4fbe136a6ded

---
M doc/man-sections/tls-options.rst

1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/88/488/1

doc/man-sections/tls-options.rst +2 -1
index 4c45b10..aa8858c 100644
@@ -538,7 +538,8 @@
   stack (including the notoriously dangerous X.509 and ASN.1 stacks) to
   the connecting client.
 
-  OpenVPN supplies the following environment variables to the command:
+  OpenVPN supplies the following environment variables to the command (and
+  only these variables. The normal environment variables are NOT present):
 
   * :code:`script_type` is set to :code:`tls-crypt-v2-verify`
 

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/488?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ida4d22455c51773b6713caf94a4b4fbe136a6ded
Gerrit-Change-Number: 488
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-MessageType: newchange

#2 lore raw
In reply to a message not in the archive

Attention is currently required from: flichtenheld.

Hello flichtenheld,

I'd like you to reexamine a change. Please visit

    http://gerrit.openvpn.net/c/openvpn/+/488?usp=email

to look at the new patch set (#2).

Change subject: Clarify that the tls-crypt-v2-verify has a very limited env set
......................................................................

Clarify that the tls-crypt-v2-verify has a very limited env set

Change-Id Ida4d22455c51773b6713caf94a4b4fbe136a6ded

---
M doc/man-sections/tls-options.rst

1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/88/488/2

doc/man-sections/tls-options.rst +3 -1
index 4c45b10..460cecf 100644
@@ -538,7 +538,9 @@
   stack (including the notoriously dangerous X.509 and ASN.1 stacks) to
   the connecting client.
 
-  OpenVPN supplies the following environment variables to the command:
+  OpenVPN supplies the following environment variables to the command (and
+  only these variables. The normal environment variables available for
+  other scripts are NOT present):
 
   * :code:`script_type` is set to :code:`tls-crypt-v2-verify`
 

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/488?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ida4d22455c51773b6713caf94a4b4fbe136a6ded
Gerrit-Change-Number: 488
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-MessageType: newpatchset

#3 lore raw
In reply to a message not in the archive

Attention is currently required from: flichtenheld, plaisthos.

cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/488?usp=email )

Change subject: Clarify that the tls-crypt-v2-verify has a very limited env set
......................................................................

Patch Set 2: Code-Review+2

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/488?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ida4d22455c51773b6713caf94a4b4fbe136a6ded
Gerrit-Change-Number: 488
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Fri, 05 Jan 2024 14:17:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

#4 lore raw

PATCH v2 1/1 Clarify that the tls-crypt-v2-verify has a very limited env set

In reply to a message not in the archive

From: Arne Schwabe <[email protected]...>

Change-Id Ida4d22455c51773b6713caf94a4b4fbe136a6ded

---

This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/488
This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above):
Gert Doering <[email protected]...>

doc/man-sections/tls-options.rst +3 -1
index 4c45b10..460cecf 100644
@@ -538,7 +538,9 @@
   stack (including the notoriously dangerous X.509 and ASN.1 stacks) to
   the connecting client.
 
-  OpenVPN supplies the following environment variables to the command:
+  OpenVPN supplies the following environment variables to the command (and
+  only these variables. The normal environment variables available for
+  other scripts are NOT present):
 
   * :code:`script_type` is set to :code:`tls-crypt-v2-verify`
 
#5 lore raw

[Openvpn-devel] [PATCH applied] Re: Clarify that the tls-crypt-v2-verify has a very limited env set

More clear documentation helps avoid user frustration...

Your patch has been applied to the master and release/2.6 branch.

commit a9fe012ca64d81af37a08666d3e4e74250113db2 (master) commit 322b11ab47763e0d062576cdc907351c700ef371 (release/2.6)

Author: Arne Schwabe
Date:   Fri Jan 5 15:24:32 2024 +0100
     Clarify that the tls-crypt-v2-verify has a very limited env set

     Signed-off-by: Arne Schwabe <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg27944.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering

#6 lore raw
In reply to a message not in the archive

cron2 has uploaded a new patch set (#3) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/488?usp=email )

The following approvals got outdated and were removed:
Code-Review+2 by cron2

Change subject: Clarify that the tls-crypt-v2-verify has a very limited env set
......................................................................

Clarify that the tls-crypt-v2-verify has a very limited env set

Change-Id Ida4d22455c51773b6713caf94a4b4fbe136a6ded

Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg27944.html

---
M doc/man-sections/tls-options.rst

1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/88/488/3

doc/man-sections/tls-options.rst +3 -1
index 4c45b10..460cecf 100644
@@ -538,7 +538,9 @@
   stack (including the notoriously dangerous X.509 and ASN.1 stacks) to
   the connecting client.
 
-  OpenVPN supplies the following environment variables to the command:
+  OpenVPN supplies the following environment variables to the command (and
+  only these variables. The normal environment variables available for
+  other scripts are NOT present):
 
   * :code:`script_type` is set to :code:`tls-crypt-v2-verify`
 

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/488?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ida4d22455c51773b6713caf94a4b4fbe136a6ded
Gerrit-Change-Number: 488
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: newpatchset

#7 lore raw
In reply to a message not in the archive

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/488?usp=email )

Change subject: Clarify that the tls-crypt-v2-verify has a very limited env set
......................................................................

Clarify that the tls-crypt-v2-verify has a very limited env set

Change-Id Ida4d22455c51773b6713caf94a4b4fbe136a6ded

Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg27944.html

---
M doc/man-sections/tls-options.rst

1 file changed, 3 insertions(+), 1 deletion(-)
doc/man-sections/tls-options.rst +3 -1
index 4c45b10..460cecf 100644
@@ -538,7 +538,9 @@
   stack (including the notoriously dangerous X.509 and ASN.1 stacks) to
   the connecting client.
 
-  OpenVPN supplies the following environment variables to the command:
+  OpenVPN supplies the following environment variables to the command (and
+  only these variables. The normal environment variables available for
+  other scripts are NOT present):
 
   * :code:`script_type` is set to :code:`tls-crypt-v2-verify`
 

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/488?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ida4d22455c51773b6713caf94a4b4fbe136a6ded
Gerrit-Change-Number: 488
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: merged