Skip to contentSkip to conversation

gcr: depends on gnupg-native

PATCH In review kai 3 participants 5 messages May 11, 2020 – May 15, 2020

lore
Share & tools
lore

kai

author
#0 lore raw

PATCH 1/1 gcr: depends on gnupg-native

From: Kai Kang <[email protected]>

It fails to build gcr if no commmand gpg on build host:

| meson.build:44:0: ERROR: Program(s) ['gpg2', 'gpg'] not found or not executable

Add dependency gnupg-native to fix the error.

---
 meta/recipes-gnome/gcr/gcr_3.36.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-gnome/gcr/gcr_3.36.0.bb +1 -1
index 4fe3b2fff3..458dc8e6c4 100644
@@ -8,7 +8,7 @@ BUGTRACKER = "https://gitlab.gnome.org/GNOME/gcr/issues"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=55ca817ccb7d5b5b66355690e9abc605"
 
-DEPENDS = "gtk+3 p11-kit glib-2.0 libgcrypt \
+DEPENDS = "gtk+3 p11-kit glib-2.0 libgcrypt gnupg-native \
            ${@bb.utils.contains('GI_DATA_ENABLED', 'True', 'libxslt-native', '', d)}"
 
 GNOMEBASEBUILDCLASS = "meson"
Signature · 1 line
2.17.1
author
#1 lore raw
Quoted 18 lines · On 2020/5/11 下午5:23, [email protected] wrote:

From: Kai Kang <[email protected]>

It fails to build gcr if no commmand gpg on build host:

| meson.build:44:0: ERROR: Program(s) ['gpg2', 'gpg'] not found or not executable

Add dependency gnupg-native to fix the error.

---
  meta/recipes-gnome/gcr/gcr_3.36.0.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-gnome/gcr/gcr_3.36.0.bb +0 -0
index 4fe3b2fff3..458dc8e6c4 100644

meta/recipes-gnome/gcr/gcr_3.36.0.bb BUGTRACKER = "https://gitlab.gnome.org/GNOME/gcr/issues" · line 14

Quoted 8 lines
meta/recipes-gnome/gcr/gcr_3.36.0.bb +1 -1
@@ -8,7 +8,7 @@ BUGTRACKER = "https://gitlab.gnome.org/GNOME/gcr/issues"
  LICENSE = "GPLv2"
  LIC_FILES_CHKSUM = "file://COPYING;md5=55ca817ccb7d5b5b66355690e9abc605"
 
-DEPENDS = "gtk+3 p11-kit glib-2.0 libgcrypt \
+DEPENDS = "gtk+3 p11-kit glib-2.0 libgcrypt gnupg-native \
             ${@bb.utils.contains('GI_DATA_ENABLED', 'True', 'libxslt-native', '', d)}"
 
  GNOMEBASEBUILDCLASS = "meson"

Any comment, please?

Signature · 2 lines
Kai Kang
Wind River Linux
#2 lore raw
Quoted 26 lines · kai
Quoted 25 lines · On 2020/5/11 下午5:23, [email protected] wrote:

From: Kai Kang <[email protected]>

It fails to build gcr if no commmand gpg on build host:

Quoted 2 lines

meson.build:44:0: ERROR: Program(s) ['gpg2', 'gpg'] not found or not executable

Add dependency gnupg-native to fix the error.

---
  meta/recipes-gnome/gcr/gcr_3.36.0.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes- renamed from meta/recipes-gnome/gcr/gcr_3.36.0.bb +0 -0

gnome/gcr/gcr_3.36.0.bb
index 4fe3b2fff3..458dc8e6c4 100644

meta/recipes-gnome/gcr/gcr_3.36.0.bb +0 -0
@@ -8,7 +8,7 @@ BUGTRACKER = "

https://gitlab.gnome.org/GNOME/gcr/issues"
LICENSE = "GPLv2"
LIC_FILES_CHKSUM =
"file://COPYING;md5=55ca817ccb7d5b5b66355690e9abc605"

Quoted 8 lines
Quoted 6 lines
meta/recipes-gnome/gcr/gcr_3.36.0.bb +1 -1
-DEPENDS = "gtk+3 p11-kit glib-2.0 libgcrypt \
+DEPENDS = "gtk+3 p11-kit glib-2.0 libgcrypt gnupg-native \
             ${@bb.utils.contains('GI_DATA_ENABLED', 'True',

'libxslt-native', '', d)}"

GNOMEBASEBUILDCLASS = "meson"

Any comment, please?

Why did this happen? Was this as a result of the move to meson? Is it really needed and can we avoid it? native dependencies like this are a pain from a build performance perspective...

Cheers,

Richard

#3 lore raw

Looking gcr's autotools and meson build files, gpg executable is required in both. Gcr is needed only by epiphany, so I don't think build performance will suffer much.

Alex

Quoted 46 lines · Richard Purdie
Quoted 26 lines · kai
Quoted 25 lines · On 2020/5/11 下午5:23, [email protected] wrote:

From: Kai Kang <[email protected]>

It fails to build gcr if no commmand gpg on build host:

Quoted 2 lines

meson.build:44:0: ERROR: Program(s) ['gpg2', 'gpg'] not found or not executable

Add dependency gnupg-native to fix the error.

---
  meta/recipes-gnome/gcr/gcr_3.36.0.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes- renamed from meta/recipes-gnome/gcr/gcr_3.36.0.bb +0 -0

gnome/gcr/gcr_3.36.0.bb
index 4fe3b2fff3..458dc8e6c4 100644

meta/recipes-gnome/gcr/gcr_3.36.0.bb +0 -0
@@ -8,7 +8,7 @@ BUGTRACKER = "

https://gitlab.gnome.org/GNOME/gcr/issues"
LICENSE = "GPLv2"
LIC_FILES_CHKSUM =
"file://COPYING;md5=55ca817ccb7d5b5b66355690e9abc605"

Quoted 8 lines
Quoted 6 lines
meta/recipes-gnome/gcr/gcr_3.36.0.bb +1 -1
-DEPENDS = "gtk+3 p11-kit glib-2.0 libgcrypt \
+DEPENDS = "gtk+3 p11-kit glib-2.0 libgcrypt gnupg-native \
             ${@bb.utils.contains('GI_DATA_ENABLED', 'True',

'libxslt-native', '', d)}"

GNOMEBASEBUILDCLASS = "meson"

Any comment, please?

Why did this happen? Was this as a result of the move to meson? Is it really needed and can we avoid it? native dependencies like this are a pain from a build performance perspective...

Cheers,

Richard

author
#4 lore raw
Quoted 1 line · Alexander Kanavin

Looking gcr's autotools and meson build files, gpg executable is required in both. Gcr is needed only by epiphany, so I don't think build performance will suffer much.

It seems gcr requires command gpg long long time ago(about 8 years). But I don't know why just exposed recently.

https://gitlab.gnome.org/GNOME/gcr/-/commit/c6691faa0348ab087e99ab9bd9914e1d5e81fa14

Regards,
Kai

Quoted 56 lines

Alex

On Thu, 14 May 2020 at 15:26, Richard Purdie <[email protected] <mailto:[email protected]>> wrote:

    On Thu, 2020-05-14 at 09:59 +0800, kai wrote:
    > On 2020/5/11 下午5:23, [email protected]
    <mailto:[email protected]> wrote:
    > > From: Kai Kang <[email protected]
    <mailto:[email protected]>>
    > >
    > > It fails to build gcr if no commmand gpg on build host:
    > >
    > > > meson.build:44:0: ERROR: Program(s) ['gpg2', 'gpg'] not found or
    > > > not executable
    > >
    > > Add dependency gnupg-native to fix the error.
    > >
    > > Signed-off-by: Kai Kang <[email protected]
    <mailto:[email protected]>>
    > > ---
    > >   meta/recipes-gnome/gcr/gcr_3.36.0.bb <http://gcr_3.36.0.bb>
    | 2 +-
    > >   1 file changed, 1 insertion(+), 1 deletion(-)
    > >
    > > diff --git a/meta/recipes-gnome/gcr/gcr_3.36.0.bb
    <http://gcr_3.36.0.bb> b/meta/recipes-
    > > gnome/gcr/gcr_3.36.0.bb <http://gcr_3.36.0.bb>
    > > index 4fe3b2fff3..458dc8e6c4 100644
    > > --- a/meta/recipes-gnome/gcr/gcr_3.36.0.bb <http://gcr_3.36.0.bb>
    > > +++ b/meta/recipes-gnome/gcr/gcr_3.36.0.bb <http://gcr_3.36.0.bb>
    > > @@ -8,7 +8,7 @@ BUGTRACKER = "
    > > https://gitlab.gnome.org/GNOME/gcr/issues"
    > >   LICENSE = "GPLv2"
    > >   LIC_FILES_CHKSUM =
    > > "file://COPYING;md5=55ca817ccb7d5b5b66355690e9abc605"
    > >
    > > -DEPENDS = "gtk+3 p11-kit glib-2.0 libgcrypt \
    > > +DEPENDS = "gtk+3 p11-kit glib-2.0 libgcrypt gnupg-native \
    > >              ${@bb.utils.contains('GI_DATA_ENABLED', 'True',
    > > 'libxslt-native', '', d)}"
    > >
    > >   GNOMEBASEBUILDCLASS = "meson"
    >
    > Any comment, please?

    Why did this happen? Was this as a result of the move to meson? Is it
    really needed and can we avoid it? native dependencies like this are a
    pain from a build performance perspective...

    Cheers,

    Richard
Signature · 2 lines
Kai Kang
Wind River Linux