net: phy: fix duplex out of sync problem while changing settings
Subsystems (3)
Heiner Kallweit
maintainerPATCH 1/1 net: phy: fix duplex out of sync problem while changing settings
As reported by Zhang there's a small issue if in forced mode the duplex mode changes with the link staying up [0]. In this case the MAC isn't notified about the change.
The proposed patch relies on the phylib state machine and ignores the fact that there are drivers that uses phylib but not the phylib state machine. So let's don't change the behavior for such drivers and fix it w/o re-adding state PHY_FORCING for the case that phylib state machine is used.
[0] https://lore.kernel.org/netdev/[email protected]/T/
--- drivers/net/phy/phy.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/net/phy/phy.c +6 -1
@@ -815,7 +815,12 @@ int phy_ethtool_ksettings_set(struct phy_device *phydev, phydev->mdix_ctrl = cmd->base.eth_tp_mdix_ctrl;/* Restart the PHY */ -_phy_start_aneg (phydev); +if (phy_is_started (phydev)) { + phydev->state =PHY_UP ; +phy_trigger_machine (phydev); + }else { +_phy_start_aneg (phydev); + }mutex_unlock (&phydev->lock);return 0 ;
Signature · 1 line
2.33.1
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:
Quoted 11 lines · On Wed, 3 Nov 2021 22:08:28 +0100 you wrote:
As reported by Zhang there's a small issue if in forced mode the duplex mode changes with the link staying up [0]. In this case the MAC isn't notified about the change.
The proposed patch relies on the phylib state machine and ignores the fact that there are drivers that uses phylib but not the phylib state machine. So let's don't change the behavior for such drivers and fix it w/o re-adding state
PHY_FORCINGfor the case that phylib state machine is used.[...]
Here is the summary with links:
- [net] net: phy: fix duplex out of sync problem while changing settings
https://git.kernel.org/netdev/net/c/a4db9055fdb9
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html