parport: ieee1284: mark expected switch fall-through
PATCH 1/1 parport: ieee1284: mark expected switch fall-through
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/parport/ieee1284.c: In function ‘parport_read’:drivers/parport/ieee1284.c:722:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (parport_negotiate (port, IEEE1284_MODE_NIBBLE)) {
^drivers/parport/ieee1284.c:726:2: note: here
case IEEE1284_MODE_NIBBLE:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
--- drivers/parport/ieee1284.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/parport/ieee1284.c +1 -1
@@ -722,7 +722,7 @@ ssize_t parport_read (struct parport *port, void *buffer, size_t len)if (parport_negotiate (port,IEEE1284_MODE_NIBBLE )) {return -EIO ; } -/* fall through to NIBBLE */ +/* fall through - to NIBBLE */ case IEEE1284_MODE_NIBBLE :DPRINTK (KERN_DEBUG "%s: Using nibble mode\n" , port->name); fn = port->ops->nibble_read_data;
Signature · 1 line
2.20.1
Hi,
Friendly ping:
Who can take this, please?
Thanks
--
Gustavo
Quoted 40 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/parport/ieee1284.c: In function ‘parport_read’:drivers/parport/ieee1284.c:722:6: warning: this statement may fall through [-Wimplicit-fallthrough=]if (parport_negotiate (port, IEEE1284_MODE_NIBBLE)) { ^
drivers/parport/ieee1284.c:726:2: note: here
caseIEEE1284_MODE_NIBBLE:
^~~~Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/parport/ieee1284.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/parport/ieee1284.c +1
-1@@ -722,7 +722,7 @@ ssize_t parport_read (struct parport *port, void *buffer, size_t len)if (parport_negotiate (port,IEEE1284_MODE_NIBBLE )) {return -EIO ; } -/* fall through to NIBBLE */ +/* fall through - to NIBBLE */ case IEEE1284_MODE_NIBBLE :DPRINTK (KERN_DEBUG "%s: Using nibble mode\n" , port->name); fn = port->ops->nibble_read_data;
Greg,
Can you take this, please?
Thanks
--
Gustavo
Quoted 51 lines · Gustavo A. R. Silva
Hi,
Friendly ping:
Who can take this, please?
Thanks
--
GustavoQuoted 40 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/parport/ieee1284.c: In function ‘parport_read’:drivers/parport/ieee1284.c:722:6: warning: this statement may fall through [-Wimplicit-fallthrough=]if (parport_negotiate (port, IEEE1284_MODE_NIBBLE)) { ^
drivers/parport/ieee1284.c:726:2: note: here
caseIEEE1284_MODE_NIBBLE:
^~~~Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/parport/ieee1284.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/parport/ieee1284.c +1
-1@@ -722,7 +722,7 @@ ssize_t parport_read (struct parport *port, void *buffer, size_t len)if (parport_negotiate (port,IEEE1284_MODE_NIBBLE )) {return -EIO ; } -/* fall through to NIBBLE */ +/* fall through - to NIBBLE */ case IEEE1284_MODE_NIBBLE :DPRINTK (KERN_DEBUG "%s: Using nibble mode\n" , port->name); fn = port->ops->nibble_read_data;
Quoted 3 lines · Gustavo A. R. Silva
Greg,
Can you take this, please?
Will do, give me a week or so to catch up...
thanks,
greg k-h
Quoted 7 lines · Greg KH
Quoted 3 lines · Gustavo A. R. Silva
Greg,
Can you take this, please?
Will do, give me a week or so to catch up...
Sure thing.
Thanks
--
Gustavo
Sudip Mukherjee
maintainerHi Greg,
Quoted 7 lines · Greg KH
Quoted 3 lines · Gustavo A. R. Silva
Greg,
Can you take this, please?
Will do, give me a week or so to catch up...
I will send it to you with the another parport regression fix I have. Will send you by next week.
Signature · 2 lines
Regards Sudip