Revert "irqchip/mtk-sysirq: Convert to a platform driver"
Subsystems (2)
PATCH 1/1 Revert "irqchip/mtk-sysirq: Convert to a platform driver"
From: Frank Wunderlich <[email protected]>
This reverts commit f97dbf48ca43009e8b8bcdf07f47fc9f06149b36 which breaks bootup of arm/arm64 devices like bananapi-r2/mt7623 and bananapi-r64/mt7622
--- drivers/irqchip/irq-mtk-sysirq.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/irqchip/irq-mtk-sysirq.c +1 -3
@@ -231,6 +231,4 @@ static int __init mtk_sysirq_of_init(struct device_node *node,kfree (chip_data);return ret; } -IRQCHIP_PLATFORM_DRIVER_BEGIN(mtk_sysirq) -IRQCHIP_MATCH("mediatek,mt6577-sysirq", mtk_sysirq_of_init) -IRQCHIP_PLATFORM_DRIVER_END (mtk_sysirq) +IRQCHIP_DECLARE (mtk_sysirq,"mediatek,mt6577-sysirq" , mtk_sysirq_of_init);
Signature · 7 lines
2.25.1 _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek
Hi Frank,
Missatge de Frank Wunderlich <[email protected]> del dia dl., 17 d’ag. 2020 a les 16:58:
Quoted 8 lines
From: Frank Wunderlich <[email protected]>
This reverts commit
f97dbf48ca43009e8b8bcdf07f47fc9f06149b36which breaks bootup of arm/arm64 devices like bananapi-r2/mt7623 and bananapi-r64/mt7622Signed-off-by Frank Wunderlich <[email protected]>
I already answered your BUG report, but, for the record, I think a proper fix is following his way [1] and probably will be merged soon.
Thanks,
Enric
Quoted 24 lines
--- drivers/irqchip/irq-mtk-sysirq.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/irqchip/irq-mtk-sysirq.c +1
-4@@ -231,6 +231,4 @@ static int __init mtk_sysirq_of_init(struct device_node *node,kfree (chip_data);return ret; } -IRQCHIP_PLATFORM_DRIVER_BEGIN(mtk_sysirq) -IRQCHIP_MATCH("mediatek,mt6577-sysirq", mtk_sysirq_of_init) -IRQCHIP_PLATFORM_DRIVER_END(mtk_sysirq) +IRQCHIP_DECLARE (mtk_sysirq,"mediatek,mt6577-sysirq" , mtk_sysirq_of_init); --2.25.1
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Am 17. August 2020 17:04:32 MESZ schrieb Enric Balletbo Serra <[email protected]>:
Quoted 5 lines
I already answered your BUG report, but, for the record, I think a proper fix is following his way [1] and probably will be merged soon.
with Patch "irqchip: Fix probing deferal when using IRQCHIP_PLATFORM_DRIVER helper" i can boot my board, but i get these errors:
[ 0.014234] irq: no irq domain found for interrupt-controller@10200100 ! [ 0.020981] Failed to map interrupt for /timer@10008000 [ 0.026248] Failed to initialize '/timer@10008000': -22 [ 4.314126] hw perfevents: /pmu: failed to register PMU devices!
if i revert f97dbf48ca43009e8b8bcdf07f47fc9f06149b36 these are gone regards Frank
Quoted 24 lines · Frank Wunderlich
From: Frank Wunderlich <[email protected]>
This reverts commit
f97dbf48ca43009e8b8bcdf07f47fc9f06149b36which breaks bootup of arm/arm64 devices like bananapi-r2/mt7623 and bananapi-r64/mt7622Signed-off-by Frank Wunderlich <[email protected]>--- drivers/irqchip/irq-mtk-sysirq.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/irqchip/irq-mtk-sysirq.c +1
-3@@ -231,6 +231,4 @@ static int __init mtk_sysirq_of_init(structdevice_node *node,kfree (chip_data );return ret; } -IRQCHIP_PLATFORM_DRIVER_BEGIN(mtk_sysirq) -IRQCHIP_MATCH("mediatek,mt6577-sysirq", mtk_sysirq_of_init) -IRQCHIP_PLATFORM_DRIVER_END (mtk_sysirq) +IRQCHIP_DECLARE(mtk_sysirq, "mediatek,mt6577-sysirq",
Quoted 1 line
mtk_sysirq_of_init);
There is already a fix queued for this.
M.
Signature · 6 lines
Jazz is not dead. It just smells funny... _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek