Skip to contentSkip to conversation

Add missing allocation failure check

PATCH In review Sai Vishnu M 2 participants 2 messages Jul 17 – Sep 9 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add missing allocation failure check

---
 utils/common/keymap.c | 11 ++++++++++-

1 file change
d, 10 insertions(+), 1 deletion(-)

utils/common/keymap.c +10 -1
index 21c1c0b5..b881187a 100644
@@ -124,7 +124,11 @@ static error_t parse_plain_keymap(char *fname, struct keymap **keymap, bool verb
 							struct keymap *k;
 
 							k = calloc(1, sizeof(*k));
-							k->protocol = strdup(p);
+                            if (!k) {
+								perror("parse_keymap");
+								return ENOMEM;
+							}
+                            k->protocol = strdup(p);
 							k->next = map->next;
 							map->next = k;
 						}
@@ -399,6 +403,11 @@ static error_t parse_toml_protocol(const char *fname, struct toml_table_t *proot
 			struct protocol_param *param;
 
 			param = malloc(sizeof(*param));
+			if (!param) {
+				perror("parse_toml_protocol");
+				free_keymap(map);
+				return ENOMEM;
+			}
 			param->name = strdup(key);
 			param->value = value;
 			param->next = map->param;
Signature · 1 line
2.55.0
#1 lore raw

No commit message, improper indentation, and not really worth the effort for a simple userspace utility.

Sorry, I'm rejecting this patch.

Regards,

Hans

Quoted 35 lines · Sai Vishnu M
---
 utils/common/keymap.c | 11 ++++++++++-

1 file change
d, 10 insertions(+), 1 deletion(-)

utils/common/keymap.c +10 -1
index 21c1c0b5..b881187a 100644
@@ -124,7 +124,11 @@ static error_t parse_plain_keymap(char *fname, struct keymap **keymap, bool verb
 							struct keymap *k;
 
 							k = calloc(1, sizeof(*k));
-							k->protocol = strdup(p);
+                            if (!k) {
+								perror("parse_keymap");
+								return ENOMEM;
+							}
+                            k->protocol = strdup(p);
 							k->next = map->next;
 							map->next = k;
 						}
@@ -399,6 +403,11 @@ static error_t parse_toml_protocol(const char *fname, struct toml_table_t *proot
 			struct protocol_param *param;
 
 			param = malloc(sizeof(*param));
+			if (!param) {
+				perror("parse_toml_protocol");
+				free_keymap(map);
+				return ENOMEM;
+			}
 			param->name = strdup(key);
 			param->value = value;
 			param->next = map->param;